Message ID | 1511879725-9576-1-git-send-email-peter.maydell@linaro.org |
---|---|
Headers | show |
Series | linux-user: Fix race between threads in page_unprotect() | expand |
On 28 November 2017 at 14:35, Peter Maydell <peter.maydell@linaro.org> wrote: > If multiple guest threads in user-mode emulation write to a > page which QEMU has marked read-only because of cached TCG > translations, the threads can race in page_unprotect: > Peter Maydell (2): > linux-user: Propagate siginfo_t through to handle_cpu_signal() > page_unprotect(): handle calls to pages that are PAGE_WRITE Ping! Linux-user maintainers, any chance this could get into a pull-request sometime soon? (I have another cleanup I'm thinking of that will touch the same code so I'd rather this went into master before I look at that.) (I have a bunch of other pending linux-user patchsets which I shan't bother to ping individually unless you want me to.) thanks -- PMM
Le 15/01/2018 à 13:48, Peter Maydell a écrit : > On 28 November 2017 at 14:35, Peter Maydell <peter.maydell@linaro.org> wrote: >> If multiple guest threads in user-mode emulation write to a >> page which QEMU has marked read-only because of cached TCG >> translations, the threads can race in page_unprotect: > >> Peter Maydell (2): >> linux-user: Propagate siginfo_t through to handle_cpu_signal() >> page_unprotect(): handle calls to pages that are PAGE_WRITE > > Ping! Linux-user maintainers, any chance this could get into > a pull-request sometime soon? (I have another cleanup I'm > thinking of that will touch the same code so I'd rather this > went into master before I look at that.) > > (I have a bunch of other pending linux-user patchsets which > I shan't bother to ping individually unless you want me to.) Riku, if you have no time to prepare a pull request, I can. Thanks, Laurent
Hi Laurent, On Mon, Jan 15, 2018 at 01:52:32PM +0100, Laurent Vivier wrote: > Le 15/01/2018 à 13:48, Peter Maydell a écrit : > > On 28 November 2017 at 14:35, Peter Maydell <peter.maydell@linaro.org> wrote: > >> If multiple guest threads in user-mode emulation write to a > >> page which QEMU has marked read-only because of cached TCG > >> translations, the threads can race in page_unprotect: > > > >> Peter Maydell (2): > >> linux-user: Propagate siginfo_t through to handle_cpu_signal() > >> page_unprotect(): handle calls to pages that are PAGE_WRITE > > > > Ping! Linux-user maintainers, any chance this could get into > > a pull-request sometime soon? (I have another cleanup I'm > > thinking of that will touch the same code so I'd rather this > > went into master before I look at that.) > > > > (I have a bunch of other pending linux-user patchsets which > > I shan't bother to ping individually unless you want me to.) > > Riku, > > if you have no time to prepare a pull request, I can. Thanks, that would be great. Riku
Le 19/01/2018 à 15:51, Riku Voipio a écrit : > Hi Laurent, > > On Mon, Jan 15, 2018 at 01:52:32PM +0100, Laurent Vivier wrote: >> Le 15/01/2018 à 13:48, Peter Maydell a écrit : >>> On 28 November 2017 at 14:35, Peter Maydell <peter.maydell@linaro.org> wrote: >>>> If multiple guest threads in user-mode emulation write to a >>>> page which QEMU has marked read-only because of cached TCG >>>> translations, the threads can race in page_unprotect: >>> >>>> Peter Maydell (2): >>>> linux-user: Propagate siginfo_t through to handle_cpu_signal() >>>> page_unprotect(): handle calls to pages that are PAGE_WRITE >>> >>> Ping! Linux-user maintainers, any chance this could get into >>> a pull-request sometime soon? (I have another cleanup I'm >>> thinking of that will touch the same code so I'd rather this >>> went into master before I look at that.) >>> >>> (I have a bunch of other pending linux-user patchsets which >>> I shan't bother to ping individually unless you want me to.) >> >> Riku, >> >> if you have no time to prepare a pull request, I can. > > Thanks, that would be great. OK, I'm going to prepare it. Thanks, Laurent
Le 15/01/2018 à 13:48, Peter Maydell a écrit : > On 28 November 2017 at 14:35, Peter Maydell <peter.maydell@linaro.org> wrote: >> If multiple guest threads in user-mode emulation write to a >> page which QEMU has marked read-only because of cached TCG >> translations, the threads can race in page_unprotect: > >> Peter Maydell (2): >> linux-user: Propagate siginfo_t through to handle_cpu_signal() >> page_unprotect(): handle calls to pages that are PAGE_WRITE > > Ping! Linux-user maintainers, any chance this could get into > a pull-request sometime soon? (I have another cleanup I'm > thinking of that will touch the same code so I'd rather this > went into master before I look at that.) > > (I have a bunch of other pending linux-user patchsets which > I shan't bother to ping individually unless you want me to.) > > thanks > -- PMM > I've applied this series to my linux-user branch. I've tried to find all pending linux-user patches. If you want to check none of yours is is missing, all patches I have collected are in: https://github.com/vivier/qemu/commits/linux-user-for-2.12 I'm going to run some tests before sending the pull request. Thanks, Laurent
Le 19/01/2018 à 15:51, Riku Voipio a écrit : > Hi Laurent, > > On Mon, Jan 15, 2018 at 01:52:32PM +0100, Laurent Vivier wrote: >> Le 15/01/2018 à 13:48, Peter Maydell a écrit : >>> On 28 November 2017 at 14:35, Peter Maydell <peter.maydell@linaro.org> wrote: >>>> If multiple guest threads in user-mode emulation write to a >>>> page which QEMU has marked read-only because of cached TCG >>>> translations, the threads can race in page_unprotect: >>> >>>> Peter Maydell (2): >>>> linux-user: Propagate siginfo_t through to handle_cpu_signal() >>>> page_unprotect(): handle calls to pages that are PAGE_WRITE >>> >>> Ping! Linux-user maintainers, any chance this could get into >>> a pull-request sometime soon? (I have another cleanup I'm >>> thinking of that will touch the same code so I'd rather this >>> went into master before I look at that.) >>> >>> (I have a bunch of other pending linux-user patchsets which >>> I shan't bother to ping individually unless you want me to.) >> >> Riku, >> >> if you have no time to prepare a pull request, I can. > > Thanks, that would be great. Riku, if you agree, I can continue to collect patches for the next pull-request. It's easier to collect patches on the fly than scanning the ML when we want to create a pull request. Thanks, Laurent