| Message ID | 20171215170732.31125-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | TCG misc patches | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171215170732.31125-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH 0/7] TCG misc patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20171215150659.1811-1-marcandre.lureau@redhat.com -> patchew/20171215150659.1811-1-marcandre.lureau@redhat.com
t [tag update] patchew/20171215170732.31125-1-richard.henderson@linaro.org -> patchew/20171215170732.31125-1-richard.henderson@linaro.org
Switched to a new branch 'test'
0f3e6cd784 tcg: Allow 6 arguments to TCG helpers
2db8c41624 tcg: Add tcg_signed_cond
8a3f01b0dc tcg: Generalize TCGOp parameters
ce23558fc9 tcg: Dynamically allocate TCGOps
3e926c3bf9 tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*
d312cd9375 target/moxie: Fix tlb_fill
8186363e41 target/*helper: don't check retaddr before calling cpu_restore_state
=== OUTPUT BEGIN ===
Checking PATCH 1/7: target/*helper: don't check retaddr before calling cpu_restore_state...
Checking PATCH 2/7: target/moxie: Fix tlb_fill...
Checking PATCH 3/7: tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*...
Checking PATCH 4/7: tcg: Dynamically allocate TCGOps...
ERROR: line over 90 characters
#64: FILE: include/qemu/queue.h:430:
+ (var) && ((prev_var) = (*(((struct headname *)((var)->field.tqe_prev))->tqh_last)), 1); \
ERROR: spaces prohibited around that ':' (ctx:WxW)
#538: FILE: tcg/tcg.h:575:
+ unsigned life : 16; /* 32 */
^
total: 2 errors, 0 warnings, 520 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/7: tcg: Generalize TCGOp parameters...
ERROR: spaces prohibited around that ':' (ctx:WxW)
#114: FILE: tcg/tcg.h:570:
+ unsigned param1 : 4; /* 12 */
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#115: FILE: tcg/tcg.h:571:
+ unsigned param2 : 4; /* 16 */
^
ERROR: Macros with complex values should be enclosed in parenthesis
#123: FILE: tcg/tcg.h:583:
+#define TCGOP_CALLI(X) (X)->param1
ERROR: Macros with complex values should be enclosed in parenthesis
#124: FILE: tcg/tcg.h:584:
+#define TCGOP_CALLO(X) (X)->param2
total: 4 errors, 0 warnings, 92 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/7: tcg: Add tcg_signed_cond...
Checking PATCH 7/7: tcg: Allow 6 arguments to TCG helpers...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org