mbox series

[PULL,v2,00/57] add check-tcg and associated machinery

Message ID 20180621062605.941-1-alex.bennee@linaro.org
Headers show
Series add check-tcg and associated machinery | expand

Message

Alex Bennée June 21, 2018, 6:25 a.m. UTC
The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b:

  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100)

are available in the Git repository at:

  https://github.com/stsquad/qemu.git tags/pull-tcg-testing-revivial-210618-2

for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:

  .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)

----------------------------------------------------------------
Add check-tcg machinary

This restores the ability to run TCG smoke tests by using our docker
infrastructure to support cross building simple tests. It represents
the first step to making better cross-architecture testing available
straight from the source tree ;-)

v2
  - fix quoting of target_compiler
  - make docker.py Py3 safe
  - tweak .travis.yml recipe
  - don't probe docker when HAVE_USER_DOCKER not set

----------------------------------------------------------------
Alex Bennée (55):
      docker: docker.py wrap StringIO import for python3
      configure: add support for --cross-cc-FOO
      configure: move i386_cc to cross_cc_i386
      configure: allow user to specify --cross-cc-cflags-foo=
      configure: set cross_cc_FOO for host compiler
      docker: Add "cc" subcommand
      docker: extend "cc" command to accept compiler
      docker: allow "cc" command to run in user context
      docker: Makefile.include introduce DOCKER_SCRIPT
      tests/tcg: move architecture independent tests into subdir
      tests/tcg/multiarch: enable additional linux-test tests
      tests/tcg/multiarch: don't hard code paths/ports for linux-test
      tests/tcg/multiarch: move most output to stdout
      tests/tcg: move i386 specific tests into subdir
      tests/tcg: enable building for i386
      tests/tcg/i386: fix test-i386
      tests/tcg/i386: add runner for test-i386-fprem
      tests/tcg/x86_64: add Makefile.target
      tests/tcg/i386/test-i386: use modern vector_size attributes
      tests/tcg/i386/test-i386: fix printf format
      tests/tcg: move ARM specific tests into subdir
      tests/tcg: enable building for ARM
      tests/tcg/arm: fix up test-arm-iwmmxt test
      tests/tcg: enable building for AArch64
      tests/tcg/arm: add fcvt test cases for AArch32/64
      tests/tcg: move MIPS specific tests into subdir
      tests/tcg: enable building for MIPS
      tests/docker/Makefile.include: fix mipsel-cross dependancy
      tests/tcg/mips: include common mips hello-mips
      tests/tcg: enable building for s390x
      tests/tcg: enable building for ppc64
      tests/tcg: enable building for Alpha
      tests/tcg/alpha: add Alpha specific tests
      tests/tcg: enable building for HPPA
      tests/tcg: enable building for m68k
      tests/tcg: enable building for sh4
      tests/tcg: enable building for sparc64
      tests/tcg: enable building for mips64
      tests/tcg: enable building for RISCV64
      docker: move debian-powerpc-cross to sid based build
      tests/tcg: enable building for PowerPC
      tests/tcg/Makefile: update to be called from Makefile.target
      Makefile.target: add (clean-/build-)guest-tests targets
      tests/Makefile.include: add [build|clean|check]-tcg targets
      tests/tcg: add run, diff, and skip helper macros
      tests/tcg: override runners for broken tests
      tests/tcg/i386: extend timeout for runcom test
      tests: add top-level make dependency for docker builds
      docker: docker.py use "version" to probe usage
      docker: docker.py don't conflate checksums for extra_files
      docker: docker.py add check sub-command
      tests/Makefile: call sub-makes with SKIP_DOCKER_BUILD=1
      docker: docker.py adding age check command
      tests/docker/Makefile.include: only force SID to NOCACHE if old
      .travis.yml: add check-tcg test

Fam Zheng (2):
      tests/tcg/multiarch: Build fix for linux-test
      tests/tcg/i386: Build fix for hello-i386

 .travis.yml                                        |    8 +
 MAINTAINERS                                        |   15 +
 Makefile.target                                    |    5 +
 configure                                          |  133 +-
 tests/Makefile.include                             |   38 +-
 tests/docker/Makefile.include                      |   47 +-
 tests/docker/docker.py                             |  112 +-
 tests/docker/dockerfiles/debian-alpha-cross.docker |   12 +
 tests/docker/dockerfiles/debian-apt-fake.sh        |   46 -
 tests/docker/dockerfiles/debian-hppa-cross.docker  |   12 +
 tests/docker/dockerfiles/debian-m68k-cross.docker  |   12 +
 .../docker/dockerfiles/debian-mips64-cross.docker  |   12 +
 .../docker/dockerfiles/debian-powerpc-cross.docker |   39 +-
 .../docker/dockerfiles/debian-riscv64-cross.docker |   12 +
 tests/docker/dockerfiles/debian-sh4-cross.docker   |   12 +
 tests/docker/dockerfiles/debian-sid.docker         |   32 +
 .../docker/dockerfiles/debian-sparc64-cross.docker |   12 +
 tests/docker/dockerfiles/debian8.docker            |    3 -
 tests/tcg/Makefile                                 |  219 +-
 tests/tcg/Makefile.include                         |   88 +
 tests/tcg/Makefile.probe                           |   31 +
 tests/tcg/README                                   |   69 +-
 tests/tcg/aarch64/Makefile.include                 |    8 +
 tests/tcg/aarch64/Makefile.target                  |   17 +
 tests/tcg/aarch64/fcvt.ref                         | 3268 ++++++++++++++++++++
 tests/tcg/alpha/Makefile                           |   35 -
 tests/tcg/alpha/Makefile.include                   |    2 +
 tests/tcg/alpha/Makefile.target                    |   18 +
 tests/tcg/alpha/crt.s                              |   26 -
 tests/tcg/alpha/hello-alpha.c                      |    2 +
 tests/tcg/alpha/test-cond.c                        |    1 +
 tests/tcg/alpha/test-ovf.c                         |    2 +
 tests/tcg/arm/Makefile.include                     |    8 +
 tests/tcg/arm/Makefile.target                      |   32 +
 tests/tcg/arm/README                               |   11 +
 tests/tcg/arm/fcvt.c                               |  458 +++
 tests/tcg/arm/fcvt.ref                             | 3268 ++++++++++++++++++++
 tests/tcg/{ => arm}/hello-arm.c                    |    0
 .../{test-arm-iwmmxt.s => arm/test-arm-iwmmxt.S}   |    0
 tests/tcg/hppa/Makefile.include                    |    2 +
 tests/tcg/hppa/Makefile.target                     |    6 +
 tests/tcg/i386/Makefile.include                    |    9 +
 tests/tcg/i386/Makefile.target                     |   52 +
 tests/tcg/i386/README                              |   38 +
 tests/tcg/{ => i386}/hello-i386.c                  |    1 +
 tests/tcg/{ => i386}/pi_10.com                     |  Bin
 tests/tcg/{ => i386}/runcom.c                      |    0
 tests/tcg/{ => i386}/test-i386-code16.S            |    0
 tests/tcg/{ => i386}/test-i386-fprem.c             |   12 +-
 tests/tcg/{ => i386}/test-i386-muldiv.h            |    0
 tests/tcg/{ => i386}/test-i386-shift.h             |    0
 tests/tcg/{ => i386}/test-i386-ssse3.c             |    0
 tests/tcg/{ => i386}/test-i386-vm86.S              |    0
 tests/tcg/{ => i386}/test-i386.c                   |    7 +-
 tests/tcg/{ => i386}/test-i386.h                   |    0
 tests/tcg/m68k/Makefile.include                    |    2 +
 tests/tcg/m68k/Makefile.target                     |    7 +
 tests/tcg/mips/Makefile.include                    |   20 +
 tests/tcg/mips/Makefile.target                     |   22 +
 tests/tcg/mips/README                              |    7 +
 tests/tcg/{ => mips}/hello-mips.c                  |    0
 tests/tcg/multiarch/Makefile.target                |   36 +
 tests/tcg/multiarch/README                         |    1 +
 tests/tcg/{ => multiarch}/linux-test.c             |  150 +-
 tests/tcg/{ => multiarch}/sha1.c                   |    0
 tests/tcg/{ => multiarch}/test-mmap.c              |   40 +-
 tests/tcg/{ => multiarch}/testthread.c             |    0
 tests/tcg/ppc/Makefile.include                     |    7 +
 tests/tcg/ppc/Makefile.target                      |   12 +
 tests/tcg/riscv/Makefile.include                   |   10 +
 tests/tcg/s390x/Makefile.include                   |    2 +
 tests/tcg/sh4/Makefile.include                     |    4 +
 tests/tcg/sh4/Makefile.target                      |    7 +
 tests/tcg/sparc64/Makefile.include                 |    2 +
 tests/tcg/sparc64/Makefile.target                  |   11 +
 tests/tcg/test_path.c                              |  157 -
 tests/tcg/x86_64/Makefile.target                   |   15 +
 77 files changed, 8136 insertions(+), 628 deletions(-)
 create mode 100644 tests/docker/dockerfiles/debian-alpha-cross.docker
 delete mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh
 create mode 100644 tests/docker/dockerfiles/debian-hppa-cross.docker
 create mode 100644 tests/docker/dockerfiles/debian-m68k-cross.docker
 create mode 100644 tests/docker/dockerfiles/debian-mips64-cross.docker
 create mode 100644 tests/docker/dockerfiles/debian-riscv64-cross.docker
 create mode 100644 tests/docker/dockerfiles/debian-sh4-cross.docker
 create mode 100644 tests/docker/dockerfiles/debian-sid.docker
 create mode 100644 tests/docker/dockerfiles/debian-sparc64-cross.docker
 create mode 100644 tests/tcg/Makefile.include
 create mode 100644 tests/tcg/Makefile.probe
 create mode 100644 tests/tcg/aarch64/Makefile.include
 create mode 100644 tests/tcg/aarch64/Makefile.target
 create mode 100644 tests/tcg/aarch64/fcvt.ref
 delete mode 100644 tests/tcg/alpha/Makefile
 create mode 100644 tests/tcg/alpha/Makefile.include
 create mode 100644 tests/tcg/alpha/Makefile.target
 delete mode 100644 tests/tcg/alpha/crt.s
 create mode 100644 tests/tcg/arm/Makefile.include
 create mode 100644 tests/tcg/arm/Makefile.target
 create mode 100644 tests/tcg/arm/README
 create mode 100644 tests/tcg/arm/fcvt.c
 create mode 100644 tests/tcg/arm/fcvt.ref
 rename tests/tcg/{ => arm}/hello-arm.c (100%)
 rename tests/tcg/{test-arm-iwmmxt.s => arm/test-arm-iwmmxt.S} (100%)
 create mode 100644 tests/tcg/hppa/Makefile.include
 create mode 100644 tests/tcg/hppa/Makefile.target
 create mode 100644 tests/tcg/i386/Makefile.include
 create mode 100644 tests/tcg/i386/Makefile.target
 create mode 100644 tests/tcg/i386/README
 rename tests/tcg/{ => i386}/hello-i386.c (96%)
 rename tests/tcg/{ => i386}/pi_10.com (100%)
 rename tests/tcg/{ => i386}/runcom.c (100%)
 rename tests/tcg/{ => i386}/test-i386-code16.S (100%)
 rename tests/tcg/{ => i386}/test-i386-fprem.c (97%)
 rename tests/tcg/{ => i386}/test-i386-muldiv.h (100%)
 rename tests/tcg/{ => i386}/test-i386-shift.h (100%)
 rename tests/tcg/{ => i386}/test-i386-ssse3.c (100%)
 rename tests/tcg/{ => i386}/test-i386-vm86.S (100%)
 rename tests/tcg/{ => i386}/test-i386.c (99%)
 rename tests/tcg/{ => i386}/test-i386.h (100%)
 create mode 100644 tests/tcg/m68k/Makefile.include
 create mode 100644 tests/tcg/m68k/Makefile.target
 create mode 100644 tests/tcg/mips/Makefile.include
 create mode 100644 tests/tcg/mips/Makefile.target
 create mode 100644 tests/tcg/mips/README
 rename tests/tcg/{ => mips}/hello-mips.c (100%)
 create mode 100644 tests/tcg/multiarch/Makefile.target
 create mode 100644 tests/tcg/multiarch/README
 rename tests/tcg/{ => multiarch}/linux-test.c (81%)
 rename tests/tcg/{ => multiarch}/sha1.c (100%)
 rename tests/tcg/{ => multiarch}/test-mmap.c (93%)
 rename tests/tcg/{ => multiarch}/testthread.c (100%)
 create mode 100644 tests/tcg/ppc/Makefile.include
 create mode 100644 tests/tcg/ppc/Makefile.target
 create mode 100644 tests/tcg/riscv/Makefile.include
 create mode 100644 tests/tcg/s390x/Makefile.include
 create mode 100644 tests/tcg/sh4/Makefile.include
 create mode 100644 tests/tcg/sh4/Makefile.target
 create mode 100644 tests/tcg/sparc64/Makefile.include
 create mode 100644 tests/tcg/sparc64/Makefile.target
 delete mode 100644 tests/tcg/test_path.c
 create mode 100644 tests/tcg/x86_64/Makefile.target

--
2.17.1

Comments

Peter Maydell June 21, 2018, noon UTC | #1
On 21 June 2018 at 07:25, Alex Bennée <alex.bennee@linaro.org> wrote:
> The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b:

>

>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100)

>

> are available in the Git repository at:

>

>   https://github.com/stsquad/qemu.git tags/pull-tcg-testing-revivial-210618-2

>

> for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:

>

>   .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)

>

> ----------------------------------------------------------------

> Add check-tcg machinary

>

> This restores the ability to run TCG smoke tests by using our docker

> infrastructure to support cross building simple tests. It represents

> the first step to making better cross-architecture testing available

> straight from the source tree ;-)

>

> v2

>   - fix quoting of target_compiler

>   - make docker.py Py3 safe

>   - tweak .travis.yml recipe

>   - don't probe docker when HAVE_USER_DOCKER not set


Weird build failure for linux/x86:

make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'
Makefile:90: rules.mak: No such file or directory
Makefile:439: tests/Makefile.include: No such file or directory
cat: VERSION: No such file or directory
Makefile:1056: tests/docker/Makefile.include: No such file or directory
Makefile:1057: tests/vm/Makefile.include: No such file or directory
make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'
make: *** No rule to make target 'tests/vm/Makefile.include'. Stop.

like it's failed to figure out the source directory.

This is my '--cc=ccache gcc' '--enable-debug' '--python=python3'
build, and it's also the one I do a 'make clean' on -- perhaps
build from clean has broken?

thanks
-- PMM
Alex Bennée June 21, 2018, 12:29 p.m. UTC | #2
Peter Maydell <peter.maydell@linaro.org> writes:

> On 21 June 2018 at 07:25, Alex Bennée <alex.bennee@linaro.org> wrote:

>> The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b:

>>

>>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100)

>>

>> are available in the Git repository at:

>>

>>   https://github.com/stsquad/qemu.git tags/pull-tcg-testing-revivial-210618-2

>>

>> for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:

>>

>>   .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)

>>

>> ----------------------------------------------------------------

>> Add check-tcg machinary

>>

>> This restores the ability to run TCG smoke tests by using our docker

>> infrastructure to support cross building simple tests. It represents

>> the first step to making better cross-architecture testing available

>> straight from the source tree ;-)

>>

>> v2

>>   - fix quoting of target_compiler

>>   - make docker.py Py3 safe

>>   - tweak .travis.yml recipe

>>   - don't probe docker when HAVE_USER_DOCKER not set

>

> Weird build failure for linux/x86:

>

> make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

> Makefile:90: rules.mak: No such file or directory

> Makefile:439: tests/Makefile.include: No such file or directory

> cat: VERSION: No such file or directory

> Makefile:1056: tests/docker/Makefile.include: No such file or directory

> Makefile:1057: tests/vm/Makefile.include: No such file or directory

> make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

> make: *** No rule to make target 'tests/vm/Makefile.include'. Stop.

>

> like it's failed to figure out the source directory.

>

> This is my '--cc=ccache gcc' '--enable-debug' '--python=python3'

> build, and it's also the one I do a 'make clean' on -- perhaps

> build from clean has broken?


And you called a plain make to build it?

Let me see if I can reproduce.

>

> thanks

> -- PMM



--
Alex Bennée
Alex Bennée June 21, 2018, 2:48 p.m. UTC | #3
Peter Maydell <peter.maydell@linaro.org> writes:

> On 21 June 2018 at 07:25, Alex Bennée <alex.bennee@linaro.org> wrote:

>> The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b:

>>

>>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100)

>>

>> are available in the Git repository at:

>>

>>   https://github.com/stsquad/qemu.git tags/pull-tcg-testing-revivial-210618-2

>>

>> for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:

>>

>>   .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)

>>

>> ----------------------------------------------------------------

>> Add check-tcg machinary

>>

>> This restores the ability to run TCG smoke tests by using our docker

>> infrastructure to support cross building simple tests. It represents

>> the first step to making better cross-architecture testing available

>> straight from the source tree ;-)

>>

>> v2

>>   - fix quoting of target_compiler

>>   - make docker.py Py3 safe

>>   - tweak .travis.yml recipe

>>   - don't probe docker when HAVE_USER_DOCKER not set

>

> Weird build failure for linux/x86:

>

> make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

> Makefile:90: rules.mak: No such file or directory

> Makefile:439: tests/Makefile.include: No such file or directory

> cat: VERSION: No such file or directory

> Makefile:1056: tests/docker/Makefile.include: No such file or directory

> Makefile:1057: tests/vm/Makefile.include: No such file or directory

> make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

> make: *** No rule to make target 'tests/vm/Makefile.include'. Stop.

>

> like it's failed to figure out the source directory.

>

> This is my '--cc=ccache gcc' '--enable-debug' '--python=python3'

> build, and it's also the one I do a 'make clean' on -- perhaps

> build from clean has broken?


Hmm I can't reproduce this. I've built a fresh 16.04 server image with
and with:

  # Configured with: './configure' '--cc=ccache gcc' '--enable-debug' '--python=python3'

both:
  make

and:
  make check-tcg

Work for me :-/

>

> thanks

> -- PMM



--
Alex Bennée
Philippe Mathieu-Daudé June 21, 2018, 3:01 p.m. UTC | #4
Hi Alex,

On 06/21/2018 11:48 AM, Alex Bennée wrote:
> 

> Peter Maydell <peter.maydell@linaro.org> writes:

> 

>> On 21 June 2018 at 07:25, Alex Bennée <alex.bennee@linaro.org> wrote:

>>> The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b:

>>>

>>>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100)

>>>

>>> are available in the Git repository at:

>>>

>>>   https://github.com/stsquad/qemu.git tags/pull-tcg-testing-revivial-210618-2

>>>

>>> for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:

>>>

>>>   .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)

>>>

>>> ----------------------------------------------------------------

>>> Add check-tcg machinary

>>>

>>> This restores the ability to run TCG smoke tests by using our docker

>>> infrastructure to support cross building simple tests. It represents

>>> the first step to making better cross-architecture testing available

>>> straight from the source tree ;-)

>>>

>>> v2

>>>   - fix quoting of target_compiler

>>>   - make docker.py Py3 safe

>>>   - tweak .travis.yml recipe

>>>   - don't probe docker when HAVE_USER_DOCKER not set

>>

>> Weird build failure for linux/x86:

>>

>> make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

>> Makefile:90: rules.mak: No such file or directory

>> Makefile:439: tests/Makefile.include: No such file or directory

>> cat: VERSION: No such file or directory

>> Makefile:1056: tests/docker/Makefile.include: No such file or directory

>> Makefile:1057: tests/vm/Makefile.include: No such file or directory

>> make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

>> make: *** No rule to make target 'tests/vm/Makefile.include'. Stop.

>>

>> like it's failed to figure out the source directory.

>>

>> This is my '--cc=ccache gcc' '--enable-debug' '--python=python3'

>> build, and it's also the one I do a 'make clean' on -- perhaps

>> build from clean has broken?

> 

> Hmm I can't reproduce this. I've built a fresh 16.04 server image with

> and with:

> 

>   # Configured with: './configure' '--cc=ccache gcc' '--enable-debug' '--python=python3'

> 

> both:

>   make

> 

> and:

>   make check-tcg

> 

> Work for me :-/


Did you try rebuilding after a 'make clean'?
Alex Bennée June 21, 2018, 3:12 p.m. UTC | #5
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Hi Alex,

>

> On 06/21/2018 11:48 AM, Alex Bennée wrote:

>>

>> Peter Maydell <peter.maydell@linaro.org> writes:

>>

>>> On 21 June 2018 at 07:25, Alex Bennée <alex.bennee@linaro.org> wrote:

>>>> The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b:

>>>>

>>>>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100)

>>>>

>>>> are available in the Git repository at:

>>>>

>>>>   https://github.com/stsquad/qemu.git tags/pull-tcg-testing-revivial-210618-2

>>>>

>>>> for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:

>>>>

>>>>   .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)

>>>>

>>>> ----------------------------------------------------------------

>>>> Add check-tcg machinary

>>>>

>>>> This restores the ability to run TCG smoke tests by using our docker

>>>> infrastructure to support cross building simple tests. It represents

>>>> the first step to making better cross-architecture testing available

>>>> straight from the source tree ;-)

>>>>

>>>> v2

>>>>   - fix quoting of target_compiler

>>>>   - make docker.py Py3 safe

>>>>   - tweak .travis.yml recipe

>>>>   - don't probe docker when HAVE_USER_DOCKER not set

>>>

>>> Weird build failure for linux/x86:

>>>

>>> make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

>>> Makefile:90: rules.mak: No such file or directory

>>> Makefile:439: tests/Makefile.include: No such file or directory

>>> cat: VERSION: No such file or directory

>>> Makefile:1056: tests/docker/Makefile.include: No such file or directory

>>> Makefile:1057: tests/vm/Makefile.include: No such file or directory

>>> make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

>>> make: *** No rule to make target 'tests/vm/Makefile.include'. Stop.

>>>

>>> like it's failed to figure out the source directory.

>>>

>>> This is my '--cc=ccache gcc' '--enable-debug' '--python=python3'

>>> build, and it's also the one I do a 'make clean' on -- perhaps

>>> build from clean has broken?

>>

>> Hmm I can't reproduce this. I've built a fresh 16.04 server image with

>> and with:

>>

>>   # Configured with: './configure' '--cc=ccache gcc' '--enable-debug' '--python=python3'

>>

>> both:

>>   make

>>

>> and:

>>   make check-tcg

>>

>> Work for me :-/

>

> Did you try rebuilding after a 'make clean'?


Yep, both make clean, configure, make and make clean, make


--
Alex Bennée
Philippe Mathieu-Daudé June 21, 2018, 4:04 p.m. UTC | #6
On 06/21/2018 12:12 PM, Alex Bennée wrote:
> 

> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> 

>> Hi Alex,

>>

>> On 06/21/2018 11:48 AM, Alex Bennée wrote:

>>>

>>> Peter Maydell <peter.maydell@linaro.org> writes:

>>>

>>>> On 21 June 2018 at 07:25, Alex Bennée <alex.bennee@linaro.org> wrote:

>>>>> The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b:

>>>>>

>>>>>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100)

>>>>>

>>>>> are available in the Git repository at:

>>>>>

>>>>>   https://github.com/stsquad/qemu.git tags/pull-tcg-testing-revivial-210618-2

>>>>>

>>>>> for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:

>>>>>

>>>>>   .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)

>>>>>

>>>>> ----------------------------------------------------------------

>>>>> Add check-tcg machinary

>>>>>

>>>>> This restores the ability to run TCG smoke tests by using our docker

>>>>> infrastructure to support cross building simple tests. It represents

>>>>> the first step to making better cross-architecture testing available

>>>>> straight from the source tree ;-)

>>>>>

>>>>> v2

>>>>>   - fix quoting of target_compiler

>>>>>   - make docker.py Py3 safe

>>>>>   - tweak .travis.yml recipe

>>>>>   - don't probe docker when HAVE_USER_DOCKER not set

>>>>

>>>> Weird build failure for linux/x86:

>>>>

>>>> make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'


This looks like an out-of-tree build.
I suppose SRC_PATH=.../qemu-for-merges/

>>>> Makefile:90: rules.mak: No such file or directory

>>>> Makefile:439: tests/Makefile.include: No such file or directory

>>>> cat: VERSION: No such file or directory

>>>> Makefile:1056: tests/docker/Makefile.include: No such file or directory

>>>> Makefile:1057: tests/vm/Makefile.include: No such file or directory

>>>> make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

>>>> make: *** No rule to make target 'tests/vm/Makefile.include'. Stop.

>>>>

>>>> like it's failed to figure out the source directory.

>>>>

>>>> This is my '--cc=ccache gcc' '--enable-debug' '--python=python3'

>>>> build, and it's also the one I do a 'make clean' on -- perhaps

>>>> build from clean has broken?

>>>

>>> Hmm I can't reproduce this. I've built a fresh 16.04 server image with

>>> and with:

>>>

>>>   # Configured with: './configure' '--cc=ccache gcc' '--enable-debug' '--python=python3'

>>>

>>> both:

>>>   make

>>>

>>> and:

>>>   make check-tcg

>>>

>>> Work for me :-/

>>

>> Did you try rebuilding after a 'make clean'?

> 

> Yep, both make clean, configure, make and make clean, make


I can not reproduce neither using out-of-tree build with
../../configure '--cc=ccache gcc' '--enable-debug' '--python=python3'

I'll now test:

$ git checkout master
$ make clean
$ git checkout pull-tcg-testing-revivial-210618-2
$ make check-tcg
Philippe Mathieu-Daudé June 21, 2018, 4:12 p.m. UTC | #7
On 06/21/2018 01:04 PM, Philippe Mathieu-Daudé wrote:
> On 06/21/2018 12:12 PM, Alex Bennée wrote:

>>

>> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

>>

>>> Hi Alex,

>>>

>>> On 06/21/2018 11:48 AM, Alex Bennée wrote:

>>>>

>>>> Peter Maydell <peter.maydell@linaro.org> writes:

>>>>

>>>>> On 21 June 2018 at 07:25, Alex Bennée <alex.bennee@linaro.org> wrote:

>>>>>> The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b:

>>>>>>

>>>>>>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100)

>>>>>>

>>>>>> are available in the Git repository at:

>>>>>>

>>>>>>   https://github.com/stsquad/qemu.git tags/pull-tcg-testing-revivial-210618-2

>>>>>>

>>>>>> for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:

>>>>>>

>>>>>>   .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)

>>>>>>

>>>>>> ----------------------------------------------------------------

>>>>>> Add check-tcg machinary

>>>>>>

>>>>>> This restores the ability to run TCG smoke tests by using our docker

>>>>>> infrastructure to support cross building simple tests. It represents

>>>>>> the first step to making better cross-architecture testing available

>>>>>> straight from the source tree ;-)

>>>>>>

>>>>>> v2

>>>>>>   - fix quoting of target_compiler

>>>>>>   - make docker.py Py3 safe

>>>>>>   - tweak .travis.yml recipe

>>>>>>   - don't probe docker when HAVE_USER_DOCKER not set

>>>>>

>>>>> Weird build failure for linux/x86:

>>>>>

>>>>> make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

> 

> This looks like an out-of-tree build.

> I suppose SRC_PATH=.../qemu-for-merges/

> 

>>>>> Makefile:90: rules.mak: No such file or directory

>>>>> Makefile:439: tests/Makefile.include: No such file or directory

>>>>> cat: VERSION: No such file or directory

>>>>> Makefile:1056: tests/docker/Makefile.include: No such file or directory

>>>>> Makefile:1057: tests/vm/Makefile.include: No such file or directory

>>>>> make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg'

>>>>> make: *** No rule to make target 'tests/vm/Makefile.include'. Stop.

>>>>>

>>>>> like it's failed to figure out the source directory.

>>>>>

>>>>> This is my '--cc=ccache gcc' '--enable-debug' '--python=python3'

>>>>> build, and it's also the one I do a 'make clean' on -- perhaps

>>>>> build from clean has broken?

>>>>

>>>> Hmm I can't reproduce this. I've built a fresh 16.04 server image with

>>>> and with:

>>>>

>>>>   # Configured with: './configure' '--cc=ccache gcc' '--enable-debug' '--python=python3'

>>>>

>>>> both:

>>>>   make

>>>>

>>>> and:

>>>>   make check-tcg

>>>>

>>>> Work for me :-/

>>>

>>> Did you try rebuilding after a 'make clean'?

>>

>> Yep, both make clean, configure, make and make clean, make

> 

> I can not reproduce neither using out-of-tree build with

> ../../configure '--cc=ccache gcc' '--enable-debug' '--python=python3'

> 

> I'll now test:

> 

> $ git checkout master


$ make

> $ make clean

> $ git checkout pull-tcg-testing-revivial-210618-2

> $ make check-tcg


This worked ('clean' in previous branch).

I also tested 'clean' in new branch:

$ git checkout master
$ make
$ git checkout pull-tcg-testing-revivial-210618-2
$ make clean
$ make check-tcg

Eventually the previous branch was not 'master' but the last pull
request Peter tested, and the problem would be there or between this
branch and yours.
Peter Maydell June 22, 2018, 11:40 a.m. UTC | #8
On 21 June 2018 at 07:25, Alex Bennée <alex.bennee@linaro.org> wrote:
> The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b:

>

>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into staging (2018-06-20 09:51:30 +0100)

>

> are available in the Git repository at:

>

>   https://github.com/stsquad/qemu.git tags/pull-tcg-testing-revivial-210618-2

>

> for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:

>

>   .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)

>

> ----------------------------------------------------------------

> Add check-tcg machinary

>

> This restores the ability to run TCG smoke tests by using our docker

> infrastructure to support cross building simple tests. It represents

> the first step to making better cross-architecture testing available

> straight from the source tree ;-)

>

> v2

>   - fix quoting of target_compiler

>   - make docker.py Py3 safe

>   - tweak .travis.yml recipe

>   - don't probe docker when HAVE_USER_DOCKER not set

>

Applied, thanks.

-- PMM