| Message ID | 20181122172653.3413-1-peter.maydell@linaro.org |
|---|---|
| Headers | show |
| Series | Avoid cpu_physical_memory_read() in generic code | expand |
On Thu, 22 Nov 2018 at 17:28, Peter Maydell <peter.maydell@linaro.org> wrote: > > This patchset takes three places in generic code which > use cpu_physical_memory_read(), and changes them to use > address_space_read() instead. > > Changes v1->v2: > * patches 1, 2 unchanged (and reviewed) > * patch 3: handle as being NULL (which for the > load_elf APIs means "use address_space_memory") I'm adding this to a 'misc' pullreq I'm putting together. thanks -- PMM
This patchset takes three places in generic code which use cpu_physical_memory_read(), and changes them to use address_space_read() instead. Changes v1->v2: * patches 1, 2 unchanged (and reviewed) * patch 3: handle as being NULL (which for the load_elf APIs means "use address_space_memory") cpu_physical_memory_{read,rw,write} all implicitly assume that there is exactly one view of physical memory. This is sort-of true today, but we'd like to be able to move to having heterogenous systems where not all CPUs share the same view of physical memory. In disas.c we are disassembling for a particular CPU, so use that CPU's primary address space (cs->as). In monitor.c we are reading physical memory for a particular CPU, so again use that CPU's primary address space; we fall back to address_space_memory for the case where there are no CPUs in the system (-machine none). In elf_ops.h the function was passed an address space to use, so just use it. Other places in generic code that use these functions are: * dump.c -- the whole UI here seems to assume that there is only one view of memory and that is what is being dumped * cpu.c:qmp_pmemsave() -- again, the UI assumption is that there's only one view of memory So I've left those alone. NB: git grep command line for finding callsites: git grep '\<cpu_physical_memory_\(read\|write\|rw\)\>' thanks -- PMM Peter Maydell (3): disas.c: Use address_space_read() to read memory monitor: Use address_space_read() to read memory elf_ops.h: Use address_space_write() to write memory include/hw/elf_ops.h | 4 +++- disas.c | 5 ++++- monitor.c | 8 +++++++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.19.1