| Message ID | 20190128155907.20607-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | tcg queued patches | expand |
On Mon, 28 Jan 2019 at 15:59, Richard Henderson <richard.henderson@linaro.org> wrote: > > The following changes since commit ad7a21e81231ae64540310384fb0f87ac8758b02: > > Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2019-01-25 17:22:20 +0000) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-tcg-20190128 > > for you to fetch changes up to e77c89fb086a9bf09dd11f72e4cb2093b426f32b: > > cputlb: Remove static tlb sizing (2019-01-28 07:04:35 -0800) > > ---------------------------------------------------------------- > Backend vector enhancements > Dynamic tlb resizing > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 for any user-visible changes. -- PMM
Patchew URL: https://patchew.org/QEMU/20190128155907.20607-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 00/23] tcg queued patches
Type: series
Message-id: 20190128155907.20607-1-richard.henderson@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
eb3e52d87a cputlb: Remove static tlb sizing
cfc2618c99 tcg/tci: enable dynamic TLB sizing
b8fc0f0949 tcg/mips: enable dynamic TLB sizing
3bae2f23af tcg/mips: Fix tcg_out_qemu_ld_slow_path
714bfbb9ec tcg/arm: enable dynamic TLB sizing
57cb76909c tcg/riscv: enable dynamic TLB sizing
284b2713c4 tcg/s390: enable dynamic TLB sizing
c64943902f tcg/sparc: enable dynamic TLB sizing
9492a910a4 tcg/ppc: enable dynamic TLB sizing
bdd9b5fdb1 tcg/aarch64: enable dynamic TLB sizing
4639cb1b1e tcg/i386: enable dynamic TLB sizing
fae8aeed87 tcg: introduce dynamic TLB sizing
8fdedd99b0 cputlb: do not evict empty entries to the vtlb
3ebbc16e11 tcg/aarch64: Implement vector minmax arithmetic
507359b189 tcg/aarch64: Implement vector saturating arithmetic
26ef0e34d9 tcg/i386: Implement vector minmax arithmetic
bba221d81a tcg/i386: Implement vector saturating arithmetic
267dc80ed6 tcg/i386: Split subroutines out of tcg_expand_vec_op
553442fe31 tcg: Add opcodes for vector minmax arithmetic
cc8672f846 tcg: Add opcodes for vector saturated arithmetic
046132cf4a tcg: Add write_aofs to GVecGen4
873cfa5453 tcg: Add gvec expanders for nand, nor, eqv
b71dadbf87 tcg: Add logical simplifications during gvec expand
=== OUTPUT BEGIN ===
1/23 Checking commit b71dadbf87bb (tcg: Add logical simplifications during gvec expand)
2/23 Checking commit 873cfa545317 (tcg: Add gvec expanders for nand, nor, eqv)
3/23 Checking commit 046132cf4aad (tcg: Add write_aofs to GVecGen4)
4/23 Checking commit cc8672f84649 (tcg: Add opcodes for vector saturated arithmetic)
5/23 Checking commit 553442fe3197 (tcg: Add opcodes for vector minmax arithmetic)
6/23 Checking commit 267dc80ed6fe (tcg/i386: Split subroutines out of tcg_expand_vec_op)
WARNING: Block comments use a leading /* on a separate line
#30: FILE: tcg/i386/tcg-target.inc.c:3092:
+ /* Unpack to W, shift, and repack. Tricky bits:
WARNING: Block comments use * on subsequent lines
#31: FILE: tcg/i386/tcg-target.inc.c:3093:
+ /* Unpack to W, shift, and repack. Tricky bits:
+ (1) Use punpck*bw x,x to produce DDCCBBAA,
WARNING: Block comments use a trailing */ on a separate line
#38: FILE: tcg/i386/tcg-target.inc.c:3100:
+ the quantity. */
WARNING: Block comments use a leading /* on a separate line
#84: FILE: tcg/i386/tcg-target.inc.c:3146:
+ /* We can emulate a small sign extend by performing an arithmetic
WARNING: Block comments use a leading /* on a separate line
#96: FILE: tcg/i386/tcg-target.inc.c:3158:
+ /* Otherwise we will need to use a compare vs 0 to produce
total: 0 errors, 5 warnings, 485 lines checked
Patch 6/23 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/23 Checking commit bba221d81a7b (tcg/i386: Implement vector saturating arithmetic)
8/23 Checking commit 26ef0e34d980 (tcg/i386: Implement vector minmax arithmetic)
9/23 Checking commit 507359b1893a (tcg/aarch64: Implement vector saturating arithmetic)
10/23 Checking commit 3ebbc16e110d (tcg/aarch64: Implement vector minmax arithmetic)
11/23 Checking commit 8fdedd99b0fc (cputlb: do not evict empty entries to the vtlb)
WARNING: Block comments use a leading /* on a separate line
#31: FILE: accel/tcg/cputlb.c:227:
+/**
total: 0 errors, 1 warnings, 23 lines checked
Patch 11/23 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/23 Checking commit fae8aeed87d9 (tcg: introduce dynamic TLB sizing)
WARNING: Block comments use a leading /* on a separate line
#53: FILE: accel/tcg/cputlb.c:106:
+/**
WARNING: Block comments use a leading /* on a separate line
#336: FILE: include/exec/cpu-defs.h:167:
+/**
WARNING: Block comments use a leading /* on a separate line
#368: FILE: include/exec/cpu-defs.h:220:
+ /* tlb_mask[i] contains (n_entries - 1) << CPU_TLB_ENTRY_BITS */ \
total: 0 errors, 3 warnings, 452 lines checked
Patch 12/23 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/23 Checking commit 4639cb1b1e09 (tcg/i386: enable dynamic TLB sizing)
14/23 Checking commit bdd9b5fdb1ea (tcg/aarch64: enable dynamic TLB sizing)
15/23 Checking commit 9492a910a446 (tcg/ppc: enable dynamic TLB sizing)
ERROR: space prohibited after that open parenthesis '('
#31: FILE: tcg/ppc/tcg-target.inc.c:330:
+#define LWZUX XO31( 55)
ERROR: space prohibited after that open parenthesis '('
#39: FILE: tcg/ppc/tcg-target.inc.c:342:
+#define LDUX XO31( 53)
total: 2 errors, 0 warnings, 144 lines checked
Patch 15/23 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/23 Checking commit c64943902fab (tcg/sparc: enable dynamic TLB sizing)
17/23 Checking commit 284b2713c4c1 (tcg/s390: enable dynamic TLB sizing)
18/23 Checking commit 57cb76909c9e (tcg/riscv: enable dynamic TLB sizing)
19/23 Checking commit 714bfbb9ec43 (tcg/arm: enable dynamic TLB sizing)
ERROR: code indent should never use tabs
#174: FILE: tcg/arm/tcg-target.inc.c:1297:
+^Iif (use_armv6_instructions && TARGET_LONG_BITS == 64) {$
ERROR: code indent should never use tabs
#181: FILE: tcg/arm/tcg-target.inc.c:1304:
+^I^I TCG_REG_R2, TCG_REG_R2, TCG_REG_TMP, 0);$
ERROR: code indent should never use tabs
#186: FILE: tcg/arm/tcg-target.inc.c:1309:
+^I}$
total: 3 errors, 0 warnings, 177 lines checked
Patch 19/23 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/23 Checking commit 3bae2f23afda (tcg/mips: Fix tcg_out_qemu_ld_slow_path)
21/23 Checking commit b8fc0f0949d5 (tcg/mips: enable dynamic TLB sizing)
22/23 Checking commit cfc2618c99ff (tcg/tci: enable dynamic TLB sizing)
23/23 Checking commit eb3e52d87ace (cputlb: Remove static tlb sizing)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190128155907.20607-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
The following changes since commit ad7a21e81231ae64540310384fb0f87ac8758b02: Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2019-01-25 17:22:20 +0000) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg-20190128 for you to fetch changes up to e77c89fb086a9bf09dd11f72e4cb2093b426f32b: cputlb: Remove static tlb sizing (2019-01-28 07:04:35 -0800) ---------------------------------------------------------------- Backend vector enhancements Dynamic tlb resizing ---------------------------------------------------------------- Emilio G. Cota (3): cputlb: do not evict empty entries to the vtlb tcg: introduce dynamic TLB sizing tcg/i386: enable dynamic TLB sizing Richard Henderson (20): tcg: Add logical simplifications during gvec expand tcg: Add gvec expanders for nand, nor, eqv tcg: Add write_aofs to GVecGen4 tcg: Add opcodes for vector saturated arithmetic tcg: Add opcodes for vector minmax arithmetic tcg/i386: Split subroutines out of tcg_expand_vec_op tcg/i386: Implement vector saturating arithmetic tcg/i386: Implement vector minmax arithmetic tcg/aarch64: Implement vector saturating arithmetic tcg/aarch64: Implement vector minmax arithmetic tcg/aarch64: enable dynamic TLB sizing tcg/ppc: enable dynamic TLB sizing tcg/sparc: enable dynamic TLB sizing tcg/s390: enable dynamic TLB sizing tcg/riscv: enable dynamic TLB sizing tcg/arm: enable dynamic TLB sizing tcg/mips: Fix tcg_out_qemu_ld_slow_path tcg/mips: enable dynamic TLB sizing tcg/tci: enable dynamic TLB sizing cputlb: Remove static tlb sizing accel/tcg/tcg-runtime.h | 23 ++ include/exec/cpu-defs.h | 71 ++--- include/exec/cpu_ldst.h | 9 +- tcg/aarch64/tcg-target.h | 2 + tcg/i386/tcg-target.h | 2 + tcg/tcg-op-gvec.h | 18 ++ tcg/tcg-op.h | 11 + tcg/tcg-opc.h | 8 + tcg/tcg.h | 2 + accel/tcg/cputlb.c | 192 +++++++++++++- accel/tcg/tcg-runtime-gvec.c | 257 ++++++++++++++++++ tcg/aarch64/tcg-target.inc.c | 148 ++++++++--- tcg/arm/tcg-target.inc.c | 143 +++++----- tcg/i386/tcg-target.inc.c | 608 ++++++++++++++++++++++++++----------------- tcg/mips/tcg-target.inc.c | 97 ++++--- tcg/ppc/tcg-target.inc.c | 91 ++++--- tcg/riscv/tcg-target.inc.c | 126 ++++----- tcg/s390/tcg-target.inc.c | 45 ++-- tcg/sparc/tcg-target.inc.c | 82 +++--- tcg/tcg-op-gvec.c | 305 +++++++++++++++++++--- tcg/tcg-op-vec.c | 75 +++++- tcg/tcg.c | 10 + tcg/README | 19 ++ 23 files changed, 1714 insertions(+), 630 deletions(-)