mbox series

[for-4.1,0/6] target/s390x: Clean up tcg exceptions

Message ID 20190401102911.8685-1-richard.henderson@linaro.org
Headers show
Series target/s390x: Clean up tcg exceptions | expand

Message

Richard Henderson April 1, 2019, 10:29 a.m. UTC 
I've been cleaning up some random branches and found this,
dating from mid-2017(!)  My memory is that I wrote this going
into some softfreeze and then failed to do anything with it
once development opened again.  Oops.

The major change is to handle ILEN via TCG unwinding, so that
we don't have to Just Know about the ILEN (the majority of the
calls to s390_program_interrupt use constants), or re-read from
memory (which gets EX wrong).


r~


Richard Henderson (6):
  target/s390x: Truncate 32-bit psw_addr before creating TB
  target/s390x: Add ilen to unwind data
  target/s390x: Use ilen from unwind in tlb_fill
  target/s390x: Remove ilen parameter from tcg_s390_program_interrupt
  target/s390x: Remove ilen parameter from s390_program_interrupt
  target/s390x: Use tcg_s390_program_interrupt in TCG helpers

 target/s390x/cpu.h           | 33 +++++++++++++-------
 target/s390x/internal.h      |  2 +-
 target/s390x/tcg_s390x.h     |  4 +--
 hw/s390x/s390-pci-inst.c     | 58 ++++++++++++++++++------------------
 target/s390x/cc_helper.c     |  4 +--
 target/s390x/crypto_helper.c |  7 ++---
 target/s390x/diag.c          | 14 ++++-----
 target/s390x/excp_helper.c   | 10 +++----
 target/s390x/fpu_helper.c    |  6 ++--
 target/s390x/int_helper.c    | 15 +++++-----
 target/s390x/interrupt.c     | 12 ++++----
 target/s390x/ioinst.c        | 40 ++++++++++++-------------
 target/s390x/mem_helper.c    | 53 +++++++++++++++++++-------------
 target/s390x/misc_helper.c   | 27 ++++++-----------
 target/s390x/tcg-stub.c      |  4 +--
 target/s390x/translate.c     | 16 +++++-----
 16 files changed, 163 insertions(+), 142 deletions(-)

-- 
2.17.1

Comments

no-reply@patchew.org April 1, 2019, 10:39 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20190401102911.8685-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190401102911.8685-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH for-4.1 0/6] target/s390x: Clean up tcg exceptions
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190401102911.8685-1-richard.henderson@linaro.org -> patchew/20190401102911.8685-1-richard.henderson@linaro.org
Switched to a new branch 'test'
a4dfce71cc target/s390x: Use tcg_s390_program_interrupt in TCG helpers
87bd6aebb7 target/s390x: Remove ilen parameter from s390_program_interrupt
fd0ef480b7 target/s390x: Remove ilen parameter from tcg_s390_program_interrupt
43e67872c4 target/s390x: Use ilen from unwind in tlb_fill
14ec29685a target/s390x: Add ilen to unwind data
7b3891767e target/s390x: Truncate 32-bit psw_addr before creating TB

=== OUTPUT BEGIN ===
1/6 Checking commit 7b3891767e0f (target/s390x: Truncate 32-bit psw_addr before creating TB)
ERROR: "foo* bar" should be "foo *bar"
#23: FILE: target/s390x/cpu.h:371:
+static inline void cpu_get_tb_cpu_state(CPUS390XState* env,

total: 1 errors, 0 warnings, 49 lines checked

Patch 1/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/6 Checking commit 14ec29685aab (target/s390x: Add ilen to unwind data)
3/6 Checking commit 43e67872c45e (target/s390x: Use ilen from unwind in tlb_fill)
4/6 Checking commit fd0ef480b730 (target/s390x: Remove ilen parameter from tcg_s390_program_interrupt)
5/6 Checking commit 87bd6aebb7ce (target/s390x: Remove ilen parameter from s390_program_interrupt)
6/6 Checking commit a4dfce71cc2e (target/s390x: Use tcg_s390_program_interrupt in TCG helpers)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190401102911.8685-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com