From patchwork Mon Feb 17 02:59:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 183570 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp4453481ile; Sun, 16 Feb 2020 19:01:44 -0800 (PST) X-Google-Smtp-Source: APXvYqx4Ywje6JQrp319TbZDGhx3bgBob7X6ROLMQ8Xc6SkmwklGmoKIvnZHpkGO+zlPEtcQFtLd X-Received: by 2002:ac8:1835:: with SMTP id q50mr11116118qtj.210.1581908504204; Sun, 16 Feb 2020 19:01:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581908504; cv=none; d=google.com; s=arc-20160816; b=hs46kF2TIm1YGbcM0J+qNGSlaWWYUpJpj8Suljjud0wh7ipohnYuEup3uxY2DJK7s8 DyaN1W1NmewCD1YTWIAJTLXAm/WbfJ/KU5qhNU7loDYKA28x+Y7K/p1qdjavoJI3mifG G3yQB7SZEZEnkwsF92SuhRrLWP2j/5qPF6klMYI2EmrFwEDyN+7j6UEM+S2E4ftnMw/X kA2vHg1Mkj7FpV2ti8JVJJvwOSZHxDkqv9NHhnZWh3G3Lo5HfQhRyMwkAN0W8szJeJkj RATqZw1/GmX4po4hT0TXLkoJJH8umo9yylEojG9MLauSsq3EhSarD6UYkWOS02JrBbzy /7Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=lfZ/gSeSSwO+iUrhXjDeYzuRwSvkE5pc/x6+ENqbncI=; b=C88xDBMK04XPCwv7EMVFe6XaEhAPT5I/cpXxKiv4g6h7YHxWovNd4UlTT4dAnP9FmP 3jOfMOqYRVnlgmixXWeBpSGKtOmdR7WcAFPWZpHXf4yx7VFol0ErHbivPA/MZU9GEK+7 nIFDL87tQ/QYtgkHZMvZqP+3Y/daQxzaZfAdDh8lx6C+8fIgbPcVMphiqIn8su6txh8X goHlFGPdTrfAwAz1zFtSn3PUasdmJHBbl+t5hDI/jehLKEVl4UACMm8SJPxQzKjXV1e+ +17Imz1Pt5GOYfk84f0i6q5/UCgqaM3oR3N17AtnXgMupJnKWnfHt53JckUuTlYNK3HP rlIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KHkAvS4Y; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 21si6580811qkf.293.2020.02.16.19.01.44 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Feb 2020 19:01:44 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KHkAvS4Y; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3WfH-0005pu-Mp for patch@linaro.org; Sun, 16 Feb 2020 22:01:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44784) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3Wdf-00035Q-2n for qemu-devel@nongnu.org; Sun, 16 Feb 2020 22:00:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3Wdd-0003Mc-DO for qemu-devel@nongnu.org; Sun, 16 Feb 2020 22:00:02 -0500 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:40388) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3Wdd-0003LQ-5a for qemu-devel@nongnu.org; Sun, 16 Feb 2020 22:00:01 -0500 Received: by mail-pl1-x636.google.com with SMTP id y1so6115870plp.7 for ; Sun, 16 Feb 2020 19:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=lfZ/gSeSSwO+iUrhXjDeYzuRwSvkE5pc/x6+ENqbncI=; b=KHkAvS4YHLTytdeAX1l5JU/D4BGW2/n6DS3hRxGn+0SD51n7FogMTQhL4tRdLbVPcv FCEeoBLTYNT7anmh2oEzN2+pJiSRT80ziWr+YvqyjedUJkM6F9APVa0bks7TbBSy9rQU 2CvQPdfbUr1c9/LB1algsUyAwwFLG9MyQzk8EMdgYgUzgaznNcJjBvmGIl3uWzb55GgV +BYuwG190rLOF6trzUuhKTrqViInxG/K0lBR3X4XgNt/bwTFBcUzedUYMHPMo8abGLEa adpZQ3Hl+T+RXeFKN5QQm6IXmW3ci6PEKzZltG36NxNvt+TcBEcqNk1WlKPeHQ/SdUY4 pNqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=lfZ/gSeSSwO+iUrhXjDeYzuRwSvkE5pc/x6+ENqbncI=; b=ILat4dW4+yN+sTjUm+Gm/uQ0YLWcPpUCQye9Fc6uzUcm4T5ze7CGJQcjFzydTYekUA EaQL2n1l/0okhWKp+dAOueBmZ63tlkzLdQIPcYfVW67EKVAKug1jhqKrEKRKJtPYOVaM jJ9MowkxxWQNPbRT+ZQritgIDKoTaTofaZQPGTNe5zK8CHYoQA4KIFrOqoqYSXmpjP95 ko2ZSHAQwfTSTo02ZTyD4n9kH9TjOPCz0vIhwxi5h3XU+JPOyz8nhKJDz+lHlmvFZrvq RhFMzv5E1aJMk4mJos46/+rxaZAiHtLMmOw5OovVnoJV80bsfkbvqO5kM2Jm1gdWhGRN KKLw== X-Gm-Message-State: APjAAAUe0BdO8nnHFp4H34XSrQCJfRfh37Oih73LFZUun2W+1SkruOUs TYKO6rH6TjGP+AuD3llKRHiK+UARfDk= X-Received: by 2002:a17:90b:97:: with SMTP id bb23mr16545483pjb.53.1581908399037; Sun, 16 Feb 2020 18:59:59 -0800 (PST) Received: from localhost.localdomain (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id u2sm14741060pgj.7.2020.02.16.18.59.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2020 18:59:58 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 0/4] tcg: Fix for Bug 1863508 Date: Sun, 16 Feb 2020 18:59:53 -0800 Message-Id: <20200217025957.12031-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::636 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The comment in tcg-runtime-gvec.c about CONFIG_VECTOR16 says that tcg-op-gvec.c has eliminated size 8 vectors, and only passes on multiples of 16. This may have been true of the first few operations, but is not true of all operations. In particular, multiply, shift by scalar, and compare of 8- and 16-bit elements are not expanded inline if host vector operations are not supported. For an x86_64 host that does not support AVX, this means that we will fall back to the helper, which will attempt to use SSE instructions, which will SEGV on an invalid 8-byte aligned memory operation. The first patch removes the CONFIG_VECTOR16 code and configuration; the subsequent patches tidy up tcg-runtime-gvec.c. r~ Richard Henderson (4): tcg: Remove CONFIG_VECTOR16 tcg: Tidy tcg-runtime-gvec.c types tcg: Tidy tcg-runtime-gvec.c DUP* tcg: Remove tcg-runtime-gvec.c DO_CMP0 configure | 56 ------- accel/tcg/tcg-runtime-gvec.c | 298 ++++++++++++++--------------------- 2 files changed, 116 insertions(+), 238 deletions(-) -- 2.20.1