Message ID | 20200306110959.29461-1-peter.maydell@linaro.org |
---|---|
Headers | show |
Series | docs queue | expand |
Patchew URL: https://patchew.org/QEMU/20200306110959.29461-1-peter.maydell@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/33] docs queue Message-id: 20200306110959.29461-1-peter.maydell@linaro.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu ef9f8fc..6b02fca master -> master - [tag update] patchew/20200304133538.9159-1-dplotnikov@virtuozzo.com -> patchew/20200304133538.9159-1-dplotnikov@virtuozzo.com - [tag update] patchew/20200305010446.17029-1-philmd@redhat.com -> patchew/20200305010446.17029-1-philmd@redhat.com - [tag update] patchew/20200306025030.28824-1-pannengyuan@huawei.com -> patchew/20200306025030.28824-1-pannengyuan@huawei.com - [tag update] patchew/20200306051536.27803-1-vsementsov@virtuozzo.com -> patchew/20200306051536.27803-1-vsementsov@virtuozzo.com * [new tag] patchew/20200306110959.29461-1-peter.maydell@linaro.org -> patchew/20200306110959.29461-1-peter.maydell@linaro.org Switched to a new branch 'test' 822e267 *.hx: Remove all the STEXI/ETEXI blocks cf4d8f0 docs: Remove old texinfo sources e128596 docs: Stop building qemu-doc 61ca231 ui/cocoa.m: Update documentation file and pathname 85ace89 docs: Generate qemu.1 manpage with Sphinx 8f8f2d7 docs: Split out sections for the manpage into .rst.inc files 0b4d8cf qemu-options.hx: Fix up the autogenerated rST 30a86e0 qemu-options.hx: Add rST documentation fragments 558bcaf scripts/hxtool-conv: Archive script used in qemu-options.hx conversion 6088045 docs: Roll -prom-env and -g target-specific info into qemu-options.hx 4a35bdb docs: Roll semihosting option information into qemu-options.hx f758f58 doc/scripts/hxtool.py: Strip trailing ':' from DEFHEADING/ARCHHEADING ea15a66 hmp-commands-info.hx: Add rST documentation fragments 2a6846e hmp-commands.hx: Add rST documentation fragments 308ea32 docs/system: convert Texinfo documentation to rST 0581547 docs/system: convert the documentation of deprecated features to rST. 0b0b7a5 docs/system: convert managed startup to rST. 5b7a3ff docs/system: Convert security.texi to rST format 1c6082e docs/system: Convert qemu-cpu-models.texi to rST 4067be2 docs: Create defs.rst.inc as a place to define substitutions aae104f docs/system: put qemu-block-drivers body in an included file d733d71 qemu-doc: remove indices other than findex cc1488c qemu-doc: move included files to docs/system 6eb687d qemu-doc: move qemu-tech.texi into main section 7d1ebfd qemu-doc: Remove the "CPU emulation" part of the "Implementation notes" 9efad3c qemu-doc: split target sections to separate files 54f7530 qemu-doc: move system requirements chapter inside PC section 9ae6c4f qemu-doc: extract common system emulator documentation from the PC section f22f4e7 qemu-doc: split qemu-doc.texi in multiple files 8951b04 qemu-doc: split CPU models doc between MIPS and x86 parts 3241a52 texi2pod: parse @include directives outside "@c man" blocks 779838b qemu-doc: remove target OS documentation 0e3b6a3 qemu-doc: convert user-mode emulation to a separate Sphinx manual === OUTPUT BEGIN === 1/33 Checking commit 0e3b6a379032 (qemu-doc: convert user-mode emulation to a separate Sphinx manual) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #87: new file mode 100644 total: 0 errors, 1 warnings, 718 lines checked Patch 1/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/33 Checking commit 779838b92f6d (qemu-doc: remove target OS documentation) 3/33 Checking commit 3241a5236d14 (texi2pod: parse @include directives outside "@c man" blocks) 4/33 Checking commit 8951b04f2f82 (qemu-doc: split CPU models doc between MIPS and x86 parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #95: new file mode 100644 total: 0 errors, 1 warnings, 548 lines checked Patch 4/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/33 Checking commit f22f4e746e48 (qemu-doc: split qemu-doc.texi in multiple files) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #52: new file mode 100644 total: 0 errors, 1 warnings, 2965 lines checked Patch 5/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/33 Checking commit 9ae6c4f03a1c (qemu-doc: extract common system emulator documentation from the PC section) 7/33 Checking commit 54f75306ad48 (qemu-doc: move system requirements chapter inside PC section) 8/33 Checking commit 9efad3cf1480 (qemu-doc: split target sections to separate files) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100644 total: 0 errors, 1 warnings, 1727 lines checked Patch 8/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/33 Checking commit 7d1ebfdd5880 (qemu-doc: Remove the "CPU emulation" part of the "Implementation notes") 10/33 Checking commit 6eb687df0f7b (qemu-doc: move qemu-tech.texi into main section) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: rename from qemu-tech.texi total: 0 errors, 1 warnings, 49 lines checked Patch 10/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/33 Checking commit cc1488c492b6 (qemu-doc: move included files to docs/system) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #80: rename from qemu-deprecated.texi total: 0 errors, 1 warnings, 62 lines checked Patch 11/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/33 Checking commit d733d713d050 (qemu-doc: remove indices other than findex) 13/33 Checking commit aae104fbc65c (docs/system: put qemu-block-drivers body in an included file) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #1040: new file mode 100644 total: 0 errors, 1 warnings, 1956 lines checked Patch 13/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/33 Checking commit 4067be2cf173 (docs: Create defs.rst.inc as a place to define substitutions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 38 lines checked Patch 14/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/33 Checking commit 1c6082e9ff56 (docs/system: Convert qemu-cpu-models.texi to rST) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #136: new file mode 100644 total: 0 errors, 1 warnings, 557 lines checked Patch 15/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/33 Checking commit 5b7a3ffdeb30 (docs/system: Convert security.texi to rST format) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 178 lines checked Patch 16/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/33 Checking commit 0b0b7a531654 (docs/system: convert managed startup to rST.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 42 lines checked Patch 17/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/33 Checking commit 05815476f955 (docs/system: convert the documentation of deprecated features to rST.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 total: 0 errors, 1 warnings, 450 lines checked Patch 18/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/33 Checking commit 308ea32b5946 (docs/system: convert Texinfo documentation to rST) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #77: new file mode 100644 total: 0 errors, 1 warnings, 2224 lines checked Patch 19/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/33 Checking commit 2a6846e77a48 (hmp-commands.hx: Add rST documentation fragments) ERROR: trailing whitespace #992: FILE: hmp-commands.hx:1674: + \ $ total: 1 errors, 0 warnings, 1385 lines checked Patch 20/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/33 Checking commit ea15a66b2ce0 (hmp-commands-info.hx: Add rST documentation fragments) 22/33 Checking commit f758f58b4eb5 (doc/scripts/hxtool.py: Strip trailing ':' from DEFHEADING/ARCHHEADING) 23/33 Checking commit 4a35bdb47c94 (docs: Roll semihosting option information into qemu-options.hx) 24/33 Checking commit 6088045abde3 (docs: Roll -prom-env and -g target-specific info into qemu-options.hx) 25/33 Checking commit 558bcaf31981 (scripts/hxtool-conv: Archive script used in qemu-options.hx conversion) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100755 WARNING: line over 80 characters #64: FILE: scripts/hxtool-conv.pl:41: + # Return true if every line in the fragment is a start or end table directive total: 0 errors, 2 warnings, 137 lines checked Patch 25/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/33 Checking commit 30a86e06aaf8 (qemu-options.hx: Add rST documentation fragments) 27/33 Checking commit 0b4d8cf6fe5e (qemu-options.hx: Fix up the autogenerated rST) ERROR: trailing whitespace #73: FILE: qemu-options.hx:452: + \ $ ERROR: trailing whitespace #77: FILE: qemu-options.hx:456: + \ $ ERROR: trailing whitespace #79: FILE: qemu-options.hx:458: + \ $ ERROR: trailing whitespace #81: FILE: qemu-options.hx:460: + \ $ ERROR: trailing whitespace #92: FILE: qemu-options.hx:701: + \ $ ERROR: trailing whitespace #125: FILE: qemu-options.hx:1661: + \ $ ERROR: trailing whitespace #127: FILE: qemu-options.hx:1663: + \ $ ERROR: trailing whitespace #163: FILE: qemu-options.hx:2618: + \ $ ERROR: trailing whitespace #178: FILE: qemu-options.hx:2821: + \ $ ERROR: trailing whitespace #180: FILE: qemu-options.hx:2823: + \ $ ERROR: trailing whitespace #332: FILE: qemu-options.hx:6606: + \ $ ERROR: trailing whitespace #351: FILE: qemu-options.hx:7235: + \ $ ERROR: trailing whitespace #407: FILE: qemu-options.hx:8799: + \ $ total: 13 errors, 0 warnings, 379 lines checked Patch 27/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/33 Checking commit 8f8f2d732e8e (docs: Split out sections for the manpage into .rst.inc files) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 total: 0 errors, 1 warnings, 722 lines checked Patch 28/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/33 Checking commit 85ace89f101a (docs: Generate qemu.1 manpage with Sphinx) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #74: new file mode 100644 total: 0 errors, 1 warnings, 87 lines checked Patch 29/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/33 Checking commit 61ca231753e1 (ui/cocoa.m: Update documentation file and pathname) 31/33 Checking commit e12859635812 (docs: Stop building qemu-doc) 32/33 Checking commit cf4d8f0796a2 (docs: Remove old texinfo sources) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #57: deleted file mode 100644 total: 0 errors, 1 warnings, 29 lines checked Patch 32/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/33 Checking commit 822e26748fc2 (*.hx: Remove all the STEXI/ETEXI blocks) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200306110959.29461-1-peter.maydell@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, 6 Mar 2020 at 11:10, Peter Maydell <peter.maydell@linaro.org> wrote: > > As promised, here's a pull request with the patches which do the > qemu-doc rST conversion. > > Minor changes since the patchset was posted: > * rebased > * the two auto-generated patches have been regenerated, to account > for the qemu-options.hx changes that went into master since the > patchset was posted > > I have also now done the testing of the OSX change to the docs link. > We've agreed to leave updating the Windows installer for later. Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM
Patchew URL: https://patchew.org/QEMU/20200306110959.29461-1-peter.maydell@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-mingw@fedora J=14 NETWORK=1 === TEST SCRIPT END === File: "/tmp/qemu-nsis\qemu-doc.html" -> no files found. Usage: File [/nonfatal] [/a] ([/r] [/x filespec [...]] filespec [...] | /oname=outfile one_file_only) Error in script "/tmp/qemu-test/src/qemu.nsi" on line 180 -- aborting creation process make: *** [Makefile:1162: qemu-setup-4.2.50.exe] Error 1 Traceback (most recent call last): File "./tests/docker/docker.py", line 664, in <module> sys.exit(main()) --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=e30feec132e54b2ca9024611799ee279', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-4j5z63bl/src/docker-src.2020-03-06-06.51.46.20058:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=e30feec132e54b2ca9024611799ee279 make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-4j5z63bl/src' make: *** [docker-run-test-mingw@fedora] Error 2 real 4m7.853s user 0m6.019s The full log is available at http://patchew.org/logs/20200306110959.29461-1-peter.maydell@linaro.org/testing.docker-mingw@fedora/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com