mbox series

[PATCH-for-5.1?,0/4] hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize

Message ID 20200803105647.22223-1-f4bug@amsat.org
Headers show
Series hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize | expand

Message

Philippe Mathieu-Daudé Aug. 3, 2020, 10:56 a.m. UTC 
This is not a critical issue, but still annoying if you use tracing.

Maybe it is worth fixing for forks that are based on release tags,
else consider it 5.2 material.

Anyway we can still discuss if qdev_connect_clock_in() is supposed to
be callable *after* DeviceRealize.

Philippe Mathieu-Daudé (4):
  hw/arm/xilinx_zynq: Uninline cadence_uart_create()
  hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize
  hw/qdev-clock: Uninline qdev_connect_clock_in()
  hw/qdev-clock: Avoid calling qdev_connect_clock_in after DeviceRealize

 include/hw/char/cadence_uart.h | 17 -----------------
 include/hw/qdev-clock.h        |  8 +++-----
 hw/arm/xilinx_zynq.c           | 24 +++++++++++++++++-------
 hw/core/qdev-clock.c           |  6 ++++++
 4 files changed, 26 insertions(+), 29 deletions(-)