mbox series

[PULL,0/5] Ui 20200831 patches

Message ID 20200831110416.15176-1-kraxel@redhat.com
Headers show
Series Ui 20200831 patches | expand

Message

Gerd Hoffmann Aug. 31, 2020, 11:04 a.m. UTC 
The following changes since commit 39335fab59e11cfda9b7cf63929825db2dd3a3e0:

  Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.2-pull-=
request' into staging (2020-08-28 22:30:11 +0100)

are available in the Git repository at:

  git://git.kraxel.org/qemu tags/ui-20200831-pull-request

for you to fetch changes up to e54635710f1cf667191a0a1d9df9a37d1c9b0ad0:

  ui/gtk: Update refresh interval after widget is realized (2020-08-31 10:41:=
43 +0200)

----------------------------------------------------------------
ui: memleak fixes.
gtk: refresh interval fix.
keymaps: don't require qemu-keymap (fix gitlab ci).
spice: add mouse buttons.

----------------------------------------------------------------

Frediano Ziglio (1):
  ui: Add more mouse buttons to SPICE

Gerd Hoffmann (1):
  meson: fix keymaps witout qemu-keymap

Pan Nengyuan (2):
  ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context()
  vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string

Philippe Mathieu-Daud=C3=A9 (1):
  ui/gtk: Update refresh interval after widget is realized

 ui/gtk-gl-area.c            | 11 ++++++++
 ui/gtk.c                    | 52 ++++++++++++++++++-------------------
 ui/spice-input.c            |  2 ++
 ui/vnc-auth-sasl.c          |  1 +
 pc-bios/keymaps/meson.build | 28 +++++++++++++-------
 5 files changed, 59 insertions(+), 35 deletions(-)

--=20
2.27.0

Comments

Gerd Hoffmann Sept. 1, 2020, 2:16 p.m. UTC | #1 
Hi,

> Generating ar with a custom command
> cp: '../../pc-bios/keymaps/ar' and 'pc-bios/keymaps/ar' are the same file

Hmm, strange.  No failures in gitlab ci:
	https://gitlab.com/kraxel/qemu/-/pipelines/183769485

Any chance this is an old build tree?  Specifically created before
commit ddcf607fa3d6 ("meson: drop keymaps symlink") was merged, and the
symlink is present still?

thanks,
  Gerd
Peter Maydell Sept. 1, 2020, 2:54 p.m. UTC | #2 
On Tue, 1 Sep 2020 at 15:16, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
>   Hi,
>
> > Generating ar with a custom command
> > cp: '../../pc-bios/keymaps/ar' and 'pc-bios/keymaps/ar' are the same file
>
> Hmm, strange.  No failures in gitlab ci:
>         https://gitlab.com/kraxel/qemu/-/pipelines/183769485
>
> Any chance this is an old build tree?  Specifically created before
> commit ddcf607fa3d6 ("meson: drop keymaps symlink") was merged, and the
> symlink is present still?

Yeah, mostly my build trees don't get regenerated. We like
incremental builds to continue to work.

thanks
-- PMM
Gerd Hoffmann Sept. 2, 2020, 9:42 a.m. UTC | #3 
On Tue, Sep 01, 2020 at 03:54:29PM +0100, Peter Maydell wrote:
> On Tue, 1 Sep 2020 at 15:16, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> >   Hi,
> >
> > > Generating ar with a custom command
> > > cp: '../../pc-bios/keymaps/ar' and 'pc-bios/keymaps/ar' are the same file
> >
> > Hmm, strange.  No failures in gitlab ci:
> >         https://gitlab.com/kraxel/qemu/-/pipelines/183769485
> >
> > Any chance this is an old build tree?  Specifically created before
> > commit ddcf607fa3d6 ("meson: drop keymaps symlink") was merged, and the
> > symlink is present still?
> 
> Yeah, mostly my build trees don't get regenerated. We like
> incremental builds to continue to work.

So just not creating the symlink isn't enough, i.e. configure must
remove it if present?

Or is requiring fresh build trees ok if announced in the
cover letter / pull request?

thanks,
  Gerd