mbox series

[PULL,00/17] Trivial branch for 5.2 patches

Message ID 20200919184451.2129349-1-laurent@vivier.eu
Headers show
Series Trivial branch for 5.2 patches | expand

Message

Laurent Vivier Sept. 19, 2020, 6:44 p.m. UTC
The following changes since commit de39a045bd8d2b49e4f3d07976622c29d58e0bac:

  Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200915-pull-request=
' into staging (2020-09-15 14:25:05 +0100)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request

for you to fetch changes up to 639b090df52a4952262615328a3fdfae81234ea8:

  contrib/: fix some comment spelling errors (2020-09-17 20:41:44 +0200)

----------------------------------------------------------------
Pull request trivial patches 20200919

----------------------------------------------------------------

Dov Murik (2):
  hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw
  hw/timer/hpet: Fix debug format strings

Laszlo Ersek (1):
  manual: escape backslashes in "parsed-literal" blocks

Philippe Mathieu-Daud=C3=A9 (4):
  hw/gpio/max7310: Remove impossible check
  hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition
  ui/spice-input: Remove superfluous forward declaration
  scripts/git.orderfile: Display meson files along with buildsys ones

Yonggang Luo (1):
  meson: remove empty else and duplicated gio deps

zhaolichang (9):
  qemu/: fix some comment spelling errors
  migration/: fix some comment spelling errors
  docs/: fix some comment spelling errors
  scripts/: fix some comment spelling errors
  util/: fix some comment spelling errors
  linux-user/: fix some comment spelling errors
  disas/: fix some comment spelling errors
  qapi/: fix some comment spelling errors
  contrib/: fix some comment spelling errors

 Changelog                                |   2 +-
 accel/tcg/user-exec.c                    |   2 +-
 audio/audio.c                            |   2 +-
 block.c                                  |   2 +-
 configure                                |   2 +-
 contrib/gitdm/filetypes.txt              |   6 +-
 contrib/ivshmem-client/ivshmem-client.h  |   2 +-
 contrib/libvhost-user/libvhost-user.c    |   4 +-
 contrib/libvhost-user/libvhost-user.h    |   2 +-
 disas/hppa.c                             |   2 +-
 disas/m68k.c                             |   8 +-
 disas/ppc.c                              |   2 +-
 docs/COLO-FT.txt                         |   6 +-
 docs/devel/blkdebug.txt                  |   2 +-
 docs/devel/migration.rst                 |   2 +-
 docs/devel/testing.rst                   |   2 +-
 docs/devel/tracing.txt                   |   2 +-
 docs/interop/bitmaps.rst                 |   2 +-
 docs/interop/dbus.rst                    |   4 +-
 docs/interop/nbd.txt                     |   2 +-
 docs/interop/vhost-user-gpu.rst          |   2 +-
 docs/interop/vhost-user.rst              |   4 +-
 docs/rdma.txt                            |   2 +-
 docs/specs/ppc-spapr-hotplug.txt         |   4 +-
 docs/specs/ppc-spapr-xive.rst            |   4 +-
 docs/system/arm/aspeed.rst               |   2 +-
 docs/system/deprecated.rst               |   8 +-
 docs/system/device-url-syntax.rst.inc    |   8 +-
 docs/system/target-avr.rst               |   4 +-
 docs/tools/virtiofsd.rst                 |   2 +-
 fsdev/virtfs-proxy-helper.c              |   2 +-
 hmp-commands.hx                          |   2 +-
 hw/gpio/max7310.c                        |   5 +-
 hw/ppc/ppc4xx_pci.c                      |   2 +-
 hw/timer/hpet.c                          |  27 ++----
 libdecnumber/decNumber.c                 |   2 +-
 linux-user/aarch64/signal.c              |   2 +-
 linux-user/cris/target_syscall.h         |   4 +-
 linux-user/flat.h                        |   2 +-
 linux-user/flatload.c                    |   4 +-
 linux-user/host/ppc64/safe-syscall.inc.S |   2 +-
 linux-user/syscall.c                     |   4 +-
 meson.build                              |   6 --
 migration/colo-failover.c                |   2 +-
 migration/colo.c                         |   2 +-
 migration/multifd.c                      |   4 +-
 migration/postcopy-ram.c                 |   4 +-
 migration/postcopy-ram.h                 |   2 +-
 migration/ram.c                          |  10 +--
 migration/rdma.c                         |   8 +-
 migration/savevm.c                       |   4 +-
 qapi/block-core.json                     |   4 +-
 qapi/crypto.json                         |   4 +-
 qemu-img.c                               |   2 +-
 qemu-options.hx                          | 108 +++++++++++------------
 qobject/qdict.c                          |   2 +-
 scripts/checkpatch.pl                    |   2 +-
 scripts/clean-header-guards.pl           |   2 +-
 scripts/decodetree.py                    |   6 +-
 scripts/git.orderfile                    |   1 +
 scripts/oss-fuzz/build.sh                |   2 +-
 scripts/tracetool/__init__.py            |   2 +-
 scsi/pr-manager-helper.c                 |   2 +-
 ui/spice-input.c                         |   1 -
 util/osdep.c                             |   2 +-
 util/qemu-progress.c                     |   2 +-
 util/qemu-sockets.c                      |   2 +-
 util/qemu-thread-win32.c                 |   2 +-
 util/qht.c                               |   2 +-
 util/trace-events                        |   2 +-
 70 files changed, 163 insertions(+), 185 deletions(-)

--=20
2.26.2

Comments

no-reply@patchew.org Sept. 19, 2020, 7:10 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20200919184451.2129349-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200919184451.2129349-1-laurent@vivier.eu
Subject: [PULL 00/17] Trivial branch for 5.2 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200919184451.2129349-1-laurent@vivier.eu -> patchew/20200919184451.2129349-1-laurent@vivier.eu
Switched to a new branch 'test'
6f9951a contrib/: fix some comment spelling errors
5d3d5a1 qapi/: fix some comment spelling errors
1ad31f2 disas/: fix some comment spelling errors
c5980ac linux-user/: fix some comment spelling errors
5779f24 util/: fix some comment spelling errors
418cb9d scripts/: fix some comment spelling errors
1ab9555 docs/: fix some comment spelling errors
cf7f2f5 migration/: fix some comment spelling errors
0b8aa37 qemu/: fix some comment spelling errors
94f4908 scripts/git.orderfile: Display meson files along with buildsys ones
84659a7 hw/timer/hpet: Fix debug format strings
f591d41 hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw
0ec7442 manual: escape backslashes in "parsed-literal" blocks
c0be395 ui/spice-input: Remove superfluous forward declaration
4066166 hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition
a5f3515 hw/gpio/max7310: Remove impossible check

=== OUTPUT BEGIN ===
1/16 Checking commit a5f3515e9187 (hw/gpio/max7310: Remove impossible check)
2/16 Checking commit 40661664b027 (hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition)
3/16 Checking commit c0be3951e528 (ui/spice-input: Remove superfluous forward declaration)
4/16 Checking commit 0ec7442ca655 (manual: escape backslashes in "parsed-literal" blocks)
5/16 Checking commit f591d4145830 (hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw)
6/16 Checking commit 84659a741320 (hw/timer/hpet: Fix debug format strings)
7/16 Checking commit 94f49083a57c (scripts/git.orderfile: Display meson files along with buildsys ones)
8/16 Checking commit 0b8aa371b9fd (qemu/: fix some comment spelling errors)
WARNING: line over 80 characters
#52: FILE: audio/audio.c:1677:
+         * the same configuration (except the driver), so it doesn't matter which

WARNING: Block comments use a leading /* on a separate line
#156: FILE: scsi/pr-manager-helper.c:130:
+    /* A simple feature negotiation protocol, even though there is

total: 0 errors, 2 warnings, 88 lines checked

Patch 8/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/16 Checking commit cf7f2f519156 (migration/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#96: FILE: migration/postcopy-ram.h:164:
+/* Call each of the shared 'waker's registered telling them of

WARNING: Block comments use a trailing */ on a separate line
#198: FILE: migration/savevm.c:2798:
+         * successful live migration */

total: 0 errors, 2 warnings, 144 lines checked

Patch 9/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/16 Checking commit 1ab9555a0bad (docs/: fix some comment spelling errors)
11/16 Checking commit 418cb9d78050 (scripts/: fix some comment spelling errors)
12/16 Checking commit 5779f24a9c25 (util/: fix some comment spelling errors)
13/16 Checking commit c5980acaeb8b (linux-user/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: linux-user/aarch64/signal.c:81:
+    /* The actual SVE data immediately follows.  It is laid out

WARNING: Block comments use a leading /* on a separate line
#39: FILE: linux-user/cris/target_syscall.h:7:
+/* pt_regs not only specifies the format in the user-struct during

ERROR: code indent should never use tabs
#61: FILE: linux-user/flat.h:46:
+^Iabi_ulong filler[5];    /* Reserved, set to zero */$

total: 1 errors, 2 warnings, 72 lines checked

Patch 13/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/16 Checking commit 1ad31f2af26f (disas/: fix some comment spelling errors)
ERROR: code indent should never use tabs
#26: FILE: disas/hppa.c:2024:
+^I^I      /* 'fA' will not generate a space before the register$

WARNING: Block comments use a leading /* on a separate line
#26: FILE: disas/hppa.c:2024:
+                     /* 'fA' will not generate a space before the register

ERROR: code indent should never use tabs
#79: FILE: disas/ppc.c:5229:
+^I     number of ones, followed by some number of zeros.  */$

WARNING: Block comments use a trailing */ on a separate line
#79: FILE: disas/ppc.c:5229:
+            number of ones, followed by some number of zeros.  */

total: 2 errors, 2 warnings, 48 lines checked

Patch 14/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/16 Checking commit 5d3d5a19562d (qapi/: fix some comment spelling errors)
16/16 Checking commit 6f9951a0c75c (contrib/: fix some comment spelling errors)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200919184451.2129349-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell Sept. 22, 2020, 3:40 p.m. UTC | #2
On Sat, 19 Sep 2020 at 19:48, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit de39a045bd8d2b49e4f3d07976622c29d58e0bac:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200915-pull-request=
> ' into staging (2020-09-15 14:25:05 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request
>
> for you to fetch changes up to 639b090df52a4952262615328a3fdfae81234ea8:
>
>   contrib/: fix some comment spelling errors (2020-09-17 20:41:44 +0200)
>
> ----------------------------------------------------------------
> Pull request trivial patches 20200919
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2
for any user-visible changes.

-- PMM