mbox series

[v2,0/6] hw/sd/sdcard: Do not attempt to erase out of range addresses

Message ID 20201015063824.212980-1-f4bug@amsat.org
Headers show
Series hw/sd/sdcard: Do not attempt to erase out of range addresses | expand

Message

Philippe Mathieu-Daudé Oct. 15, 2020, 6:38 a.m. UTC
Yet another bug in the sdcard model found by libfuzzer:
https://bugs.launchpad.net/bugs/1895310

Since RFC: Settled migration issue

Philippe Mathieu-Daudé (6):
  hw/sd/sdcard: Add trace event for ERASE command (CMD38)
  hw/sd/sdcard: Introduce the INVALID_ADDRESS definition
  hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS
  hw/sd/sdcard: Reset both start/end addresses on error
  hw/sd/sdcard: Do not attempt to erase out of range addresses
  hw/sd/sdcard: Assert if accessing an illegal group

 hw/sd/sd.c         | 30 ++++++++++++++++++++++--------
 hw/sd/trace-events |  2 +-
 2 files changed, 23 insertions(+), 9 deletions(-)

-- 
2.26.2

Comments

Alexander Bulekov Oct. 17, 2020, 6:31 p.m. UTC | #1
On 201015 0838, Philippe Mathieu-Daudé wrote:
> Yet another bug in the sdcard model found by libfuzzer:

> https://bugs.launchpad.net/bugs/1895310

> 

> Since RFC: Settled migration issue

> 

> Philippe Mathieu-Daudé (6):

>   hw/sd/sdcard: Add trace event for ERASE command (CMD38)

>   hw/sd/sdcard: Introduce the INVALID_ADDRESS definition

>   hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS

>   hw/sd/sdcard: Reset both start/end addresses on error

>   hw/sd/sdcard: Do not attempt to erase out of range addresses

>   hw/sd/sdcard: Assert if accessing an illegal group

> 

>  hw/sd/sd.c         | 30 ++++++++++++++++++++++--------

>  hw/sd/trace-events |  2 +-

>  2 files changed, 23 insertions(+), 9 deletions(-)

> 

> -- 

> 2.26.2

> 


Hi Phil,
For this series:
Tested-by: Alexander Bulekov <alxndr@bu.edu>


Thanks
-Alex
Philippe Mathieu-Daudé Oct. 21, 2020, 9:58 a.m. UTC | #2
On 10/17/20 8:31 PM, Alexander Bulekov wrote:
> On 201015 0838, Philippe Mathieu-Daudé wrote:

>> Yet another bug in the sdcard model found by libfuzzer:

>> https://bugs.launchpad.net/bugs/1895310

>>

>> Since RFC: Settled migration issue

>>

>> Philippe Mathieu-Daudé (6):

>>    hw/sd/sdcard: Add trace event for ERASE command (CMD38)

>>    hw/sd/sdcard: Introduce the INVALID_ADDRESS definition

>>    hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS

>>    hw/sd/sdcard: Reset both start/end addresses on error

>>    hw/sd/sdcard: Do not attempt to erase out of range addresses

>>    hw/sd/sdcard: Assert if accessing an illegal group

>>

>>   hw/sd/sd.c         | 30 ++++++++++++++++++++++--------

>>   hw/sd/trace-events |  2 +-

>>   2 files changed, 23 insertions(+), 9 deletions(-)

>>

>> -- 

>> 2.26.2

>>

> 

> Hi Phil,

> For this series:

> Tested-by: Alexander Bulekov <alxndr@bu.edu>


Thanks!

Series applied to sd-next tree.