| Message ID | 20201105070837.558332-1-laurent@vivier.eu |
|---|---|
| Headers | show |
| Series | Linux user for 5.2 patches | expand |
Patchew URL: https://patchew.org/QEMU/20201105070837.558332-1-laurent@vivier.eu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201105070837.558332-1-laurent@vivier.eu
Subject: [PULL 0/4] Linux user for 5.2 patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20201105070837.558332-1-laurent@vivier.eu -> patchew/20201105070837.558332-1-laurent@vivier.eu
Switched to a new branch 'test'
11627c2 linux-user: Check copy_from_user() return value in vma_dump_size()
51fc3d6 linux-user/syscall: Fix missing target_to_host_timespec64() check
60ba650 linux-user: Use "!= 0" when checking if MAP_FIXED_NOREPLACE is non-zero
77abc4c linux-user/mips/cpu_loop: silence the compiler warnings
=== OUTPUT BEGIN ===
1/4 Checking commit 77abc4ceda78 (linux-user/mips/cpu_loop: silence the compiler warnings)
2/4 Checking commit 60ba6508037c (linux-user: Use "!= 0" when checking if MAP_FIXED_NOREPLACE is non-zero)
3/4 Checking commit 51fc3d6ec118 (linux-user/syscall: Fix missing target_to_host_timespec64() check)
4/4 Checking commit 11627c281598 (linux-user: Check copy_from_user() return value in vma_dump_size())
ERROR: space prohibited between function name and open parenthesis '('
#29: FILE: linux-user/elfload.c:3488:
+ if (copy_from_user(page, vma->vma_start, sizeof (page))) {
total: 1 errors, 0 warnings, 10 lines checked
Patch 4/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20201105070837.558332-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Thu, 5 Nov 2020 at 07:10, Laurent Vivier <laurent@vivier.eu> wrote: > > The following changes since commit 8680d6e36468f1ca00e2fe749bef50585d632401: > > Merge remote-tracking branch 'remotes/nvme/tags/pull-nvme-20201102' into st= > aging (2020-11-02 17:17:29 +0000) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-5.2-pull-request > > for you to fetch changes up to 022625a8ade3005addb42700a145bae6a1653240: > > linux-user: Check copy_from_user() return value in vma_dump_size() (2020-11= > -04 22:28:05 +0100) > > ---------------------------------------------------------------- > Coverity and compiler warning fixes > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM
The following changes since commit 8680d6e36468f1ca00e2fe749bef50585d632401: Merge remote-tracking branch 'remotes/nvme/tags/pull-nvme-20201102' into st= aging (2020-11-02 17:17:29 +0000) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-5.2-pull-request for you to fetch changes up to 022625a8ade3005addb42700a145bae6a1653240: linux-user: Check copy_from_user() return value in vma_dump_size() (2020-11= -04 22:28:05 +0100) ---------------------------------------------------------------- Coverity and compiler warning fixes ---------------------------------------------------------------- Alistair Francis (1): linux-user/syscall: Fix missing target_to_host_timespec64() check Chen Qun (1): linux-user/mips/cpu_loop: silence the compiler warnings Peter Maydell (2): linux-user: Use "!=3D 0" when checking if MAP_FIXED_NOREPLACE is non-zero linux-user: Check copy_from_user() return value in vma_dump_size() linux-user/elfload.c | 7 +++++-- linux-user/mips/cpu_loop.c | 4 ++++ linux-user/syscall.c | 4 +++- 3 files changed, 12 insertions(+), 3 deletions(-) --=20 2.28.0