From patchwork Wed Feb 15 17:43:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 653730 Delivered-To: patch@linaro.org Received: by 2002:adf:f90f:0:0:0:0:0 with SMTP id b15csp476648wrr; Wed, 15 Feb 2023 09:44:38 -0800 (PST) X-Google-Smtp-Source: AK7set+crymnxdLnM8VjYz1/ivamRhYoJzmRoEynWPY2sF1iA96b8PQ18l04iIveG4GKSu0Hl0hd X-Received: by 2002:a05:622a:2d3:b0:3bc:fa90:e8bb with SMTP id a19-20020a05622a02d300b003bcfa90e8bbmr4780978qtx.30.1676483077852; Wed, 15 Feb 2023 09:44:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676483077; cv=none; d=google.com; s=arc-20160816; b=khGStrcyK8YhRl+aYNV3Pvq/9Xyr3RgdmaM805HG1JnqRkpBMyi19k65cdkyU7dIzr fqIEvLhnB0+hXAldk6xfniSvsq8N1dAwSz7yyEEZ6BcYMeED1903TA7CRFxXjVBE8gP6 dDwlEnr7VjePX2s1lCTfViK3nyoG+1auYpFK5LwvQTOAqRrUn1ZXmbYMZ+QKl7Uf29Z6 zY7jphfpoIZRbk0UFadbNNnfeVnPCC4KQt4CRKOCHsPqFt0E6+T+rzpbpk0NwQn9MVVB uZk7y4xkVD34F4F46E+gYlO6OY9SwzLixL0lc3mBMygENPxgZv5zI3/7AnvXTZp++ft4 b9Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=1qgw8+Wwe6UbEIQRuVneXNaCb/C9jGyBn8UJr2mvMpE=; b=V7lvO5xPO5H2m34WQdnn5f9Wz/Suqq5aw6IdOFoFf7BMlHjEzVDYw26SS9pZSsfBsi leb6ObXcW7E8lfRio3h7m8sdFst4pJqtd8pymwUb/ye81lrQokAOVjzwpCZb4/EcPJuj J5D1w/4v79HCq6NY0Mko6S+iaZqxLia2EOS46l801DKks+KKCv3x+GeMEyxDl0i6QjY1 hCRfYq3HjQqLVU8b2ii11EXzr+f8vZdochwVDhYTa1787rburNMdzEaTThw4mnUqtJkG CMi3eDcchV8ZZQQ60lEK4zHgWN4colKARQpC2c2tDfEDeSvtpt724GnQLg61mIjKoe4Q 5lvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OUQYxjBO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k6-20020a05620a414600b007107e3bb636si16248433qko.191.2023.02.15.09.44.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Feb 2023 09:44:37 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OUQYxjBO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSLp3-0000aY-PE; Wed, 15 Feb 2023 12:44:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSLp1-0000ZT-Tt for qemu-devel@nongnu.org; Wed, 15 Feb 2023 12:43:59 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSLoz-0008CV-Qe for qemu-devel@nongnu.org; Wed, 15 Feb 2023 12:43:59 -0500 Received: by mail-wr1-x436.google.com with SMTP id co8so16222877wrb.1 for ; Wed, 15 Feb 2023 09:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1qgw8+Wwe6UbEIQRuVneXNaCb/C9jGyBn8UJr2mvMpE=; b=OUQYxjBOzhi4iZJef7RmHx3pYvwnmJUQ9l254ANvT2XMvaNRjgh549I0BaL2o47oQM jEHSngvage9JIW3vJigdLEUyqataQvj3iecmCSgaj+oITeCWfqBIO9G9ZNyzuYyx8TCo LT4l2JYUwrNY/oSrO6U82VGZeA3zn0fjqvRUMHjQJElb6QqLyqzAwnXZpwn2qQ+XpmDl xejTlxSPs7dSIl9n+MgYiiUzOleavDjjTIrgaj12JaHZJ1CQ5mZ28SRb2MDfil4ksVnW JEr9Vj2QmEWvtSVaD0hxOjWlT54LqcvP9dpDm3ln7tRP9hItK4p9WnozsISPz3ACuEXP 1QSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1qgw8+Wwe6UbEIQRuVneXNaCb/C9jGyBn8UJr2mvMpE=; b=DOxmiaLKAmYic3roCSIMI9md8F4DAtPEbJ136zcNvF/79rRbs7Eh0Yj76t4W/LoAZv HFBtzCpc1qeRqbuQ9tkbCXnyOdGd42T9Ow38hBlRvgHYLCW2J/rFbAoVqnJKUnbZ1WyJ CIFUL56oXf4+8IGFFQtCcZcqnu603R1uv4H72uNzghMViAtIaa4Jk3o7c76F3uaA/U+m jH4M8a1/BzQL4UcxKf0PlkP12WvJoyxPBwh/s6uXtxFt/7YFAXNbWPSDQkDtSBSkN4jj FvWw2XPQ9frF+LMrsX9HMOqz4hE094ELzIkLVN26mJUariG1SrxZvwp7q9tRs1Dkx+5w UMrw== X-Gm-Message-State: AO0yUKU3zbAXO10z9YFRjgR2MgKpWkFd7DeK9oFvwkh0b4NkzUKMlF7i /ukU5Tynf7O8xRHp/b4zy6H0BgJO9BpBj/PN X-Received: by 2002:adf:fdc3:0:b0:2c5:4480:b590 with SMTP id i3-20020adffdc3000000b002c54480b590mr2456780wrs.54.1676483035789; Wed, 15 Feb 2023 09:43:55 -0800 (PST) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id g9-20020a5d5409000000b002c558228b6dsm8674648wrv.12.2023.02.15.09.43.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Feb 2023 09:43:55 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcelo Tosatti , Sergio Lopez , Paolo Bonzini , Richard Henderson , kvm@vger.kernel.org, "Michael S. Tsirkin" , Eduardo Habkost , qemu-ppc@nongnu.org, Marcel Apfelbaum , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH 0/5] hw/timer/i8254: Un-inline and simplify IRQs Date: Wed, 15 Feb 2023 18:43:48 +0100 Message-Id: <20230215174353.37097-1-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org i8254_pit_init() uses a odd pattern of "use this IRQ output line if non-NULL, otherwise use the ISA IRQ #number as output". Rework as simply "Use this IRQ output". Un-inline/rename/document functions. Based-on: <20230215161641.32663-1-philmd@linaro.org> "hw/ide: Untangle ISA/PCI abuses of ide_init_ioport" v2 https://lore.kernel.org/qemu-devel/20230215161641.32663-1-philmd@linaro.org/ Philippe Mathieu-Daudé (5): hw/timer/hpet: Include missing 'hw/qdev-properties.h' header hw/timer/i8254: Factor i8254_pit_create() out and document hw/i386/pc: Un-inline i8254_pit_init() hw/timer/i8254: Really inline i8254_pit_init() hw/i386/kvm: Factor i8254_pit_create_try_kvm() out hw/i386/kvm/i8254.c | 18 ++++++++++++++ hw/i386/microvm.c | 6 +---- hw/i386/pc.c | 15 +++++------- hw/isa/i82378.c | 2 +- hw/isa/piix4.c | 4 ++-- hw/isa/vt82c686.c | 2 +- hw/mips/jazz.c | 2 +- hw/timer/hpet.c | 1 + hw/timer/i8254.c | 16 +++++++++++++ include/hw/timer/i8254.h | 48 +++++++++++++------------------------- target/i386/kvm/kvm-stub.c | 6 +++++ 11 files changed, 69 insertions(+), 51 deletions(-) Acked-by: Michael S. Tsirkin