mbox series

[v2,0/8] tcg: Document *swap* helper implementations

Message ID 20230823145542.79633-1-philmd@linaro.org
Headers show
Series tcg: Document *swap* helper implementations | expand

Message

Philippe Mathieu-Daudé Aug. 23, 2023, 2:55 p.m. UTC 
Since v1 [*]:
- Split few patches
- Dropped 'document deposit_z()'
- Document TCG_BSWAP_IZ flag (rth)
- Added R-b tags

[*] https://lore.kernel.org/qemu-devel/20230822093712.38922-1-philmd@linaro.org/

Supersedes: <20230822093712.38922-1-philmd@linaro.org>

Philippe Mathieu-Daudé (8):
  tcg/tcg-op: Document bswap16_i32() byte pattern
  tcg/tcg-op: Document bswap16_i64() byte pattern
  tcg/tcg-op: Document bswap32_i32() byte pattern
  tcg/tcg-op: Document bswap32_i64() byte pattern
  tcg/tcg-op: Document bswap64_i64() byte pattern
  tcg/tcg-op: Document hswap_i32/64() byte pattern
  tcg/tcg-op: Document wswap_i64() byte pattern
  target/cris: Fix a typo in gen_swapr()

 target/cris/translate.c |  20 ++++---
 tcg/tcg-op.c            | 124 +++++++++++++++++++++++++++++++---------
 2 files changed, 107 insertions(+), 37 deletions(-)

Comments

Richard Henderson Aug. 23, 2023, 6:46 p.m. UTC | #1 
On 8/23/23 07:55, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (8):
>    tcg/tcg-op: Document bswap16_i32() byte pattern
>    tcg/tcg-op: Document bswap16_i64() byte pattern
>    tcg/tcg-op: Document bswap32_i32() byte pattern
>    tcg/tcg-op: Document bswap32_i64() byte pattern
>    tcg/tcg-op: Document bswap64_i64() byte pattern
>    tcg/tcg-op: Document hswap_i32/64() byte pattern
>    tcg/tcg-op: Document wswap_i64() byte pattern
>    target/cris: Fix a typo in gen_swapr()

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

and queued to tcg-next with a few tweaks.


r~
Philippe Mathieu-Daudé Aug. 23, 2023, 9:54 p.m. UTC | #2 
On 23/8/23 20:46, Richard Henderson wrote:
> On 8/23/23 07:55, Philippe Mathieu-Daudé wrote:
>> Philippe Mathieu-Daudé (8):
>>    tcg/tcg-op: Document bswap16_i32() byte pattern
>>    tcg/tcg-op: Document bswap16_i64() byte pattern
>>    tcg/tcg-op: Document bswap32_i32() byte pattern
>>    tcg/tcg-op: Document bswap32_i64() byte pattern
>>    tcg/tcg-op: Document bswap64_i64() byte pattern
>>    tcg/tcg-op: Document hswap_i32/64() byte pattern
>>    tcg/tcg-op: Document wswap_i64() byte pattern
>>    target/cris: Fix a typo in gen_swapr()
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> and queued to tcg-next with a few tweaks.

Thanks!