mbox series

[v2,0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG

Message ID 20231003123026.99229-1-philmd@linaro.org
Headers show
Series accel: Restrict tcg_exec_[un]realizefn() to TCG | expand

Message

Philippe Mathieu-Daudé Oct. 3, 2023, 12:30 p.m. UTC 
Since v1:
- Use 'target'/'common' in function names (Claudio)
- Added Claudio R-b tags

From v1:
- Add missing accel_cpu_common_unrealize()
- Add AccelClass::cpu_common_[un]realize handlers
- Use tcg_exec_[un]realizefn as AccelClass handlers

Philippe Mathieu-Daudé (7):
  accel: Rename accel_cpu_realizefn() ->  accel_cpu_realize()
  accel: Rename AccelCPUClass::cpu_realizefn() -> cpu_target_realize()
  accel: Rename accel_cpu_realize() -> accel_cpu_common_realize()
  accel: Introduce accel_cpu_common_unrealize() stub
  accel: Declare AccelClass::cpu_common_[un]realize() handlers
  accel/tcg: Have tcg_exec_realizefn() return a boolean
  accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG

 accel/tcg/internal.h        |  3 +++
 include/exec/cpu-all.h      |  2 --
 include/hw/core/accel-cpu.h |  2 +-
 include/qemu/accel.h        | 12 ++++++++++--
 accel/accel-common.c        | 27 ++++++++++++++++++++++++---
 accel/tcg/cpu-exec.c        |  4 +++-
 accel/tcg/tcg-all.c         |  2 ++
 cpu.c                       | 13 +++----------
 target/i386/hvf/hvf-cpu.c   |  2 +-
 target/i386/kvm/kvm-cpu.c   |  4 ++--
 target/i386/tcg/tcg-cpu.c   |  2 +-
 11 files changed, 50 insertions(+), 23 deletions(-)

Comments

Claudio Fontana Oct. 3, 2023, 2:06 p.m. UTC | #1 
Nice. I build-tested and make checked this as well,

Reviewed-by: Claudio Fontana <cfontana@suse.de>
Tested-by: Claudio Fontana <cfontana@suse.de>

On 10/3/23 14:30, Philippe Mathieu-Daudé wrote:
> Since v1:
> - Use 'target'/'common' in function names (Claudio)
> - Added Claudio R-b tags
> 
> From v1:
> - Add missing accel_cpu_common_unrealize()
> - Add AccelClass::cpu_common_[un]realize handlers
> - Use tcg_exec_[un]realizefn as AccelClass handlers
> 
> Philippe Mathieu-Daudé (7):
>   accel: Rename accel_cpu_realizefn() ->  accel_cpu_realize()
>   accel: Rename AccelCPUClass::cpu_realizefn() -> cpu_target_realize()
>   accel: Rename accel_cpu_realize() -> accel_cpu_common_realize()
>   accel: Introduce accel_cpu_common_unrealize() stub
>   accel: Declare AccelClass::cpu_common_[un]realize() handlers
>   accel/tcg: Have tcg_exec_realizefn() return a boolean
>   accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG
> 
>  accel/tcg/internal.h        |  3 +++
>  include/exec/cpu-all.h      |  2 --
>  include/hw/core/accel-cpu.h |  2 +-
>  include/qemu/accel.h        | 12 ++++++++++--
>  accel/accel-common.c        | 27 ++++++++++++++++++++++++---
>  accel/tcg/cpu-exec.c        |  4 +++-
>  accel/tcg/tcg-all.c         |  2 ++
>  cpu.c                       | 13 +++----------
>  target/i386/hvf/hvf-cpu.c   |  2 +-
>  target/i386/kvm/kvm-cpu.c   |  4 ++--
>  target/i386/tcg/tcg-cpu.c   |  2 +-
>  11 files changed, 50 insertions(+), 23 deletions(-)
>
Richard Henderson Oct. 3, 2023, 4:02 p.m. UTC | #2 
On 10/3/23 05:30, Philippe Mathieu-Daudé wrote:
> Since v1:
> - Use 'target'/'common' in function names (Claudio)
> - Added Claudio R-b tags
> 
>  From v1:
> - Add missing accel_cpu_common_unrealize()
> - Add AccelClass::cpu_common_[un]realize handlers
> - Use tcg_exec_[un]realizefn as AccelClass handlers

Thanks, queued to tcg-next, replacing v1 that I queued before my holiday.  :-)


r~