From patchwork Fri Feb 23 16:21:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 775143 Delivered-To: patch@linaro.org Received: by 2002:adf:a356:0:b0:33b:4db1:f5b3 with SMTP id d22csp435774wrb; Fri, 23 Feb 2024 08:39:06 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWZBraTpXnVaDoATR3qvajJG1DUh7pRtw+87+zef/MW5aZW2PlZBzwdaV7bMFphO9ApZ0wtYxqkzG0+TNAVAmoq X-Google-Smtp-Source: AGHT+IGvfSXTVnJZfhIIHEtD9DHdxPNvxnUn9PV2b6dT1bXTsSALo0eGmBY9Q/TKb+PJphWMzXZz X-Received: by 2002:a05:6214:458d:b0:68f:5fe3:a90e with SMTP id op13-20020a056214458d00b0068f5fe3a90emr574551qvb.29.1708706345766; Fri, 23 Feb 2024 08:39:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708706345; cv=none; d=google.com; s=arc-20160816; b=kxVDgq8EKB6q4qVC3rVY6xcrmzLTlgSdjc8zw8qobYLfgNZy0NYqzlJBm0XDyiPKtg Z+O7h/+ERQz9ADftevNE/XN/p1edQS2/zP7lt4PvuT3E1bZk6/KmmclIgvaXirBnf0dV IPkkGbuKrItOV8gfiMRK8k0zSql591UX8uedGFF3eupBK6x533luFksiau3Tdp5UuXq8 0v3rNcLUG1nKCWHPRaKKCG8WTx9X+Tpv4//zEIGLkh7ue8Wp2pydk3ulzlxhTF109XCg XneDn8/XNVZOnQj6UL14C2wRDVdlA+txps0Uf/FDcPh2+3WugC/G1emQ3xul7/FkrAFV hDsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=ToD11vo/8rUjKiESU6uoSvQq8es5VKhsflbTNHBU+9U=; fh=/YEu+IjZM84YWRDAuPeJeqMoLNTdSzM/iYv/jybOCWk=; b=Mj/uBuOsMiUFddq1QmnEHyTPyYEuq/xzIw5XiS3xKogaRY9SeNYRTH0N6BIVKT7WQk g9zUw6rx54yLyd1b1EUSe61kR+7ngtAZYLzf+N8Fw9GbOigC3lfJWKyTHthFdFO/d6uP zDBgiJo4q9QPij2RFDGX5tWvgJCesI/R9UOyhrzfuGHv0HS8tQXrmQ9QUGJ/mEkZYymU b7PR+prHjptfmoUfnZuokCip1IxgcAG+tPMprULJSrV48j1XZ2xzanPi+haS0kQ+2oEO DpLislPrGshniOh2gju6puQ79hhTZCDYKKH4wysDn8QHn9o/IiveeGKY6c4fCQDACUq3 I59w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P+Xc1adj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t9-20020a05621421a900b0068fdb0b824esi1084647qvc.256.2024.02.23.08.39.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Feb 2024 08:39:05 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P+Xc1adj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdYZ8-0004uN-LI; Fri, 23 Feb 2024 11:38:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYJd-00043T-FM for qemu-devel@nongnu.org; Fri, 23 Feb 2024 11:22:26 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdYJJ-00062x-8p for qemu-devel@nongnu.org; Fri, 23 Feb 2024 11:22:25 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-41298159608so1581945e9.0 for ; Fri, 23 Feb 2024 08:22:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708705323; x=1709310123; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ToD11vo/8rUjKiESU6uoSvQq8es5VKhsflbTNHBU+9U=; b=P+Xc1adjeuPn0EaJjMw/fsjWQrrq4AGksWO7/9s4UqXphxkN8SGhYXup4PQuqJibYW +W/9DbsFn9VszcwdS0P+ehwu3qdJdmSuGqXYl+lIkjLA544Aam8SVaOtlgTvVVtksK8L aFhyhj8eX/0gH7IFogMDKJ52tWHc3GkMJc+GYXDCi3o9n93m5ARsnI8iPiAo6F6M89cw h3Mgh0DRZBOrXekOkSXQ/ykzpqNNM3Y6N6dGRDZ71gN/5RSBJNjj2l+/JVZZugrTOx6g he68awEYFys3W/nzoyChEXUcxBVR7UttVUBwO/8aH6jNx0r9TW1dPPDP7w9DLrfrvYeC 5zww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708705323; x=1709310123; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ToD11vo/8rUjKiESU6uoSvQq8es5VKhsflbTNHBU+9U=; b=LFnTzRc+iFfIx2XB52CjaH7GuCNinnN0YQCU2KMLCkJFUd1w/D+gWYpEGp0NJWGsiL oL/LIrY52fXJ4WfAHmb7q5buF9lLQAeyWTYLJGmL+afltCvozjHQiTzNbidbQQcQt2JP 0zrk4YaffdpRcJVyiFvFITPlyvamIAulEs277SLQ3Qyqq9bLKxH9l8aQNHthd9neoZtT ngd4aQSytTI+E/Qn2xEy/UguD2rynT8t+7dmSirbm+NQj9rbyx+wiYYOIr9AEXUmzg6L 8bQC3mECNdUF2DT+c742CR5TdBRqX5Qh3RYJcQhgzc/1aR0mmq9C4dvLihZilO4EnTsT 6tpQ== X-Gm-Message-State: AOJu0YxmkNVT5GIMZRwgJGbLmE4UlAeNP3AkYJIWZ1DTU99jVCkvX3e5 7JL7UodN9OVruaMaqThiOET5bO2LSt4t78xF9L/tnm+fmIK3Pw5RzEy8NXT1k5U= X-Received: by 2002:a05:600c:3505:b0:412:937c:169f with SMTP id h5-20020a05600c350500b00412937c169fmr300059wmq.5.1708705323121; Fri, 23 Feb 2024 08:22:03 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id z15-20020a05600c220f00b004126e26f756sm2771875wml.43.2024.02.23.08.22.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 08:22:02 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 671585F8A2; Fri, 23 Feb 2024 16:22:02 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Song Gao , qemu-s390x@nongnu.org, Liu Zhiwei , Pierrick Bouvier , Thomas Huth , Daniel Henrique Barboza , Bin Meng , Yanan Wang , Laurent Vivier , qemu-ppc@nongnu.org, David Hildenbrand , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Ilya Leoshkevich , Cleber Rosa , Nicholas Piggin , Marcel Apfelbaum , Eduardo Habkost , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Alexandre Iooss , Peter Maydell , =?utf-8?q?Alex_Benn=C3=A9e?= , Daniel Henrique Barboza , qemu-arm@nongnu.org, qemu-riscv@nongnu.org, Palmer Dabbelt , Mahmoud Mandour , John Snow , Weiwei Li , Alistair Francis , Yoshinori Sato , Brian Cain , Paolo Bonzini , "Edgar E. Iglesias" , Michael Rolnik Subject: [PATCH v2 00/27] maintainer updates for 9.0 pre-PR (tests, plugin register support) Date: Fri, 23 Feb 2024 16:21:35 +0000 Message-Id: <20240223162202.1936541-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The test patch is a simple house keeping one to clean up some inadvertent GPLv3 tagging to GPLv2-or-later. I've also increased the timeout for check-tcg due to TCI timesouts. The main bulk of this series is register reading support for TCG plugins. The main change to the API is that the get/read_register functions are now implicitly vCPU context only so have dropped the vcpu index parameter and use current_cpu instead. This avoids the need for locking the gdbstub structures in case there is a cross-vCPU access. I've pulled in some patches from Pierrick's inline enhancement series that allow this to happen (making sure the init callback is in the vCPU context). Changes for v2: After lots of back and forth in the last review I've dropped trying to be clever with CPUClass as it was pointed out even with a common CPUClass we might see different sets of registers depending on what features are enabled on a CPU. Now I just have a hash per CPUState (stored in the new CPUPluginState structure) with a simple reg_num key. I also fixed a bug in nios2-linux-user. The following still need review: contrib/plugins: extend execlog to track register changes tests/tcg: expand insn test case to exercise register API plugins: create CPUPluginState and migrate plugin_mask gdbstub: expose api to find registers linux-user: ensure nios2 processes queued work tests/tcg: bump TCG test timeout to 120s But I'd like to get this merged soon so its not a mad rush before soft freeze and so we can get the new inline support stabilised and merged. Alex. Akihiko Odaki (11): target/arm: Use GDBFeature for dynamic XML target/ppc: Use GDBFeature for dynamic XML target/riscv: Use GDBFeature for dynamic XML gdbstub: Use GDBFeature for gdb_register_coprocessor gdbstub: Use GDBFeature for GDBRegisterState gdbstub: Change gdb_get_reg_cb and gdb_set_reg_cb gdbstub: Simplify XML lookup gdbstub: Infer number of core registers from XML hw/core/cpu: Remove gdb_get_dynamic_xml member gdbstub: Add members to identify registers to GDBFeature plugins: Use different helpers when reading registers Alex Bennée (11): tests/tcg: update licenses to GPLv2 as intended tests/tcg: bump TCG test timeout to 120s linux-user: ensure nios2 processes queued work gdbstub: expose api to find registers plugins: create CPUPluginState and migrate plugin_mask plugins: add an API to read registers tests/tcg: expand insn test case to exercise register API contrib/plugins: fix imatch contrib/plugins: extend execlog to track register changes docs/devel: lift example and plugin API sections up docs/devel: document some plugin assumptions Pierrick Bouvier (5): plugins: remove previous n_vcpus functions from API plugins: add qemu_plugin_num_vcpus function plugins: fix order of init/idle/resume callback cpu: call plugin init hook asynchronously docs/devel: plugins can trigger a tb flush docs/devel/multi-thread-tcg.rst | 1 + docs/devel/tcg-plugins.rst | 72 +++- accel/tcg/plugin-helpers.h | 3 +- include/exec/gdbstub.h | 43 ++- include/hw/core/cpu.h | 18 +- include/qemu/plugin.h | 16 + include/qemu/qemu-plugin.h | 59 +++- include/qemu/typedefs.h | 1 + plugins/plugin.h | 6 +- target/arm/cpu.h | 27 +- target/arm/internals.h | 14 +- target/hexagon/internal.h | 4 +- target/microblaze/cpu.h | 4 +- target/ppc/cpu-qom.h | 1 + target/ppc/cpu.h | 5 +- target/riscv/cpu.h | 5 +- target/s390x/cpu.h | 2 - tests/tcg/aarch64/semicall.h | 4 +- tests/tcg/arm/semicall.h | 4 +- tests/tcg/multiarch/float_helpers.h | 4 +- tests/tcg/riscv64/semicall.h | 4 +- accel/tcg/plugin-gen.c | 46 ++- contrib/plugins/cache.c | 2 +- contrib/plugins/execlog.c | 318 +++++++++++++++--- gdbstub/gdbstub.c | 169 ++++++---- hw/core/cpu-common.c | 15 +- linux-user/nios2/cpu_loop.c | 1 + plugins/api.c | 129 +++++-- plugins/core.c | 27 +- target/arm/cpu.c | 2 - target/arm/cpu64.c | 1 - target/arm/gdbstub.c | 230 ++++++------- target/arm/gdbstub64.c | 122 +++---- target/avr/cpu.c | 1 - target/hexagon/cpu.c | 4 +- target/hexagon/gdbstub.c | 10 +- target/i386/cpu.c | 2 - target/loongarch/cpu.c | 2 - target/loongarch/gdbstub.c | 13 +- target/m68k/cpu.c | 1 - target/m68k/helper.c | 26 +- target/microblaze/cpu.c | 6 +- target/microblaze/gdbstub.c | 14 +- target/ppc/cpu_init.c | 7 - target/ppc/gdbstub.c | 114 ++++--- target/riscv/cpu.c | 15 - target/riscv/gdbstub.c | 145 ++++---- target/rx/cpu.c | 1 - target/s390x/cpu.c | 1 - target/s390x/gdbstub.c | 105 +++--- tests/plugin/insn.c | 21 ++ .../multiarch/arm-compat-semi/semiconsole.c | 4 +- .../multiarch/arm-compat-semi/semihosting.c | 4 +- tests/tcg/multiarch/float_convd.c | 4 +- tests/tcg/multiarch/float_convs.c | 4 +- tests/tcg/multiarch/float_madds.c | 4 +- tests/tcg/multiarch/libs/float_helpers.c | 4 +- plugins/qemu-plugins.symbols | 5 +- scripts/feature_to_c.py | 14 +- tests/tcg/Makefile.target | 9 +- tests/tcg/i386/system/boot.S | 6 +- tests/tcg/x86_64/system/boot.S | 6 +- 62 files changed, 1257 insertions(+), 654 deletions(-)