From patchwork Fri Aug 7 08:10:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haibo Xu X-Patchwork-Id: 247537 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp2232415ilo; Fri, 7 Aug 2020 01:11:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjq5XUjsU4kqalmrVd8aJ6hGnyVR2eGXEyzfcGdaEahvE7spvsbfPljQPHhhijQl8CGneT X-Received: by 2002:a25:9885:: with SMTP id l5mr20460830ybo.0.1596787916801; Fri, 07 Aug 2020 01:11:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596787916; cv=none; d=google.com; s=arc-20160816; b=y/MbWDP2yIOowBeG0dipWQjT2UIax/7vS45kGZTXsO9Lg/OCFxGtOUEQlIxvfutzmR slep/MIbryRCjwm0Jubz+C7Cw/CQS2d6RRYwHoKP8+mzmu/NFeXiIuviUrm7tqDLoTPw WBz81csBq6XnCVNQ1tbdCmMunmVgrCsdnwG+gscb+l/gSeyHTJYMNXDG/ueT22bZO9q6 3WdWO5x1UEF2Lb8fJaEfmvWGbjE3fVsUaNGOJAYV/qrFypMDv81cEzcDK7OnSlZrsyo8 +CS6cQzb+Pqeb+q+0ZGuk1bhlgdpihHmFWthZXaeiHqduw0eZ+aUJE/NTUg/rg4j6h0c J/xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=CoQS0jn/1hwXwTcHIYOL0+48OLeXmrMVmHENtEgtvUM=; b=t64quSDo9ey8Uylfr9KvKj+9VZvrTblO2WnwaBCV+SQo83lEM3Owwio6X7gY4J6xHw x/Oa/iw6hO5dQUBvRmv7J+v3uqsOalFClKT7tQPVp+TKgXNY4S86DaZx0xWhfsWKObGe +Uon3Eaulktikiqf3vpK4nUDFZSD26ARNPxb3Gb5jJ4JCrZ+dgUg9PR/J34WbdA7n8lH y0i5NIXze+JbybdJmIKqoyi+XYrwpGWtTlXOu9WAPb2CMhn4sUMV2SFTX0tk3yJ8wNPT gWEDiZIxWE547Df+AhR2R/B2q/O8LkNp86mbVPhlzxwO+TbEF37IOXqlrUKkddcayjD+ 9TIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=GaeH9aZC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z186si7231755ybc.63.2020.08.07.01.11.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Aug 2020 01:11:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=GaeH9aZC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3xTo-0007Zq-59 for patch@linaro.org; Fri, 07 Aug 2020 04:11:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3xSf-0006yx-8l for qemu-devel@nongnu.org; Fri, 07 Aug 2020 04:10:45 -0400 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:35916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3xSc-0001gw-3J for qemu-devel@nongnu.org; Fri, 07 Aug 2020 04:10:44 -0400 Received: by mail-io1-xd32.google.com with SMTP id t15so1077886iob.3 for ; Fri, 07 Aug 2020 01:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CoQS0jn/1hwXwTcHIYOL0+48OLeXmrMVmHENtEgtvUM=; b=GaeH9aZChBHRdPq0u5V59OslWHYdLl8rOY5wAxWLOQ1MI3tky7nzgwhYYq58khBl+q n9rXoc7MxJ83wRraLE+j8G3eS/huYIt45mz7bmtQ8kZYet3YPpm+kZeIVK/aWM7dwaEE a/cAZlh8fgeuD89keyLfLwxvhrq0i4MUeTYlZWGU0KWzZG1/Bwbog30RGEUfYO7SRpAk 9k5z+tWpyXsTMfDkv/1iVxl4aCfnbUVpxseMoxWAFyirwJrVb8nFdrMKCUyLBwYBUb5l 4s0a69+jgoxSoeXkx9tZHXXgob990NhU53lhIZBUV7Fm9JON9aaOuHMeofxBEmZ/KWFv VhkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CoQS0jn/1hwXwTcHIYOL0+48OLeXmrMVmHENtEgtvUM=; b=XVtrhzt3m05o8Sp5N2iWetk5+GqlCoxHTPhtG06ZFuhSnMZekPSJZjxfPdVuso/7GF Q63v5XgGBdEEAvDXbT3EuRroPw0MheV1nJLEOzhycZYjZ3IDB+D6KAsFSTMJqtfg3GQI bXZF9K4wQN1KX+t6WewO5lNwYORM0l/V8k1QXH8Q0JUPfI0vV9hdFXHwtnxk9yeqK45s R1LRQ/kW5UFvx9MYJ1DZKT4pjvrqbRHL6IKhtrCOLrMgIJ4XWn1sYRcSXUbFYmOolncz mFJAN/VIKTQV5ibMpJ6OVy3DMRkm2jQcCuEbmvXXidDW788e2myrqh0RRrEaJwg74JNy l9ug== X-Gm-Message-State: AOAM530QujrsFKCojcer7JlBxTRvl3OEZZYpgasoZeSyIZCGkPNhMdxK vaqZsKeZB9ABdtJxvpcGQHAQ X-Received: by 2002:a05:6602:2409:: with SMTP id s9mr3032017ioa.98.1596787840232; Fri, 07 Aug 2020 01:10:40 -0700 (PDT) Received: from localhost.localdomain ([147.75.106.138]) by smtp.gmail.com with ESMTPSA id l144sm6233546ill.6.2020.08.07.01.10.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:10:39 -0700 (PDT) From: Haibo Xu To: peter.maydell@linaro.org Subject: [PATCH 0/7] target/arm: Add vSPE support to KVM guest Date: Fri, 7 Aug 2020 08:10:30 +0000 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::d32; envelope-from=haibo.xu@linaro.org; helo=mail-io1-xd32.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drjones@redhat.com, qemu-arm@nongnu.org, philmd@redhat.com, qemu-devel@nongnu.org, Haibo Xu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This series add support for SPE(Statistical Profiling Extension)[1] in KVM guest. It's based on Andrew Murray's kernel KVM patches V2[2], and has been tested to ensure that guest can use SPE with valid data. E.g. In host: $ ./qemu-system-aarch64 \ -cpu host -M virt,accel=kvm,gic-version=3 -nographic -m 2048M \ -kernel ./Image-new \ -initrd /boot/initrd.img-5.6.0-rc2+ \ -append "root=/dev/vda rw console=ttyAMA0" -nodefaults -serial stdio\ -drive if=none,file=./xenial.rootfs.ext4,id=hd0,format=raw \ -device virtio-blk-device,drive=hd0 \ In guest: $ perf record -e arm_spe/ts_enable=1,pa_enable=1,pct_enable=1/ \ dd if=/dev/zero of=/dev/null count=1000 $ perf report --dump-raw-trace > spe_buf.txt The spe_buf.txt should contain similar data as below: . ... ARM SPE data: size 135944 bytes . 00000000: b0 f4 d3 29 10 00 80 ff a0 PC 0xff80001029d3f4 el1 ns=1 . 00000009: 99 0b 00 LAT 11 ISSUE . 0000000c: 98 0d 00 LAT 13 TOT . 0000000f: 52 16 00 EV RETIRED L1D-ACCESS TLB-ACCESS . 00000012: 49 00 LD . 00000014: b2 d0 40 d8 70 00 00 ff 00 VA 0xff000070d840d0 . 0000001d: 9a 01 00 LAT 1 XLAT . 00000020: 00 00 00 PAD . 00000023: 71 a5 1f b3 20 14 00 00 00 TS 86447955877 . 0000002c: b0 7c f9 29 10 00 80 ff a0 PC 0xff80001029f97c el1 ns=1 . 00000035: 99 02 00 LAT 2 ISSUE . 00000038: 98 03 00 LAT 3 TOT . 0000003b: 52 02 00 EV RETIRED . 0000003e: 48 00 INSN-OTHER . 00000040: 00 00 00 PAD . 00000043: 71 ef 1f b3 20 14 00 00 00 TS 86447955951 . 0000004c: b0 f0 e9 29 10 00 80 ff a0 PC 0xff80001029e9f0 el1 ns=1 . 00000055: 99 02 00 LAT 2 ISSUE . 00000058: 98 03 00 LAT 3 TOT . 0000005b: 52 02 00 EV RETIRED If you want to disable the vSPE support, you can use the 'spe=off' cpu property: ./qemu-system-aarch64 \ -cpu host,spe=off -M virt,accel=kvm,gic-version=3 -nographic -m 2048M \ -kernel ./Image-new \ -initrd /boot/initrd.img-5.6.0-rc2+ \ -append "root=/dev/vda rw console=ttyAMA0" -nodefaults -serial stdio\ -drive if=none,file=./xenial.rootfs.ext4,id=hd0,format=raw \ -device virtio-blk-device,drive=hd0 \ Note: (1) Since the kernel patches are still under review, some of the macros in the header files may be changed after merging. We may need to update them accordingly. (2) These patches only add vSPE support in KVM mode, for TCG mode, I'm not sure whether we need to support it. (3) Just followed the 'pmu' property, we only allow this feature to be removed from CPUs which enable it by default. But since the SPE is an optional feature extension for Armv8.2, I think a better way may be to disable it by default, and only enable it when the host cpu do have the feature. [1]https://community.arm.com/developer/ip-products/processors/b/processors-ip-blog/ posts/statistical-profiling-extension-for-armv8-a [2]https://www.spinics.net/lists/arm-kernel/msg776228.html Haibo Xu (7): update Linux headers with new vSPE macros target/arm/kvm: spe: Add helper to detect SPE when using KVM target/arm/cpu: spe: Add an option to turn on/off vSPE support target/arm/kvm: spe: Unify device attr operatioin helper target/arm/kvm: spe: Add device init and set_irq operations hw/arm/virt: spe: Add SPE fdt binding for virt machine target/arm/cpu: spe: Enable spe to work with host cpu hw/arm/virt-acpi-build.c | 3 +++ hw/arm/virt.c | 42 ++++++++++++++++++++++++++++++ include/hw/acpi/acpi-defs.h | 1 + include/hw/arm/virt.h | 1 + linux-headers/asm-arm64/kvm.h | 4 +++ linux-headers/linux/kvm.h | 2 ++ target/arm/cpu.c | 34 +++++++++++++++++++++++++ target/arm/cpu.h | 5 ++++ target/arm/kvm.c | 11 ++++++++ target/arm/kvm64.c | 48 ++++++++++++++++++++++++++++++++--- target/arm/kvm_arm.h | 18 +++++++++++++ 11 files changed, 166 insertions(+), 3 deletions(-) -- 2.17.1