From patchwork Mon Mar 14 15:37:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 555 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:43:40 -0000 Delivered-To: patches@linaro.org Received: by 10.224.45.75 with SMTP id d11cs59372qaf; Mon, 14 Mar 2011 08:37:16 -0700 (PDT) Received: by 10.216.190.168 with SMTP id e40mr10786381wen.68.1300117035930; Mon, 14 Mar 2011 08:37:15 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk [81.2.115.146]) by mx.google.com with ESMTPS id n4si14024460wej.152.2011.03.14.08.37.15 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Mar 2011 08:37:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) client-ip=81.2.115.146; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1Pz9pZ-00073v-OC; Mon, 14 Mar 2011 15:37:13 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org Subject: [PATCH v2 2/2] target-arm: use make_float32() to make constant floats for VRSQRTS Date: Mon, 14 Mar 2011 15:37:13 +0000 Message-Id: <1300117033-27120-3-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1300117033-27120-1-git-send-email-peter.maydell@linaro.org> References: <1300117033-27120-1-git-send-email-peter.maydell@linaro.org> The preferred way to create a constant floating point value is to use make_float32() rather than doing a runtime int32_to_float32(). Convert the code in the VRSQRTS helper to work this way. Signed-off-by: Peter Maydell --- target-arm/helper.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index c01a5a2..0dd2549 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2708,6 +2708,8 @@ uint32_t HELPER(vfp_fcvt_f32_to_f16)(float32 a, CPUState *env) } #define float32_two make_float32(0x40000000) +#define float32_three make_float32(0x40400000) +#define float32_one_point_five make_float32(0x3fc00000) float32 HELPER(recps_f32)(float32 a, float32 b, CPUState *env) { @@ -2722,16 +2724,13 @@ float32 HELPER(recps_f32)(float32 a, float32 b, CPUState *env) float32 HELPER(rsqrts_f32)(float32 a, float32 b, CPUState *env) { float_status *s = &env->vfp.standard_fp_status; - float32 two = int32_to_float32(2, s); - float32 three = int32_to_float32(3, s); float32 product; if ((float32_is_infinity(a) && float32_is_zero_or_denormal(b)) || (float32_is_infinity(b) && float32_is_zero_or_denormal(a))) { - product = float32_zero; - } else { - product = float32_mul(a, b, s); + return float32_one_point_five; } - return float32_div(float32_sub(three, product, s), two, s); + product = float32_mul(a, b, s); + return float32_div(float32_sub(float32_three, product, s), float32_two, s); } /* NEON helpers. */