From patchwork Thu Mar 28 14:33:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 15720 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 9547123E64 for ; Thu, 28 Mar 2013 14:33:28 +0000 (UTC) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by fiordland.canonical.com (Postfix) with ESMTP id 5D77DA19E15 for ; Thu, 28 Mar 2013 14:33:28 +0000 (UTC) Received: by mail-vc0-f182.google.com with SMTP id ht11so7711168vcb.13 for ; Thu, 28 Mar 2013 07:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=ZI5DAk+7DzJY9+nJGiU5RekdCs4qQpgyqi8eP9OBF5k=; b=W+Dga17/ugvBre8o+nEZDrdaUQlovpt7WAIFYtnMuj4zy0pk9Q/ixRwW/G9qwyzJWD JdpYrKy/2uEJ7jGSGtDLaPdzU4Er26WkfJpSvQN+xwPFllIEVZmAUqLLX+wVtMqwISZT sJe7kpDNxXmLECTfAvUqaKdHIp1clcxY9ACorQuXyDWZ1Ay1G6w7VWBbZCV0Yk8NymW7 Pz2SkehemcT2ez7ZDKzTSkh2F2WvMLkPjVur3jt8jGYUIB51mbbFaswpWph5SWfppcqO 2/vn4M4wG3eJBFjIf/bM47sLFwwdet9sk9/FMgRDAzf/btgGpo7yeZAPGMd9QcpZHzK+ Mv7g== X-Received: by 10.220.154.199 with SMTP id p7mr27561544vcw.46.1364481207899; Thu, 28 Mar 2013 07:33:27 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.59.4.204 with SMTP id cg12csp18275ved; Thu, 28 Mar 2013 07:33:27 -0700 (PDT) X-Received: by 10.180.73.229 with SMTP id o5mr16639161wiv.8.1364481206797; Thu, 28 Mar 2013 07:33:26 -0700 (PDT) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id m16si3857347wij.26.2013.03.28.07.33.26 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 Mar 2013 07:33:26 -0700 (PDT) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Authentication-Results: mx.google.com; spf=neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1ULDtM-000350-Ax; Thu, 28 Mar 2013 14:33:24 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, qemu-trivial@nongnu.org, Riku Voipio Subject: [PATCH] linux-user: Don't omit comma for strace of rt_sigaction() Date: Thu, 28 Mar 2013 14:33:24 +0000 Message-Id: <1364481204-11815-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 X-Gm-Message-State: ALoCoQlStU1P+Cqh24WOH9oT5ztMxjhNs8LsQKHRipc34Jn2d9cFmQ5aHd3Tr5/GZlcufLK3J+CH Pass the 'last' parameter of print_signal() through to print_raw_param(); this fixes a problem where we weren't printing the comma separator for strace of rt_sigaction() when the signal was an unnamed (ie realtime) one: 6856 rt_sigaction(230xf6fff870,0xf6fff8fc) = 0 Signed-off-by: Peter Maydell --- linux-user/strace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 0fbae3c..ea6c1d2 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -143,7 +143,7 @@ print_signal(abi_ulong arg, int last) case TARGET_SIGTTOU: signal_name = "SIGTTOU"; break; } if (signal_name == NULL) { - print_raw_param("%ld", arg, 1); + print_raw_param("%ld", arg, last); return; } gemu_log("%s%s", signal_name, get_comma(last));