From patchwork Fri Mar 14 18:22:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 26281 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C0A30202DD for ; Fri, 14 Mar 2014 18:25:02 +0000 (UTC) Received: by mail-ob0-f199.google.com with SMTP id wo20sf10701490obc.2 for ; Fri, 14 Mar 2014 11:25:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=wRnwjkBpEoN9pAkSzuDFIcMhl6zmInAxzTO7LH9hH0Y=; b=UmvZuATgdOk5IPF4+tyxtq3hdKYnnNThgjogI1FVIc91CNEyV5op7E7yk7cJoXSa/h GrpdWPhcfaaBcu3GOpMabMiboDmCZTquG61Rezfv/5f14hZ9mvCr/zvePJySStxRetU6 HcDGiJwokr1P/FPfbQHJNXoB9cXDbYeQOkc8zDUi8W2Vnml+1D3cJwRwrNN47b+mK98v XTGz9O6k+LVVSoDSP13FMJoDJWZGyjhO0t8ey+9K63hkzeYUDxiEE8AglyOzdKR4Ijwp 6yXka4GGpQdduhaG+qmRFHO80fM4beoZP7moTdK/ri2q3VNpoNQ5pskJSoRoscx+Y7kq hPXA== X-Gm-Message-State: ALoCoQmIiMb99/qsuNYsoQq/ZMkwxGErhRmF0x89mMDbZsjljtGRT5KLYtZEUpFsuzyYPGXacMMP X-Received: by 10.182.153.68 with SMTP id ve4mr3866575obb.39.1394821501556; Fri, 14 Mar 2014 11:25:01 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.109.137 with SMTP id l9ls817886qgf.40.gmail; Fri, 14 Mar 2014 11:25:01 -0700 (PDT) X-Received: by 10.58.248.228 with SMTP id yp4mr1131752vec.35.1394821501482; Fri, 14 Mar 2014 11:25:01 -0700 (PDT) Received: from mail-vc0-x22d.google.com (mail-vc0-x22d.google.com [2607:f8b0:400c:c03::22d]) by mx.google.com with ESMTPS id h11si786790veh.50.2014.03.14.11.25.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Mar 2014 11:25:01 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c03::22d is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c03::22d; Received: by mail-vc0-f173.google.com with SMTP id il7so3155749vcb.18 for ; Fri, 14 Mar 2014 11:25:01 -0700 (PDT) X-Received: by 10.58.243.72 with SMTP id ww8mr64591vec.49.1394821501380; Fri, 14 Mar 2014 11:25:01 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp42444vck; Fri, 14 Mar 2014 11:25:01 -0700 (PDT) X-Received: by 10.229.134.198 with SMTP id k6mr11188940qct.13.1394821501028; Fri, 14 Mar 2014 11:25:01 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v4si3869764qap.183.2014.03.14.11.25.00 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 14 Mar 2014 11:25:01 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:46437 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOWmy-0007kv-Jz for patch@linaro.org; Fri, 14 Mar 2014 14:25:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOWkv-0003Iu-OH for qemu-devel@nongnu.org; Fri, 14 Mar 2014 14:22:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOWko-0004ks-9r for qemu-devel@nongnu.org; Fri, 14 Mar 2014 14:22:53 -0400 Received: from mail-ob0-x232.google.com ([2607:f8b0:4003:c01::232]:51252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOWko-0004kk-5B for qemu-devel@nongnu.org; Fri, 14 Mar 2014 14:22:46 -0400 Received: by mail-ob0-f178.google.com with SMTP id wp18so2970139obc.9 for ; Fri, 14 Mar 2014 11:22:45 -0700 (PDT) X-Received: by 10.60.246.165 with SMTP id xx5mr2206904oec.84.1394821365606; Fri, 14 Mar 2014 11:22:45 -0700 (PDT) Received: from localhost.localdomain (72-48-77-163.dyn.grandenetworks.net. [72.48.77.163]) by mx.google.com with ESMTPSA id oz15sm10829740oeb.13.2014.03.14.11.22.44 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Mar 2014 11:22:45 -0700 (PDT) From: Rob Herring To: qemu-devel@nongnu.org, Peter Maydell Date: Fri, 14 Mar 2014 13:22:31 -0500 Message-Id: <1394821351-21477-5-git-send-email-robherring2@gmail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1394821351-21477-1-git-send-email-robherring2@gmail.com> References: <1394821351-21477-1-git-send-email-robherring2@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::232 Cc: Rob Herring Subject: [Qemu-devel] [PATCH v2 4/4] pl011: re-evaluate rx interrupt when fifo trigger changes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Original-Sender: robherring2@gmail.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c03::22d is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=fail header.i=@gmail.com; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Rob Herring When setting the fifo trigger level, the rx interrupt needs to be asserted if the current fifo level matches. This is more for correctness as the level is currently never changed. Signed-off-by: Rob Herring --- hw/char/pl011.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 5e664f4..3903933 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -131,6 +131,10 @@ static void pl011_set_read_trigger(PL011State *s) else #endif s->read_trigger = 1; + + if (s->read_count == s->read_trigger) { + s->int_level |= PL011_INT_RX; + } } static void pl011_write(void *opaque, hwaddr offset,