From patchwork Mon Mar 24 17:18:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 26940 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EAC2220062 for ; Mon, 24 Mar 2014 17:27:54 +0000 (UTC) Received: by mail-pa0-f71.google.com with SMTP id kq14sf15405106pab.6 for ; Mon, 24 Mar 2014 10:27:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=iA7hyL7DAb4V2coMrba1wjzE1ZrrU6vXj+mdKK0oj5Y=; b=FDoYrMrog8oBNafM0gncMqxlkpTQGfTkASg5YTlTd8O6YwDv/1K0aGPfZkFomuKJ25 yhDtL4g0UPk5TGXEAgJaF/H1sdFsDn1AYvQwR6lvTh1Tu6/rzsUYsHGs62nqwr+1WHBP quBHzdLGDnV5X6cuohFrkma9kSrPtl+kRbONs38JBtMyXZUXa8xuW5dCEppxquPOA16i hv11ZIFeyXgLbGOALP8MJ3upO4OGqyr0kl7WuFuQMglavXmYDSeuj9jQjb8c1VRFtLCD xuukXHZAgYyIz482n2D0Sb/nQahxJBMQCXC9wFflicXXo31VNg7Rl8S9+W9Y3Zttkevu wvkA== X-Gm-Message-State: ALoCoQmm8PwR68sYzeleBzoipj5t2XsuCPbGm7eXfBG3+ikJBQRvBT9a/zhPJsrXGXLxv1CnmgaM X-Received: by 10.66.145.105 with SMTP id st9mr29419698pab.23.1395682074232; Mon, 24 Mar 2014 10:27:54 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.22.75 with SMTP id 69ls1824194qgm.94.gmail; Mon, 24 Mar 2014 10:27:54 -0700 (PDT) X-Received: by 10.221.61.210 with SMTP id wx18mr1875010vcb.27.1395682074072; Mon, 24 Mar 2014 10:27:54 -0700 (PDT) Received: from mail-ve0-f179.google.com (mail-ve0-f179.google.com [209.85.128.179]) by mx.google.com with ESMTPS id tg3si3163385vec.195.2014.03.24.10.27.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Mar 2014 10:27:54 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.179; Received: by mail-ve0-f179.google.com with SMTP id db12so6032555veb.38 for ; Mon, 24 Mar 2014 10:27:54 -0700 (PDT) X-Received: by 10.52.139.237 with SMTP id rb13mr1600090vdb.33.1395682073950; Mon, 24 Mar 2014 10:27:53 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp240388vck; Mon, 24 Mar 2014 10:27:53 -0700 (PDT) X-Received: by 10.140.31.137 with SMTP id f9mr35040397qgf.52.1395682073255; Mon, 24 Mar 2014 10:27:53 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v9si6227304qap.110.2014.03.24.10.27.23 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 24 Mar 2014 10:27:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:37694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS8eg-0002fq-MK for patch@linaro.org; Mon, 24 Mar 2014 13:27:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS8eG-0002O6-Qi for qemu-devel@nongnu.org; Mon, 24 Mar 2014 13:26:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS8eF-0006hE-Sv for qemu-devel@nongnu.org; Mon, 24 Mar 2014 13:26:56 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:47142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS8eF-0006h9-Lf for qemu-devel@nongnu.org; Mon, 24 Mar 2014 13:26:55 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WS8Vl-0007jD-9V; Mon, 24 Mar 2014 17:18:09 +0000 From: Peter Maydell To: Anthony Liguori Date: Mon, 24 Mar 2014 17:18:08 +0000 Message-Id: <1395681489-29679-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395681489-29679-1-git-send-email-peter.maydell@linaro.org> References: <1395681489-29679-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: Blue Swirl , qemu-devel@nongnu.org, Aurelien Jarno Subject: [Qemu-devel] [PULL 1/2] target-arm: Fix A64 Neon MLS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The order of operands for the accumulate step in disas_simd_3same_int() was reversed. This only affected the MLS instruction, since all the other accumulating instructions in this category perform an addition rather than a subtraction. Reported-by: Laurent Desnogues Tested-by: Laurent Desnogues Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 9f06450..9175e48 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -8925,7 +8925,7 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) genfn = fns[size][is_sub]; read_vec_element_i32(s, tcg_op1, rd, pass, MO_32); - genfn(tcg_res, tcg_res, tcg_op1); + genfn(tcg_res, tcg_op1, tcg_res); } write_vec_element_i32(s, tcg_res, rd, pass, MO_32);