From patchwork Thu Mar 27 15:28:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 27210 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f69.google.com (mail-qa0-f69.google.com [209.85.216.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 15119202FA for ; Thu, 27 Mar 2014 15:39:04 +0000 (UTC) Received: by mail-qa0-f69.google.com with SMTP id w5sf7138923qac.8 for ; Thu, 27 Mar 2014 08:39:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=Y3qmxGSKZVlEajN4Yx8jXFvfCTkxWxk2NTcpxF4M3Y4=; b=X7Da3c1AI/XJbvMizCz7HWHM4kD5SFrulUisboM7Wwl2+asJDTDwJdkec5BJEAhbRf 3yQpXkTIFn2Hm5gpjBCwWJMniZvVAUmuNOCuyhKRWxr5gpqhjChkI2OuM7RAyzrbArAR 9z/FdSDiaBidXEUcALLX9eG3FSOt0pcB6EVSShmNp8uOTt9QmZaDuJ423g2ICSAF5CuN ZFJWzrEiqV1SAPeLw+9e95B9KzEpRmYtr/N7Vsn0h4t8W0ZCgZV1e46GYeg6Bi7JYUGo H0RLNXn5hLaanARXuGj9RhXEgyd7pPERuMj9Sp4xoMn/rNiAI1PBia+1MfgauMTmSt7e L3Gw== X-Gm-Message-State: ALoCoQn997tRKhRIozH01ZYM8CrB/7oOivDirdKVc3catV6eyb172HB++70PdJ/bc9dAyiOvLgdc X-Received: by 10.58.253.72 with SMTP id zy8mr937962vec.10.1395934743779; Thu, 27 Mar 2014 08:39:03 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.30.67 with SMTP id c61ls373932qgc.33.gmail; Thu, 27 Mar 2014 08:39:03 -0700 (PDT) X-Received: by 10.221.74.65 with SMTP id yv1mr1440425vcb.31.1395934743388; Thu, 27 Mar 2014 08:39:03 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id wy9si623391vdc.145.2014.03.27.08.39.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Mar 2014 08:39:03 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id ld13so4332476vcb.19 for ; Thu, 27 Mar 2014 08:39:03 -0700 (PDT) X-Received: by 10.221.34.7 with SMTP id sq7mr1999226vcb.5.1395934743291; Thu, 27 Mar 2014 08:39:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp37935vck; Thu, 27 Mar 2014 08:39:03 -0700 (PDT) X-Received: by 10.229.81.71 with SMTP id w7mr3050572qck.8.1395934742581; Thu, 27 Mar 2014 08:39:02 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v9si1189772qar.128.2014.03.27.08.39.02 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 27 Mar 2014 08:39:02 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:54388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTCOT-00013t-Re for patch@linaro.org; Thu, 27 Mar 2014 11:39:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTCNf-00006t-KR for qemu-devel@nongnu.org; Thu, 27 Mar 2014 11:38:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTCNX-0006GZ-M4 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 11:38:11 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:33979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTCNX-0006G6-FF; Thu, 27 Mar 2014 11:38:03 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 2FD0443726; Thu, 27 Mar 2014 19:38:02 +0400 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.corpit.ru (Postfix) with SMTP id DBCAE68D; Thu, 27 Mar 2014 19:28:35 +0400 (MSK) Received: (nullmailer pid 1790 invoked by uid 1000); Thu, 27 Mar 2014 15:28:30 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Date: Thu, 27 Mar 2014 19:28:17 +0400 Message-Id: <1395934108-1694-13-git-send-email-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395934108-1694-1-git-send-email-mjt@msgid.tls.msk.ru> References: <1395934108-1694-1-git-send-email-mjt@msgid.tls.msk.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Peter Maydell , Michael Tokarev Subject: [Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mjt@tls.msk.ru X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Peter Maydell Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael Tokarev --- hw/pci/pci_host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index 77c7d1f..3e26f92 100644 --- a/hw/pci/pci_host.c +++ b/hw/pci/pci_host.c @@ -142,8 +142,9 @@ static uint64_t pci_host_data_read(void *opaque, { PCIHostState *s = opaque; uint32_t val; - if (!(s->config_reg & (1 << 31))) + if (!(s->config_reg & (1U << 31))) { return 0xffffffff; + } val = pci_data_read(s->bus, s->config_reg | (addr & 3), len); PCI_DPRINTF("read addr " TARGET_FMT_plx " len %d val %x\n", addr, len, val);