From patchwork Fri Mar 28 16:10:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 27344 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f70.google.com (mail-qg0-f70.google.com [209.85.192.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4DBA520545 for ; Fri, 28 Mar 2014 16:27:15 +0000 (UTC) Received: by mail-qg0-f70.google.com with SMTP id z60sf6157093qgd.5 for ; Fri, 28 Mar 2014 09:27:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=upw3F/+sOcPYqB4G0r+JejfQwaeoTbpnvSBGhQd0RKY=; b=krWO648l7YM4hxiUyJbjKOoO8qz4ount+hTTs1kmQFalfzh2z9SNwlf5F4/rKdKY8i AznLEjjEUmRxfNohBBURVE54w/yHB7qsZJtFq/eXVv03/gs7Tw7BeTS19LYL/82o9WGn k5YeJY1CZcULuPiI6AH8GPF+z9iJnDfFInf3BcGnWQ6wkabmWwiZD1sT1xcDZqAeO0lE //syRuvtW4YRcySts0+xnQg75hpywPHerulOOmp3/n68EDXWot1UB7P6ejzdoTj5fGyn sCNjS2BgKxj+NHaIwYqKP9xmGH+mMxMvNR7LxdV1kGc2blVgTbzJCPsjXQrtBF8M2t5C 3iww== X-Gm-Message-State: ALoCoQnSi3BbSh11IwQJcQ4c3wuz4pDTNdsbL6iiJbwy1NYMZrJvlLyN7bznxvO3Uw6bMUnDKbr0 X-Received: by 10.236.93.38 with SMTP id k26mr3133326yhf.20.1396024035031; Fri, 28 Mar 2014 09:27:15 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.38.177 with SMTP id t46ls844981qgt.16.gmail; Fri, 28 Mar 2014 09:27:14 -0700 (PDT) X-Received: by 10.58.4.68 with SMTP id i4mr8021689vei.8.1396024034914; Fri, 28 Mar 2014 09:27:14 -0700 (PDT) Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by mx.google.com with ESMTPS id tz5si1326864vdc.115.2014.03.28.09.27.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Mar 2014 09:27:14 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.176; Received: by mail-vc0-f176.google.com with SMTP id lc6so5938877vcb.7 for ; Fri, 28 Mar 2014 09:27:14 -0700 (PDT) X-Received: by 10.52.119.197 with SMTP id kw5mr6594458vdb.5.1396024034832; Fri, 28 Mar 2014 09:27:14 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.12.8 with SMTP id v8csp21794vcv; Fri, 28 Mar 2014 09:27:14 -0700 (PDT) X-Received: by 10.15.51.141 with SMTP id n13mr10453840eew.17.1396024025622; Fri, 28 Mar 2014 09:27:05 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id x47si9168783eel.43.2014.03.28.09.27.03 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 28 Mar 2014 09:27:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::1 as permitted sender) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WTZMQ-0000cl-2I; Fri, 28 Mar 2014 16:10:26 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Alexander Graf , Michael Matz , Dirk Mueller , Laurent Desnogues , kvmarm@lists.cs.columbia.edu, Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Christoffer Dall , Will Newton , Peter Crosthwaite Subject: [PATCH v5 27/37] target-arm: Remove THUMB2EE feature from AArch64 'any' CPU Date: Fri, 28 Mar 2014 16:10:14 +0000 Message-Id: <1396023024-2262-28-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1396023024-2262-1-git-send-email-peter.maydell@linaro.org> References: <1396023024-2262-1-git-send-email-peter.maydell@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The AArch64 usermode 'any' CPU type was accidentally specified with the ARM_FEATURE_THUMB2EE bit set. This is incorrect since ARMv8 removes Thumb2EE completely. Since we never implemented Thumb2EE anyway having the feature bit set was fairly harmless for user-mode, but the correct thing is to not set it at all. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- target-arm/cpu64.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 5be7d72..b8b4fa6 100644 --- a/target-arm/cpu64.c +++ b/target-arm/cpu64.c @@ -83,7 +83,6 @@ static void aarch64_any_initfn(Object *obj) set_feature(&cpu->env, ARM_FEATURE_VFP4); set_feature(&cpu->env, ARM_FEATURE_VFP_FP16); set_feature(&cpu->env, ARM_FEATURE_NEON); - set_feature(&cpu->env, ARM_FEATURE_THUMB2EE); set_feature(&cpu->env, ARM_FEATURE_ARM_DIV); set_feature(&cpu->env, ARM_FEATURE_V7MP); set_feature(&cpu->env, ARM_FEATURE_AARCH64);