From patchwork Tue Apr 8 07:04:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 27929 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f200.google.com (mail-ie0-f200.google.com [209.85.223.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9263720553 for ; Tue, 8 Apr 2014 07:43:25 +0000 (UTC) Received: by mail-ie0-f200.google.com with SMTP id lx4sf2571380iec.7 for ; Tue, 08 Apr 2014 00:43:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=BCwGOmmIsee7o7F2urvrgwYG+VlOH8hYoOeln1jBB7E=; b=kloLPbgKeOaH6MdHai9y5dmvAwtSC6ZJgX5cJd7567OT91kxpYWqN46CfO39pVHADy BEbsMWsvUor0bckUViJkYH6vDF7AH2055UmUqvWd3QH+wHSAC2WNKSOYV/QyE2dXJm36 3XxkxWgarPaHWltZLF2NkzOEwTR8NFt/b6bwNOx1RXoR8S6z1o4TZ+vmhwoApzZV8SVO ycvmDah8OG5qTq5QqZOHfFRrUjRFZT+bODoNf6ggz6k9Mglta9EMhJegK8uvKSik0FKQ nEXCJbzOVeLGBZmsULTuKz1fdiobNpgvLKXhvCS6wJp3ItBo4dELnZICVQ7dUqo6MiUU 2XYw== X-Gm-Message-State: ALoCoQkIwVrZJDazEHmq+8AgftIf6AKDYC2B7j1xEwgafTf4JCyMfcqgKkeArTstw8BSITD77VzO X-Received: by 10.42.107.146 with SMTP id d18mr928973icp.8.1396943004887; Tue, 08 Apr 2014 00:43:24 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.50.81 with SMTP id r75ls115729qga.71.gmail; Tue, 08 Apr 2014 00:43:24 -0700 (PDT) X-Received: by 10.58.31.136 with SMTP id a8mr1994922vei.20.1396943004725; Tue, 08 Apr 2014 00:43:24 -0700 (PDT) Received: from mail-ve0-f176.google.com (mail-ve0-f176.google.com [209.85.128.176]) by mx.google.com with ESMTPS id sk2si251608vcb.90.2014.04.08.00.43.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 00:43:24 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.176; Received: by mail-ve0-f176.google.com with SMTP id db11so430991veb.21 for ; Tue, 08 Apr 2014 00:43:24 -0700 (PDT) X-Received: by 10.221.20.199 with SMTP id qp7mr268734vcb.24.1396943004646; Tue, 08 Apr 2014 00:43:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp224441vcv; Tue, 8 Apr 2014 00:43:24 -0700 (PDT) X-Received: by 10.140.101.180 with SMTP id u49mr2255123qge.27.1396943004288; Tue, 08 Apr 2014 00:43:24 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id d8si502223qao.0.2014.04.08.00.43.24 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 08 Apr 2014 00:43:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:38412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXQ6e-0008SQ-HH for patch@linaro.org; Tue, 08 Apr 2014 03:06:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXQ5V-0007Yl-3m for qemu-devel@nongnu.org; Tue, 08 Apr 2014 03:05:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXQ5N-0001MO-C0 for qemu-devel@nongnu.org; Tue, 08 Apr 2014 03:04:53 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:38194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXQ5N-0001M0-4f; Tue, 08 Apr 2014 03:04:45 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id DBD8640E32; Tue, 8 Apr 2014 11:04:43 +0400 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.corpit.ru (Postfix) with SMTP id 09EFA6AB; Tue, 8 Apr 2014 11:04:13 +0400 (MSK) Received: (nullmailer pid 10574 invoked by uid 1000); Tue, 08 Apr 2014 07:04:12 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Date: Tue, 8 Apr 2014 11:04:05 +0400 Message-Id: <1396940651-10513-6-git-send-email-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1396940651-10513-1-git-send-email-mjt@msgid.tls.msk.ru> References: <1396940651-10513-1-git-send-email-mjt@msgid.tls.msk.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Peter Maydell , Michael Tokarev Subject: [Qemu-devel] [PULL 05/11] hw/ide/ahci.c: Avoid shift left into sign bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mjt@tls.msk.ru X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Peter Maydell Add U suffix to avoid shifting left into the sign bit, which is undefined behaviour. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/ide/ahci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index bfe633f..50327ff 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -438,9 +438,9 @@ static void check_cmd(AHCIState *s, int port) if ((pr->cmd & PORT_CMD_START) && pr->cmd_issue) { for (slot = 0; (slot < 32) && pr->cmd_issue; slot++) { - if ((pr->cmd_issue & (1 << slot)) && + if ((pr->cmd_issue & (1U << slot)) && !handle_cmd(s, port, slot)) { - pr->cmd_issue &= ~(1 << slot); + pr->cmd_issue &= ~(1U << slot); } } }