From patchwork Thu Apr 10 16:15:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 28209 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f197.google.com (mail-ig0-f197.google.com [209.85.213.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3A8E321308 for ; Thu, 10 Apr 2014 16:16:03 +0000 (UTC) Received: by mail-ig0-f197.google.com with SMTP id hn18sf11044170igb.0 for ; Thu, 10 Apr 2014 09:16:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=68TkZTmufpiA7ccLel+jYuHNxO+osBaoqZFmBnqFLjY=; b=FzBVu5SSDaiFKHQF2ivdHKDYji+j1NFSVZvHLDCA+c0dWVTKwWc+NdgU9YyW7Z2P5t ta4/95QMkMr9oMk/R1UAKdY1hYLob6iaU9PFMONn2bGr96Y1XnKg1SXhA6tdxnEqawIH EHeiA/sot6DBl1OGcs/ijFS5MT6RKBwOMFQtzlG1YtPYp3i6woCd9rXMIdUESchmJrZc gkHD6u0TtsBUGJZkQmUxlh7LCCbdPIPM40sdN9Ja2z1SkYNq5sDJuDX8pz4nuTcGmBWv XCmEvEFZ/B38x6LTAL5FyL7YmNJS/M3csYrNv2JAwdrrgfb6uyIjzWhw6LaSUpXX/DfK uxYg== X-Gm-Message-State: ALoCoQnti7UCihDTko6EhGmQqrK57U4eF6Gi7baMTL32tuFc3aeT1x2jfxv3ejygKWPMjCAOqE+e X-Received: by 10.182.5.42 with SMTP id p10mr8731078obp.37.1397146562662; Thu, 10 Apr 2014 09:16:02 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.34.233 with SMTP id l96ls1188616qgl.90.gmail; Thu, 10 Apr 2014 09:16:02 -0700 (PDT) X-Received: by 10.58.134.101 with SMTP id pj5mr629792veb.38.1397146562543; Thu, 10 Apr 2014 09:16:02 -0700 (PDT) Received: from mail-ve0-f177.google.com (mail-ve0-f177.google.com [209.85.128.177]) by mx.google.com with ESMTPS id sc7si771856vdc.139.2014.04.10.09.16.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 10 Apr 2014 09:16:02 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.177; Received: by mail-ve0-f177.google.com with SMTP id sa20so3539770veb.22 for ; Thu, 10 Apr 2014 09:16:02 -0700 (PDT) X-Received: by 10.58.186.71 with SMTP id fi7mr759831vec.32.1397146562470; Thu, 10 Apr 2014 09:16:02 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp72277vcb; Thu, 10 Apr 2014 09:16:02 -0700 (PDT) X-Received: by 10.15.34.197 with SMTP id e45mr1975385eev.112.1397146559011; Thu, 10 Apr 2014 09:15:59 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id n7si6637467eeu.229.2014.04.10.09.15.56 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 10 Apr 2014 09:15:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::1 as permitted sender) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WYHdZ-0007rx-Re; Thu, 10 Apr 2014 17:15:37 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Alexander Graf , Laurent Desnogues , kvmarm@lists.cs.columbia.edu, Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Christoffer Dall , Peter Crosthwaite , Greg Bellows Subject: [PATCH v6 27/37] target-arm: Remove THUMB2EE feature from AArch64 'any' CPU Date: Thu, 10 Apr 2014 17:15:26 +0100 Message-Id: <1397146536-30116-28-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1397146536-30116-1-git-send-email-peter.maydell@linaro.org> References: <1397146536-30116-1-git-send-email-peter.maydell@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The AArch64 usermode 'any' CPU type was accidentally specified with the ARM_FEATURE_THUMB2EE bit set. This is incorrect since ARMv8 removes Thumb2EE completely. Since we never implemented Thumb2EE anyway having the feature bit set was fairly harmless for user-mode, but the correct thing is to not set it at all. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- target-arm/cpu64.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 5be7d72..b8b4fa6 100644 --- a/target-arm/cpu64.c +++ b/target-arm/cpu64.c @@ -83,7 +83,6 @@ static void aarch64_any_initfn(Object *obj) set_feature(&cpu->env, ARM_FEATURE_VFP4); set_feature(&cpu->env, ARM_FEATURE_VFP_FP16); set_feature(&cpu->env, ARM_FEATURE_NEON); - set_feature(&cpu->env, ARM_FEATURE_THUMB2EE); set_feature(&cpu->env, ARM_FEATURE_ARM_DIV); set_feature(&cpu->env, ARM_FEATURE_V7MP); set_feature(&cpu->env, ARM_FEATURE_AARCH64);