From patchwork Thu Apr 17 10:33:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 28529 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A9B1E206A6 for ; Thu, 17 Apr 2014 10:50:37 +0000 (UTC) Received: by mail-ob0-f199.google.com with SMTP id gq1sf1285918obb.10 for ; Thu, 17 Apr 2014 03:50:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=S7gsVdyPUxloNPk87st3TOqQ2j1IaGyc136f2Az2UCc=; b=g+vBWehwuCnGjzv+2rGExZv04VJT2fBkfPiu4s9CIW8u4okIiQbnL/ICjVWhD0KDfe CNy7tvK6W3twY7k6rCDqHfmRyALMM1pmxrOmktozCZMucD02WmDc8j2ZxMcYZSldeT0p pQtUzMhw3fOjLIRSeHRpSbK/sZc7dLnqCzIDXzPxsFRWrx0zlRHauEujRv2cR6FFXlPK xOT1PtLibQF0H9GawOA3aA7X7FEwWojdv+9/6orWWxX3yl9mpZfU6+E3bIo9FUw7VEPx NXEIglzQvYubNCpp0klJOWSPpKDr0AEphU5aFcGvzgxNXOXO1O+NV2/VU5Zf/wtuxu2G rgwg== X-Gm-Message-State: ALoCoQlUU/kiiH3IWaWCtcItOzigNp5deXyuMSv2p2jeYzl8RPLqFyDTusPJ30YcvzEyNOqJaGxE X-Received: by 10.182.102.197 with SMTP id fq5mr6837440obb.8.1397731837227; Thu, 17 Apr 2014 03:50:37 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.83.115 with SMTP id i106ls1043835qgd.97.gmail; Thu, 17 Apr 2014 03:50:37 -0700 (PDT) X-Received: by 10.52.253.75 with SMTP id zy11mr6801261vdc.10.1397731837097; Thu, 17 Apr 2014 03:50:37 -0700 (PDT) Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by mx.google.com with ESMTPS id rn1si4392114vec.24.2014.04.17.03.50.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Apr 2014 03:50:37 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.170; Received: by mail-vc0-f170.google.com with SMTP id hu19so290430vcb.15 for ; Thu, 17 Apr 2014 03:50:37 -0700 (PDT) X-Received: by 10.58.38.166 with SMTP id h6mr6956879vek.22.1397731837022; Thu, 17 Apr 2014 03:50:37 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp24973vcb; Thu, 17 Apr 2014 03:50:36 -0700 (PDT) X-Received: by 10.140.32.139 with SMTP id h11mr15994369qgh.49.1397731836549; Thu, 17 Apr 2014 03:50:36 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id z89si5199337qgd.38.2014.04.17.03.50.36 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 17 Apr 2014 03:50:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:59417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wajgz-0002Pz-MX for patch@linaro.org; Thu, 17 Apr 2014 06:37:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Waje8-0007hc-Mg for qemu-devel@nongnu.org; Thu, 17 Apr 2014 06:34:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Waje7-0002SL-Vk for qemu-devel@nongnu.org; Thu, 17 Apr 2014 06:34:20 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:47842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Waje7-0002OB-Pl for qemu-devel@nongnu.org; Thu, 17 Apr 2014 06:34:19 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1Wajdx-00021i-9E for qemu-devel@nongnu.org; Thu, 17 Apr 2014 11:34:09 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 17 Apr 2014 11:33:53 +0100 Message-Id: <1397730846-7576-39-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1397730846-7576-1-git-send-email-peter.maydell@linaro.org> References: <1397730846-7576-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Subject: [Qemu-devel] [PULL 38/51] timer: cadence_ttc: Fix match register write logic X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Peter Crosthwaite This switch logic should not fall through. Fix. Signed-off-by: Peter Crosthwaite Message-id: 74147b4c017c904364955cc73107f90e6ac8ba74.1396326389.git.peter.crosthwaite@xilinx.com Signed-off-by: Peter Maydell --- hw/timer/cadence_ttc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/timer/cadence_ttc.c b/hw/timer/cadence_ttc.c index a279bce..28cb328 100644 --- a/hw/timer/cadence_ttc.c +++ b/hw/timer/cadence_ttc.c @@ -346,11 +346,13 @@ static void cadence_ttc_write(void *opaque, hwaddr offset, case 0x34: case 0x38: s->reg_match[0] = value & 0xffff; + break; case 0x3c: /* match register */ case 0x40: case 0x44: s->reg_match[1] = value & 0xffff; + break; case 0x48: /* match register */ case 0x4c: