From patchwork Sat Jun 7 20:11:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 31530 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f70.google.com (mail-yh0-f70.google.com [209.85.213.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D72C721134 for ; Sat, 7 Jun 2014 20:11:25 +0000 (UTC) Received: by mail-yh0-f70.google.com with SMTP id z6sf11743672yhz.1 for ; Sat, 07 Jun 2014 13:11:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=ALuq0QRHY98KlFZ1sM/vOPm4gA7/gvVqimVMajUu5kY=; b=WYYJ4c1AyJV1tkCSz4oh0diC0bUjoD7QRxAByhKj2xBChdJG47NWxKeQnstJpj/YRZ /CoMtNL/vwOraLkbWC7H/fRzvoZ4VNXtgLZDhkgSD1Og5QuRMYHLC1F6CBzMmAXosyV/ 0bQZAQAwSvFlg2AitvMaMKJ2nS2YGMKEJbx9jYh30stMXWddG/XAEIiT/McpkbX5cIXj ItNg8QRKp89rbXpaYGuWgPHeQ9OcGiHgv0w4yqGAvVOXv5VF4M3CpKB+Zg+MMdzu/sei m2PirNsrq/dQpnzHFwXpFKZjnCWBqtZAqt8xN6IMjodKwHTbOmiKXP/FEkvRqxKFQU/F Hyyw== X-Gm-Message-State: ALoCoQmx0FoR/voxHbJWE9eKJGOYco0J6hbdtKYpWdBw+ZtpEfffgLkz7wvJhYvl8xZ1jVhsEVHt X-Received: by 10.52.113.226 with SMTP id jb2mr6727276vdb.6.1402171885693; Sat, 07 Jun 2014 13:11:25 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.97.200 with SMTP id m66ls1045345qge.83.gmail; Sat, 07 Jun 2014 13:11:25 -0700 (PDT) X-Received: by 10.220.105.136 with SMTP id t8mr3071072vco.13.1402171885599; Sat, 07 Jun 2014 13:11:25 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id b8si8227474vcf.7.2014.06.07.13.11.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 07 Jun 2014 13:11:25 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id id10so3017128vcb.2 for ; Sat, 07 Jun 2014 13:11:25 -0700 (PDT) X-Received: by 10.52.76.33 with SMTP id h1mr12732125vdw.45.1402171885497; Sat, 07 Jun 2014 13:11:25 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp36816vcb; Sat, 7 Jun 2014 13:11:25 -0700 (PDT) X-Received: by 10.68.130.38 with SMTP id ob6mr1840891pbb.141.1402171884545; Sat, 07 Jun 2014 13:11:24 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id ff3si26627732pbd.167.2014.06.07.13.11.23 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 07 Jun 2014 13:11:24 -0700 (PDT) Received-SPF: none (google.com: pm215@archaic.org.uk does not designate permitted sender hosts) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WtMxV-0003jv-7K; Sat, 07 Jun 2014 21:11:21 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org Subject: [PATCH 2/3] target-arm/translate-a64.c: Remove dead ?: in disas_simd_3same_int() Date: Sat, 7 Jun 2014 21:11:20 +0100 Message-Id: <1402171881-14343-3-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1402171881-14343-1-git-send-email-peter.maydell@linaro.org> References: <1402171881-14343-1-git-send-email-peter.maydell@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , In disas_simd_3same_int(), none of the instructions permit is_q to be false with size == 3 (this would be a vector operation with a one-element vector, and the instruction set encodes those as scalar operations). Replace the always-true ?: check with an assert. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- target-arm/translate-a64.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 9f964df..4c9e237 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -8997,7 +8997,8 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) } if (size == 3) { - for (pass = 0; pass < (is_q ? 2 : 1); pass++) { + assert(is_q); + for (pass = 0; pass < 2; pass++) { TCGv_i64 tcg_op1 = tcg_temp_new_i64(); TCGv_i64 tcg_op2 = tcg_temp_new_i64(); TCGv_i64 tcg_res = tcg_temp_new_i64();