From patchwork Sat Jun 7 20:11:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 31528 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f70.google.com (mail-yh0-f70.google.com [209.85.213.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EAA6820CBB for ; Sat, 7 Jun 2014 20:11:23 +0000 (UTC) Received: by mail-yh0-f70.google.com with SMTP id z6sf11692387yhz.5 for ; Sat, 07 Jun 2014 13:11:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=vwP+oXciGS1LPQtzG/a6h/ycvbRp6Z4ZPe6payR1ooM=; b=E1lN0wyXywMVU4butFcBgKqPFYuLRBydY0ktUi9wko4sypPTao/qWQ5MDRbiyAPq8s vsz3oGl91QTCgUP36a6t2aCfSPwbDpYaAIzf7d1t467a1hBU28gN2UbcsAXWe4aPdxos O6Cr8qDIrgrkWBoC2bqIad98PSe/yGdk6rKxju47GV+nZspUTvT7iOo72nncTkplG63W vn5QtziMTIDZGq+EFvTgUP9fNOKElrc0Y5TCNRj5FlkwjbA0ZB48PN5vuUBMiP07xYoP uxU3Zp6NHo7SgdLOsTnSXZ0v4SfhlIm4JjdR5sMyRiXhfIlhwu2pH45vTnh+b8WA/kWU U4yw== X-Gm-Message-State: ALoCoQn0ogVODL9IiHlmYMjUWZbre2LjMUhbYbojXLPxWpOdFR/cSUVRP2zssxIZo1qa+U/CUG84 X-Received: by 10.52.113.226 with SMTP id jb2mr6727162vdb.6.1402171883515; Sat, 07 Jun 2014 13:11:23 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.85.138 with SMTP id n10ls1194847qgd.4.gmail; Sat, 07 Jun 2014 13:11:23 -0700 (PDT) X-Received: by 10.58.245.2 with SMTP id xk2mr15351244vec.9.1402171883408; Sat, 07 Jun 2014 13:11:23 -0700 (PDT) Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by mx.google.com with ESMTPS id r6si9471019vdc.10.2014.06.07.13.11.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 07 Jun 2014 13:11:23 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) client-ip=209.85.220.170; Received: by mail-vc0-f170.google.com with SMTP id hy10so461662vcb.1 for ; Sat, 07 Jun 2014 13:11:23 -0700 (PDT) X-Received: by 10.52.246.42 with SMTP id xt10mr12502726vdc.5.1402171883225; Sat, 07 Jun 2014 13:11:23 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp36813vcb; Sat, 7 Jun 2014 13:11:22 -0700 (PDT) X-Received: by 10.194.216.40 with SMTP id on8mr17965501wjc.66.1402171882410; Sat, 07 Jun 2014 13:11:22 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id yo8si23868317wjc.129.2014.06.07.13.11.21 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 07 Jun 2014 13:11:22 -0700 (PDT) Received-SPF: none (google.com: pm215@archaic.org.uk does not designate permitted sender hosts) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WtMxV-0003jz-8o; Sat, 07 Jun 2014 21:11:21 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org Subject: [PATCH 3/3] target-arm/translate-a64.c: Fix dead ?: in handle_simd_shift_fpint_conv() Date: Sat, 7 Jun 2014 21:11:21 +0100 Message-Id: <1402171881-14343-4-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1402171881-14343-1-git-send-email-peter.maydell@linaro.org> References: <1402171881-14343-1-git-send-email-peter.maydell@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , In handle_simd_shift_fpint_conv(), the combination of is_double == true, is_scalar == false and is_q == false is an unallocated encoding; the 'both parts false' case of the nested ?: expression for calculating maxpass is therefore unreachable and can be removed. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 4c9e237..5542d7d 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -6484,7 +6484,7 @@ static void handle_simd_shift_fpint_conv(DisasContext *s, bool is_scalar, tcg_shift = tcg_const_i32(fracbits); if (is_double) { - int maxpass = is_scalar ? 1 : is_q ? 2 : 1; + int maxpass = is_scalar ? 1 : 2; for (pass = 0; pass < maxpass; pass++) { TCGv_i64 tcg_op = tcg_temp_new_i64();