From patchwork Thu Jun 19 17:36:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 32235 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f72.google.com (mail-yh0-f72.google.com [209.85.213.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 70FF6203F4 for ; Thu, 19 Jun 2014 17:39:53 +0000 (UTC) Received: by mail-yh0-f72.google.com with SMTP id f10sf8917756yha.11 for ; Thu, 19 Jun 2014 10:39:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=Vk9iJEXEm9+UeSitPrFReSMKqfZHwi3Bh6UmLb6BoWY=; b=Jj8vtuh7cFmEhA6ZdnpN0T9RWbgsKeN6xH5xXRHbKSipqbjhBkSu3DZ1IfTd43L+mS 6CbGsXxR4Jxb3FvYVrUDK2DFHp0EKP0qwCBaWirPiHOwHvqGGkMVcVKuzinIPjPPcKsP UpjaHOMvze2YPDu5U61YRJJxJjTNhQzlehCnPpkcpejt9ZieYLDGKym854WQqOJGfaax VHqAPqN8Uprmemw+auRF/fM8C5VfS82iPi1XKiAKHV09wgCObvsJTpQnI02504BeSUIz pj85F5zYe2VRll9OK5MgMUBt5S3S9d3BiO4DsDSXh+bcVZK/5ozFT9l5qoGpraNZmNDb BkZg== X-Gm-Message-State: ALoCoQl1is8+NWPPgEW/BPopVd2xn64AaFz8Q52LYcOTdosJfQwfqPAJSfPwcB8tCIn6QKG49rdp X-Received: by 10.58.111.40 with SMTP id if8mr2943980veb.40.1403199593291; Thu, 19 Jun 2014 10:39:53 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.38.133 with SMTP id t5ls661176qgt.43.gmail; Thu, 19 Jun 2014 10:39:53 -0700 (PDT) X-Received: by 10.220.50.138 with SMTP id z10mr8789vcf.75.1403199593145; Thu, 19 Jun 2014 10:39:53 -0700 (PDT) Received: from mail-vc0-f177.google.com (mail-vc0-f177.google.com [209.85.220.177]) by mx.google.com with ESMTPS id b8si2740047vcf.7.2014.06.19.10.39.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Jun 2014 10:39:53 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.177 as permitted sender) client-ip=209.85.220.177; Received: by mail-vc0-f177.google.com with SMTP id ij19so2500014vcb.8 for ; Thu, 19 Jun 2014 10:39:53 -0700 (PDT) X-Received: by 10.52.88.44 with SMTP id bd12mr138296vdb.86.1403199593064; Thu, 19 Jun 2014 10:39:53 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp379127vcb; Thu, 19 Jun 2014 10:39:52 -0700 (PDT) X-Received: by 10.140.108.203 with SMTP id j69mr9266383qgf.56.1403199591762; Thu, 19 Jun 2014 10:39:51 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id dk2si7226709qcb.16.2014.06.19.10.39.51 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 19 Jun 2014 10:39:51 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:36968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxgJT-0004IW-Al for patch@linaro.org; Thu, 19 Jun 2014 13:39:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxgGu-0000yD-U5 for qemu-devel@nongnu.org; Thu, 19 Jun 2014 13:37:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxgGq-0004vB-Vv for qemu-devel@nongnu.org; Thu, 19 Jun 2014 13:37:12 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:48646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxgGq-0004k9-N7 for qemu-devel@nongnu.org; Thu, 19 Jun 2014 13:37:08 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WxgGf-0002JK-Pl for qemu-devel@nongnu.org; Thu, 19 Jun 2014 18:36:57 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 19 Jun 2014 18:36:48 +0100 Message-Id: <1403199417-8833-6-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1403199417-8833-1-git-send-email-peter.maydell@linaro.org> References: <1403199417-8833-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Subject: [Qemu-devel] [PULL 05/14] target-arm/translate-a64.c: Fix dead ?: in handle_simd_shift_fpint_conv() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.177 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 In handle_simd_shift_fpint_conv(), the combination of is_double == true, is_scalar == false and is_q == false is an unallocated encoding; the 'both parts false' case of the nested ?: expression for calculating maxpass is therefore unreachable and can be removed. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite Message-id: 1402171881-14343-4-git-send-email-peter.maydell@linaro.org --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index cbc8a35..33b5025 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -6539,7 +6539,7 @@ static void handle_simd_shift_fpint_conv(DisasContext *s, bool is_scalar, tcg_shift = tcg_const_i32(fracbits); if (is_double) { - int maxpass = is_scalar ? 1 : is_q ? 2 : 1; + int maxpass = is_scalar ? 1 : 2; for (pass = 0; pass < maxpass; pass++) { TCGv_i64 tcg_op = tcg_temp_new_i64();