From patchwork Mon Jun 23 23:10:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 32399 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f72.google.com (mail-qa0-f72.google.com [209.85.216.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2FD8223B18 for ; Mon, 23 Jun 2014 23:54:20 +0000 (UTC) Received: by mail-qa0-f72.google.com with SMTP id i13sf21231232qae.11 for ; Mon, 23 Jun 2014 16:54:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:cc:subject:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list; bh=g9wyBbD8UPd1WPkNBZYHj7+cx6OfvHn2YfkHpuG7vFk=; b=gA8xznY+s/o95XxKeXozfiUfG0MaiDcP/47r1vYlcOeddiHCpkRWxVmDoBVFgg4uWo zOeN+Z4Vk7rPCn1wn0s1RchDWssyYrPxSOB3BYfDTbyubfry5jWoMesyH05pnJw0t9gm DxndFT1WaripKAU3F11D1XZ0OwAHCiio7Zxo5kqP1rTsSuzuSSIQXWo+MhdT1yFwcjF6 N685qrZGjO1uF5QQX2cOiLffdUQRmU8NflYogNNndpOFbFKZBLbnEka7q6fEqnO+V3gQ UlctbpQQtQ+Kx9bhLWkuKsBU5WZfezTSYYbqraflD2/ealYy3uDAmvdMfHK7ZMbNdQqL ohfw== X-Gm-Message-State: ALoCoQmEdNMeoZhauPUkfJWQGcAjV/1QsyWi/Wy171Q+TwjV5oTeYOUx3Ypa4cnpeZ45FtIntoVW X-Received: by 10.224.13.67 with SMTP id b3mr11348700qaa.2.1403567660045; Mon, 23 Jun 2014 16:54:20 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.96.6 with SMTP id j6ls2155965qge.89.gmail; Mon, 23 Jun 2014 16:54:20 -0700 (PDT) X-Received: by 10.58.46.141 with SMTP id v13mr22016391vem.18.1403567659966; Mon, 23 Jun 2014 16:54:19 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id k3si9811847vcg.20.2014.06.23.16.54.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Jun 2014 16:54:19 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id id10so6937627vcb.30 for ; Mon, 23 Jun 2014 16:54:19 -0700 (PDT) X-Received: by 10.52.163.208 with SMTP id yk16mr6770631vdb.36.1403567659873; Mon, 23 Jun 2014 16:54:19 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp166376vcb; Mon, 23 Jun 2014 16:54:19 -0700 (PDT) X-Received: by 10.229.202.136 with SMTP id fe8mr37167116qcb.8.1403567658926; Mon, 23 Jun 2014 16:54:18 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id hl16si24592422qcb.1.2014.06.23.16.54.18 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 23 Jun 2014 16:54:18 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:56405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzDP5-0006x8-5F for patch@linaro.org; Mon, 23 Jun 2014 19:11:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzDNL-0004mq-IF for qemu-devel@nongnu.org; Mon, 23 Jun 2014 19:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzDNK-0002wc-JK for qemu-devel@nongnu.org; Mon, 23 Jun 2014 19:10:11 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:48707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzDNK-0002wO-DV; Mon, 23 Jun 2014 19:10:10 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WzDNJ-0004Bw-Kg; Tue, 24 Jun 2014 00:10:09 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 24 Jun 2014 00:10:09 +0100 Message-Id: <1403565009-16087-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: qemu-trivial@nongnu.org, Anthony Green Subject: [Qemu-devel] [PATCH] hw/moxie/moxiesim.c: Remove unused moxie_intc_create() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The function moxie_intc_create() is unused; remove it. Signed-off-by: Peter Maydell --- In any case the recommendation these days would be to do this kind of simple create-configure-init-wire-up inline in the machine model code... hw/moxie/moxiesim.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/hw/moxie/moxiesim.c b/hw/moxie/moxiesim.c index f4357cf..430f841 100644 --- a/hw/moxie/moxiesim.c +++ b/hw/moxie/moxiesim.c @@ -94,19 +94,6 @@ static void main_cpu_reset(void *opaque) cpu_reset(CPU(cpu)); } -static inline DeviceState * -moxie_intc_create(hwaddr base, qemu_irq irq, int kind_of_intr) -{ - DeviceState *dev; - - dev = qdev_create(NULL, "moxie,intc"); - qdev_prop_set_uint32(dev, "kind-of-intr", kind_of_intr); - qdev_init_nofail(dev); - sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base); - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, irq); - return dev; -} - static void moxiesim_init(MachineState *machine) { MoxieCPU *cpu = NULL;