From patchwork Tue Jul 22 16:19:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 34104 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f198.google.com (mail-ig0-f198.google.com [209.85.213.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 59A6B20672 for ; Tue, 22 Jul 2014 16:19:58 +0000 (UTC) Received: by mail-ig0-f198.google.com with SMTP id h18sf1474008igc.1 for ; Tue, 22 Jul 2014 09:19:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:cc:subject:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list; bh=39mn940wwHbUMR/EmkdYKKFokQp59ILRz3HzU/7DqbM=; b=AtbM2ce/sQgOkFKL6vgf9cg7/bvzxDFs82CD1qlGhrkPx1ZPHkHNISbaRN0cRL/9pi AUmI6kejXlQh9L7msfx0uV0YEP0p2H72o3xjR8vg8D8ZnYR+xz4WwigrgyzSAjlZfHnC lqcOu2ProgPTJ0OfPki+mZchlKBRVjtGsf4qrNK1vfv3zHdhrWBuOfkUxyydteod89m5 5+J+TsMpBAEWTl1LcyKV1d0uQ1c1pnrUbWqEgaMb51GbtktBhzQjKdTQTdaNivUEtjDH zoftrq5F5dbaKswG1rf3kGtEBnwf2S/F4/d+BXU0sMXF0eLisJq3ZK0kH6Uha0qIa9hA cuJA== X-Gm-Message-State: ALoCoQkRUbh0HaueVZMGqTTNIi4tY0Bv2m1h6TatlqoTG+JaLDDoFrZxHeMgpnfWf+4newvKHVeI X-Received: by 10.183.10.133 with SMTP id ea5mr17768073obd.24.1406045997801; Tue, 22 Jul 2014 09:19:57 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.37.6 with SMTP id q6ls606743qgq.49.gmail; Tue, 22 Jul 2014 09:19:57 -0700 (PDT) X-Received: by 10.52.249.9 with SMTP id yq9mr35599325vdc.6.1406045997546; Tue, 22 Jul 2014 09:19:57 -0700 (PDT) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id mx8si1545808vec.34.2014.07.22.09.19.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 09:19:57 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id la4so15311066vcb.37 for ; Tue, 22 Jul 2014 09:19:56 -0700 (PDT) X-Received: by 10.221.26.10 with SMTP id rk10mr41924245vcb.0.1406045996810; Tue, 22 Jul 2014 09:19:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp209137vcb; Tue, 22 Jul 2014 09:19:56 -0700 (PDT) X-Received: by 10.140.98.195 with SMTP id o61mr51600876qge.41.1406045996513; Tue, 22 Jul 2014 09:19:56 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x8si1538271qas.81.2014.07.22.09.19.56 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 22 Jul 2014 09:19:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:40168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9cnE-0001OA-36 for patch@linaro.org; Tue, 22 Jul 2014 12:19:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9cmk-000115-78 for qemu-devel@nongnu.org; Tue, 22 Jul 2014 12:19:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9cmj-0007ns-El for qemu-devel@nongnu.org; Tue, 22 Jul 2014 12:19:26 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:48859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9cmj-0007mD-7U for qemu-devel@nongnu.org; Tue, 22 Jul 2014 12:19:25 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1X9cmb-0002tw-Ed; Tue, 22 Jul 2014 17:19:17 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 22 Jul 2014 17:19:17 +0100 Message-Id: <1406045957-11127-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: Paolo Bonzini , qemu-stable@nongnu.org Subject: [Qemu-devel] [PATCH] hw/misc/imx_ccm.c: Add missing VMState list terminator X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The VMStateDescription for the imx_ccm device was missing its terminator. Found by static search of the codebase using a regex based on one suggested by Ian Jackson: pcregrep -rMi '(?s)VMStateField(?:(?!END_OF_LIST).)*?;' $(git grep -l 'VMStateField\[\]') Signed-off-by: Peter Maydell Cc: qemu-stable@nongnu.org --- Check prompted by Laszlo's recent patch, obviously. This plus hcd-xhci.c are the only missing-terminator cases I found. hw/misc/imx_ccm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/imx_ccm.c b/hw/misc/imx_ccm.c index 750b906..0920288 100644 --- a/hw/misc/imx_ccm.c +++ b/hw/misc/imx_ccm.c @@ -67,6 +67,7 @@ static const VMStateDescription vmstate_imx_ccm = { VMSTATE_UINT32(pmcr0, IMXCCMState), VMSTATE_UINT32(pmcr1, IMXCCMState), VMSTATE_UINT32(pll_refclk_freq, IMXCCMState), + VMSTATE_END_OF_LIST() }, .post_load = imx_ccm_post_load, };