From patchwork Tue Nov 4 10:41:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 40108 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F3C8D240A6 for ; Tue, 4 Nov 2014 10:42:29 +0000 (UTC) Received: by mail-la0-f70.google.com with SMTP id ge10sf447490lab.9 for ; Tue, 04 Nov 2014 02:42:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=m/+iZJYtgAh/TGn8egtuQv6o9XXisbVXbP/4HT5L+bw=; b=GwJtBsIbun6MdbEhh7mJ0l1v7eNFpQsBh9PpGtKMnmFxbSOepath7TQVdqUBBXyYBy c2UDDbNR4bwiQT7Yjh1ZxP6MC7UHeo65+G1RIn7CcN6OIUp6YQ/Fm9rliQXhMIjcSkep toqJXV9M3LvphwP1U99T6hA6GSQCCe8iCLClnFqrAj5j/tAxdIG8KorPVK8PiNSYVEl+ oA3ilEsAWTBz93nwvhy+/9cD69wK/Zte8MLiMkUg1kSbhjgP7MxyT89fPcAJGook99Fa B1QtT2q6mebmYn2nD3rVgiU7fvPuWjuhoX+jGDhNqGKOiBkDkQ/WKi6aCFPbBwlJBzU/ JCmQ== X-Gm-Message-State: ALoCoQlhHUaWO10o77AzaMSu6ss8Wf6P81gaWMJbbQuu4o8TXSsip5/m11hA7TkdDaTB0DHRtu+a X-Received: by 10.180.90.234 with SMTP id bz10mr1552591wib.0.1415097748960; Tue, 04 Nov 2014 02:42:28 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.10.2 with SMTP id e2ls754455lab.88.gmail; Tue, 04 Nov 2014 02:42:28 -0800 (PST) X-Received: by 10.152.36.165 with SMTP id r5mr27669021laj.91.1415097748772; Tue, 04 Nov 2014 02:42:28 -0800 (PST) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com. [209.85.217.169]) by mx.google.com with ESMTPS id h7si36899667lae.93.2014.11.04.02.42.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Nov 2014 02:42:28 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) client-ip=209.85.217.169; Received: by mail-lb0-f169.google.com with SMTP id 10so703554lbg.28 for ; Tue, 04 Nov 2014 02:42:28 -0800 (PST) X-Received: by 10.112.77.74 with SMTP id q10mr57668609lbw.66.1415097748610; Tue, 04 Nov 2014 02:42:28 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp94982lbc; Tue, 4 Nov 2014 02:42:27 -0800 (PST) X-Received: by 10.140.48.41 with SMTP id n38mr71071455qga.1.1415097747326; Tue, 04 Nov 2014 02:42:27 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id a7si114750qaj.13.2014.11.04.02.42.26 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 04 Nov 2014 02:42:27 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:39647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlbZC-0006wi-Bw for patch@linaro.org; Tue, 04 Nov 2014 05:42:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlbYG-00064O-Sj for qemu-devel@nongnu.org; Tue, 04 Nov 2014 05:41:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlbY7-000219-Mf for qemu-devel@nongnu.org; Tue, 04 Nov 2014 05:41:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlbY7-00020o-Es for qemu-devel@nongnu.org; Tue, 04 Nov 2014 05:41:19 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA4AfH4a019337 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 4 Nov 2014 05:41:17 -0500 Received: from nilsson.home.kraxel.org (ovpn-116-42.ams2.redhat.com [10.36.116.42]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sA4AfGhY032436; Tue, 4 Nov 2014 05:41:17 -0500 Received: by nilsson.home.kraxel.org (Postfix, from userid 500) id 2127581BBA; Tue, 4 Nov 2014 11:41:16 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Tue, 4 Nov 2014 11:41:10 +0100 Message-Id: <1415097671-15343-5-git-send-email-kraxel@redhat.com> In-Reply-To: <1415097671-15343-1-git-send-email-kraxel@redhat.com> References: <1415097671-15343-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Gerd Hoffmann , Anthony Liguori , Cole Robinson Subject: [Qemu-devel] [PULL 4/5] gtk: Hide the menubar when in fullscreen mode (lp 1294898) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: kraxel@redhat.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Cole Robinson In fullscreen mode, we attempt to shrink the menubar to 1 pixel in height, so it takes up as little room as possible while still allowing us to use the keyboard shortcuts for its various operations. However this shrinking is disregarded on gtk3, so the entire menu bar is visible, which isn't very pleasant. This patch hides the menu bar instead. The side effect is that the only keyboard shortcuts that will work in this mode are the ones that we explicitly register on the top level window and not the menu bar. The previous patches changed the fullscreen and vc shortcuts to work like that, which I think are the only ones that really matter in for the fullscreen case. https://bugs.launchpad.net/qemu/+bug/1294898 Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 552a73b..de564cc 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1104,7 +1104,7 @@ static void gd_menu_full_screen(GtkMenuItem *item, void *opaque) if (!s->full_screen) { gtk_notebook_set_show_tabs(GTK_NOTEBOOK(s->notebook), FALSE); - gtk_widget_set_size_request(s->menu_bar, 0, 0); + gtk_widget_hide(s->menu_bar); if (vc->type == GD_VC_GFX) { gtk_widget_set_size_request(vc->gfx.drawing_area, -1, -1); gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item), @@ -1115,7 +1115,7 @@ static void gd_menu_full_screen(GtkMenuItem *item, void *opaque) } else { gtk_window_unfullscreen(GTK_WINDOW(s->window)); gd_menu_show_tabs(GTK_MENU_ITEM(s->show_tabs_item), s); - gtk_widget_set_size_request(s->menu_bar, -1, -1); + gtk_widget_show(s->menu_bar); s->full_screen = FALSE; if (vc->type == GD_VC_GFX) { vc->gfx.scale_x = 1.0;