From patchwork Thu May 28 12:08:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Zhao X-Patchwork-Id: 49094 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C3FF0218EC for ; Thu, 28 May 2015 12:32:05 +0000 (UTC) Received: by wixv7 with SMTP id v7sf13445198wix.0 for ; Thu, 28 May 2015 05:32:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:content-type:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=BTb+YdL25UdqkwbJlm6wmR4pwL5EL0G/MwhY9/JJlAE=; b=EKAhA5T7zergJTNMEU6p5W07Fcgpa3BDMOKi4TTMjQRoU3SOQFiNHoY+tKNYp31P53 XnImccU1oa3gXo/RJVCSf7LHlyH767oUL4/ARJYdXrhKTUoXyKQSEeSsoJlc89VSYRBv HTOQq+uI+LtXcXKI+E9Ot7gsGeby8M9mpJmflbLXIkdOR4WC7mWPQrKMdzaDjf4bXp5d 2wX8rnB8w9WEZ7hOjUCW7udl6DhlD4YIWXDwb/T0c2ytmLCEqceYEKP5pnly2sWcRraP nP563Asgtbhytj7oZ3GplO+3llprpl+HxBm523R5azeAArJGiwJkZ6rdbrSpQc/uGt1Y uwJg== X-Gm-Message-State: ALoCoQldWX3N+o23QYZYk2/xL5UAV+qUseij0b1nwnd1V8bSIrzQftTCYdscMhcnVSypSOnrry55 X-Received: by 10.152.4.230 with SMTP id n6mr2534347lan.2.1432816324933; Thu, 28 May 2015 05:32:04 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.153.5.42 with SMTP id cj10ls183695lad.51.gmail; Thu, 28 May 2015 05:32:04 -0700 (PDT) X-Received: by 10.112.202.234 with SMTP id kl10mr2499217lbc.51.1432816324817; Thu, 28 May 2015 05:32:04 -0700 (PDT) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com. [209.85.217.182]) by mx.google.com with ESMTPS id uq2si1825541lbc.120.2015.05.28.05.32.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 05:32:04 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) client-ip=209.85.217.182; Received: by lbcue7 with SMTP id ue7so27143411lbc.0 for ; Thu, 28 May 2015 05:32:04 -0700 (PDT) X-Received: by 10.152.87.204 with SMTP id ba12mr2578641lab.35.1432816324393; Thu, 28 May 2015 05:32:04 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1120723lbb; Thu, 28 May 2015 05:32:03 -0700 (PDT) X-Received: by 10.55.23.130 with SMTP id 2mr4464162qkx.33.1432816323148; Thu, 28 May 2015 05:32:03 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id e145si2184087qhc.95.2015.05.28.05.32.02 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 May 2015 05:32:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:58542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwyg-0000Hz-7Q for patch@linaro.org; Thu, 28 May 2015 08:32:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxwgM-0006F1-Ft for qemu-devel@nongnu.org; Thu, 28 May 2015 08:13:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxwgI-0004aU-AU for qemu-devel@nongnu.org; Thu, 28 May 2015 08:13:06 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:42940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxwgG-0004Zu-QV; Thu, 28 May 2015 08:13:02 -0400 Received: from 172.24.2.119 (EHLO SZXEML429-HUB.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CMA92693; Thu, 28 May 2015 20:12:34 +0800 (CST) Received: from HGHY1Z002260041.china.huawei.com (10.177.16.142) by SZXEML429-HUB.china.huawei.com (10.82.67.184) with Microsoft SMTP Server id 14.3.158.1; Thu, 28 May 2015 20:10:23 +0800 From: Shannon Zhao To: Date: Thu, 28 May 2015 20:08:51 +0800 Message-ID: <1432814932-12608-29-git-send-email-zhaoshenglong@huawei.com> X-Mailer: git-send-email 1.9.0.msysgit.0 In-Reply-To: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> References: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 119.145.14.65 Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, mjt@tls.msk.ru, shannon.zhao@linaro.org, peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH 28/29] hw/display/tc6393xb.c: Fix memory leak spotted by valgrind X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Shannon Zhao valgrind complains about: ==3169== 8 bytes in 1 blocks are definitely lost in loss record 424 of 2,779 ==3169== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==3169== by 0x3547D3: malloc_and_trace (vl.c:2556) ==3169== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3) ==3169== by 0x3ED9CF: qemu_extend_irqs (irq.c:55) ==3169== by 0x3EDA5B: qemu_allocate_irqs (irq.c:64) ==3169== by 0x426F74: tc6393xb_init (tc6393xb.c:574) ==3169== by 0x28B7B4: tosa_init (tosa.c:235) ==3169== by 0x358B9E: main (vl.c:4249) Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/display/tc6393xb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/tc6393xb.c b/hw/display/tc6393xb.c index 66b7ade..f5f3f3e 100644 --- a/hw/display/tc6393xb.c +++ b/hw/display/tc6393xb.c @@ -571,7 +571,7 @@ TC6393xbState *tc6393xb_init(MemoryRegion *sysmem, uint32_t base, qemu_irq irq) s->irq = irq; s->gpio_in = qemu_allocate_irqs(tc6393xb_gpio_set, s, TC6393XB_GPIOS); - s->l3v = *qemu_allocate_irqs(tc6393xb_l3v, s, 1); + s->l3v = qemu_allocate_irq(tc6393xb_l3v, s, 0); s->blanked = 1; s->sub_irqs = qemu_allocate_irqs(tc6393xb_sub_irq, s, TC6393XB_NR_IRQS);