From patchwork Fri Jul 22 19:50:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 72641 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1173200qga; Fri, 22 Jul 2016 12:52:55 -0700 (PDT) X-Received: by 10.55.52.147 with SMTP id b141mr6577057qka.13.1469217175720; Fri, 22 Jul 2016 12:52:55 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id a69si9685106qkc.140.2016.07.22.12.52.55 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 22 Jul 2016 12:52:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:49093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQgVD-0006Zy-7g for patch@linaro.org; Fri, 22 Jul 2016 15:52:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQgTC-0005d6-GB for qemu-devel@nongnu.org; Fri, 22 Jul 2016 15:50:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQgTA-00005A-Ai for qemu-devel@nongnu.org; Fri, 22 Jul 2016 15:50:50 -0400 Received: from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244]:34039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQgTA-000055-5k for qemu-devel@nongnu.org; Fri, 22 Jul 2016 15:50:48 -0400 Received: by mail-oi0-x244.google.com with SMTP id c199so11276337oig.1 for ; Fri, 22 Jul 2016 12:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GGpjah6q+qF5yyb9+KAUN+jsFuGyhf0+89MaZnk5kpU=; b=cixk+JgviMoOzHByS3khk84KYwZxLq4B9uo/QPv9IVI3WUd/I6WSkoy1aO3hKp+3v+ yHY//Iz9aqTLhoCq0tMd5WEyxk1dMybe1wvLwc+ZHDVlz0oc8PYbvB01oo6xF2BYFlff RxbutpI3qrvvzizsw1HCRQn6xygcIxlxEJzEvNolW2Bnd1Zts6QWdPgdg1ZPgdK79VEX v+ArPKqGMjrSJVNTH9Ce6TaJgO3cgdw6M+IuqO51cHbrZBMnzco1XnC4t6Xu7sN6JmHO BOkPKG3yB3glgEBMSOatPBqSvkVhJxAZCGfN6MSrNSHbtghtclC+tEY+Fw3/AAoXPrmq TC+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=GGpjah6q+qF5yyb9+KAUN+jsFuGyhf0+89MaZnk5kpU=; b=csohsDDzZqKvtydekLTtWz981zcxOw4Vs8mU6JZsCkqmVVYfgncnflk3skUlTnGp5u yYZkhnjk8I5DYNhdbPt7CnCm1f9rFiOpCtXsoSsjGlPh5ZrCIX2IJVV1pSRdYn+LAeEQ 1LqeXrimcWjwZ5K8zjQlLfurcEPXWjEDY0S1g9RlhLGg8O3IcFOpgAqrO7F2QrJVC7uF hMYWqeOd6daziIV4KWkT8NAKJrOB2h6Zf7zPdPDjdHXCSk9fk4/o3DKzSwuoYFp7dFWg 3c/Ln6FORYwvn8dnfto63tFslDQEX1mCD36dtkfmt+Q1RLMT6O8AgpMipuijqxPYhE10 KSiQ== X-Gm-Message-State: AEkoouvIKHbEvCiN9WgLXElTwVvdReYDIHvrn7O8OwECTWXDIXbQEOouW930Ugba6Ojlng== X-Received: by 10.157.37.130 with SMTP id q2mr2805034ota.77.1469217047590; Fri, 22 Jul 2016 12:50:47 -0700 (PDT) Received: from serve.minyard.net ([173.64.235.97]) by smtp.gmail.com with ESMTPSA id o185sm5781802oif.26.2016.07.22.12.50.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2016 12:50:46 -0700 (PDT) Received: from t430.minyard.net (unknown [IPv6:2001:470:b8f6:1b:c87e:7f7a:2ef0:2f10]) by serve.minyard.net (Postfix) with ESMTPA id 67A62142A; Fri, 22 Jul 2016 14:50:45 -0500 (CDT) Received: by t430.minyard.net (Postfix, from userid 1000) id 90BDC302317; Fri, 22 Jul 2016 14:50:42 -0500 (CDT) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Fri, 22 Jul 2016 14:50:38 -0500 Message-Id: <1469217041-15358-2-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1469217041-15358-1-git-send-email-minyard@acm.org> References: <1469217041-15358-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::244 Subject: [Qemu-devel] [PATCH v3 1/4] ipmi_bmc_sim: Remove an unnecessary mutex X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , minyard@acm.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard Get rid of the unnecessary mutex, it was a vestige of something else that was not done. That way we don't have to free it. Signed-off-by: Corey Minyard Reviewed-by: Marc-André Lureau --- hw/ipmi/ipmi_bmc_sim.c | 6 ------ 1 file changed, 6 deletions(-) -- 2.7.4 diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index dc9c14c..b742d8d 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -217,7 +217,6 @@ struct IPMIBmcSim { /* Odd netfns are for responses, so we only need the even ones. */ const IPMINetfn *netfns[MAX_NETFNS / 2]; - QemuMutex lock; /* We allow one event in the buffer */ uint8_t evtbuf[16]; @@ -940,7 +939,6 @@ static void get_msg(IPMIBmcSim *ibs, { IPMIRcvBufEntry *msg; - qemu_mutex_lock(&ibs->lock); if (QTAILQ_EMPTY(&ibs->rcvbufs)) { rsp_buffer_set_error(rsp, 0x80); /* Queue empty */ goto out; @@ -960,7 +958,6 @@ static void get_msg(IPMIBmcSim *ibs, } out: - qemu_mutex_unlock(&ibs->lock); return; } @@ -1055,11 +1052,9 @@ static void send_msg(IPMIBmcSim *ibs, end_msg: msg->buf[msg->len] = ipmb_checksum(msg->buf, msg->len, 0); msg->len++; - qemu_mutex_lock(&ibs->lock); QTAILQ_INSERT_TAIL(&ibs->rcvbufs, msg, entry); ibs->msg_flags |= IPMI_BMC_MSG_FLAG_RCV_MSG_QUEUE; k->set_atn(s, 1, attn_irq_enabled(ibs)); - qemu_mutex_unlock(&ibs->lock); } static void do_watchdog_reset(IPMIBmcSim *ibs) @@ -1753,7 +1748,6 @@ static void ipmi_sim_realize(DeviceState *dev, Error **errp) unsigned int i; IPMIBmcSim *ibs = IPMI_BMC_SIMULATOR(b); - qemu_mutex_init(&ibs->lock); QTAILQ_INIT(&ibs->rcvbufs); ibs->bmc_global_enables = (1 << IPMI_BMC_EVENT_LOG_BIT);