From patchwork Fri Dec 30 15:21:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 89375 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp6486317qgi; Fri, 30 Dec 2016 07:24:27 -0800 (PST) X-Received: by 10.55.42.34 with SMTP id q34mr48852072qkh.91.1483111467037; Fri, 30 Dec 2016 07:24:27 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id o1si24778428qtd.117.2016.12.30.07.24.26 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 30 Dec 2016 07:24:27 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:40306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMz2g-0003RP-Ga for patch@linaro.org; Fri, 30 Dec 2016 10:24:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMz0O-0002Gl-Qd for qemu-devel@nongnu.org; Fri, 30 Dec 2016 10:22:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMz0L-0000D0-SU for qemu-devel@nongnu.org; Fri, 30 Dec 2016 10:22:04 -0500 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:35907) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cMz0L-0000Cf-MU for qemu-devel@nongnu.org; Fri, 30 Dec 2016 10:22:01 -0500 Received: by mail-pg0-x242.google.com with SMTP id n5so22380611pgh.3 for ; Fri, 30 Dec 2016 07:22:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=+lqrlAXkWPqtSRnEOpA6DdRyWxuBQjkAxQ/R3TDCjh4=; b=s0bxuPzz/EAfDaHURE+v39M19d2pZjO/rs0hEQeziEpXnCB8aJvr7Gj3s77/FnXpnD Bc/0ZTWtUcS73Gf4Yek9TQz3x2F1JFLz+VykBtOgr+dShm16HX5xBCXRTW00y7Ur6lPq UC05Cb3suDbIxv+5woKKr5sTotvRVu/rhJXk2hceYxYntHT0WBnPvrOgFg3WfMKk7CR8 nN+rsyBtbIzXIPOa8SFVCL+lB7uVuTpaoiSgxZz1m5o0yKIHIR+AYtNvFY5EG7s2wELH 6j+Y9xteMEHgyLoyAHvCBpIvRrdoO8spD3FVAImqh+yXnkS+WYmmw7Q43lk/XjEuJlzk 5fOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=+lqrlAXkWPqtSRnEOpA6DdRyWxuBQjkAxQ/R3TDCjh4=; b=kegw5GrfFRx9SfG8YTSgzVPnOrnlDKCnfc0T/yU7XV5Mbhu4UkMIjurDnpmvP5HJ/G uHx5t903JL4zL5S3tnFBTJJEfdWJqINBSckdZ01xMWfZ6FvPQoIGDrypNCODV+Fs9Ngi YR2jevoTSoNKRxXC9mCGVf8HDbEa0yRBo6DnCNmAuiixICO6jrcu6LDI2bnVTeTQ54w1 MTeNrUkqIV7VRB1tewTkuql7NPMcjtip7FBPd6jp6sJewddQFXufHxMar8iw66aEbP6l Gx0VijPstEbFCWv6Xq88qyXfkSEC0pJPI1lnzPwImd+77c6bJuMgJ4aDoOCej7gFfznj mPlQ== X-Gm-Message-State: AIkVDXLvX2pD6zl41w9RaBaQjHSY8QE2KHH5yiFpCcHbhtz58i26SPUW1eDPs+AvBu3bbg== X-Received: by 10.84.137.169 with SMTP id 38mr99813827pln.128.1483111320955; Fri, 30 Dec 2016 07:22:00 -0800 (PST) Received: from serve.minyard.net ([47.184.183.230]) by smtp.gmail.com with ESMTPSA id p67sm113564839pfb.2.2016.12.30.07.21.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Dec 2016 07:21:58 -0800 (PST) Received: from t430.minyard.net (unknown [IPv6:2001:470:b8f6:1b:3850:e313:ed7:8ae4]) by serve.minyard.net (Postfix) with ESMTPA id 3139BA0D2; Fri, 30 Dec 2016 09:21:56 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 4B274300047; Fri, 30 Dec 2016 09:21:52 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Fri, 30 Dec 2016 09:21:33 -0600 Message-Id: <1483111310-24808-3-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1483111310-24808-1-git-send-email-minyard@acm.org> References: <1483111310-24808-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH 02/19] i2c-smbus: Use a int for return X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , minyard@acm.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard The return value from getting the data may be an error, so use an integer to hold it. Signed-off-by: Corey Minyard --- hw/i2c/smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/hw/i2c/smbus.c b/hw/i2c/smbus.c index 2d1b79a..c631a1c 100644 --- a/hw/i2c/smbus.c +++ b/hw/i2c/smbus.c @@ -222,7 +222,7 @@ int smbus_quick_command(I2CBus *bus, uint8_t addr, int read) int smbus_receive_byte(I2CBus *bus, uint8_t addr) { - uint8_t data; + int data; if (i2c_start_transfer(bus, addr, 1)) { return -1;