From patchwork Thu Dec 7 21:34:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 121087 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp8895112qgn; Thu, 7 Dec 2017 13:41:54 -0800 (PST) X-Google-Smtp-Source: AGs4zMa0qnr7PHjJEBebm+Os2c7ArqWuqvjOEcrZ096eeV1LV09e7zD/V8vgRQ9F0UVZhi7l6E07 X-Received: by 10.129.25.212 with SMTP id 203mr19539795ywz.261.1512682914323; Thu, 07 Dec 2017 13:41:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512682914; cv=none; d=google.com; s=arc-20160816; b=J1N9DaTKtC7wRQBn/7635wZllHaa2CtgLRDBx137Y1NvuLQpFk51jqaJJSPAF/hNeM V8msWC5X60TCuiQSD7/z7Uu5c/2D42TRzmbkFkKjbYVuuzYy6QSGzxtkHxszAHB3bkK3 6AyjwAlYG5nP2Dg+YqNz0W6Y5YYFD0YPQp8gY9iyHLoJzQt0ZWICzsG5RtXsHK15R9ST Z6ChYKn0o87aMEzft9vkcgj7WI60RbZtGE40Nz23wLBjIjjQpjXeQh6Z5FYaJ6z/08vF dA+s9mRz1npuf9LnWt55ZWNpYpOUJs7CPvr2JBOqur4UdqxJNp2FM3Yq2Wg3mNAn5Gjb JEnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=uRSobrHjxqieEnAdlolrJj1OZXyQ6+ruX8a9cfbGsE0=; b=Zx/ZnMqdGqePMwkl71qyCUoX20cBCskRSC0CCRLzKS1+LdL6fgjUkRThqd8X2Mbu1u jEbYFovsZyXDRlImAnVPdsRlEbXI8g8wDHtof8I9b2FAgl3HeWHHFDagqskeDRqDGGC/ +ble9+wg76V3oa2xuVHAH4jKdcfvelP1uQYTX3uzz+HlHAPIuXYvS8AKNX7AFkT2ARa0 C/54uQ8fn/mY+cEhpwfu0+HqY0imcit3QkdTe4hchy65GFarGgZVHmSNMCfGMH7CDBom TQT97qF44G1MFSECBtXua9e0mzE7XDfhs9rsfbKRrscL2LPO/s/CqPHrOMmeXWrHi83Q lIfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=pAkcwFj7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id c190si1303685ybh.532.2017.12.07.13.41.54 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 07 Dec 2017 13:41:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=pAkcwFj7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:34468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3vV-0008O8-Un for patch@linaro.org; Thu, 07 Dec 2017 16:41:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3ot-0001w1-H5 for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:35:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3oq-00053n-CG for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:35:03 -0500 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:45766) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3oq-00053I-5W for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:35:00 -0500 Received: by mail-pf0-x242.google.com with SMTP id u19so5641408pfa.12 for ; Thu, 07 Dec 2017 13:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=uRSobrHjxqieEnAdlolrJj1OZXyQ6+ruX8a9cfbGsE0=; b=pAkcwFj7GUPsMSWQ8qeOKKJvZpKhfHXBrQ3iMVizumWRx4R0y2Jx29vPjmhmpipnZD CNmaCxbF0WCjrSQpMbYDIQ+GOZrGeZKz/HRPoV0gNzKJh7ljy8B8/XwVaFe4XOdFFRnX iAEi+Ukzd319M540pIpqVRaBKjtDMvet4HvCTIXURQOtoqjM1xEzIjPthL3bAxiHyBH/ mC6xWHHuyvKiPPjC9srmjCt2XLgPRKstvavuEeBNVJC2wnKDMCKihooZbZMTUCVJi1Ze EZVoF+8X8ZoLafQuRU8NoXTJ2LBERLSSof1ijdjTkh5Pi9P2abCG4tyEu+eEOjDL7Oie ke6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=uRSobrHjxqieEnAdlolrJj1OZXyQ6+ruX8a9cfbGsE0=; b=GFgTewNmfWd0eosLCfXnViIARN3SiUj9II+uE1HZnXxHtpRZDF+0tDRYWHLMcdTVD/ FZYLWWecgiNk845t2zSnboW/m9BqcmV3ftkUcFLEgbSMYE8Y6enaL3TV+AmKjzRzV4/S jk0rEOaxG/s22P0xy2VO55pcH3x/oBCebfwrKiGMRT7RLQhOe/svbmjyM9cLfXjjQGqo o1pmBK0ZrXk2AjYxetM23fgeOeAyDFZW4+YatTYF3a3c4sZuZjC7LoDAkVuNGltbhppp XJZhfLMsSW/Prz0V1cknWbBPBvVGI+NOGMUbkorAbJeqrPg8YhPi7YYUo2VHx7+1A9Uh vp5A== X-Gm-Message-State: AJaThX5O1h2OvlJLuIoV9YWrZrx0IIvVdKxUcH59LlC9QAOJCMIUHxwE Mz7BE1zDYZ+NiwVwsdNgdudJvJ8= X-Received: by 10.101.101.208 with SMTP id y16mr26974073pgv.159.1512682499106; Thu, 07 Dec 2017 13:34:59 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id u18sm10965021pgn.72.2017.12.07.13.34.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:34:57 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id CF89EDF0; Thu, 7 Dec 2017 15:34:53 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 4F9CE302366; Thu, 7 Dec 2017 15:34:52 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:34:48 -0600 Message-Id: <1512682489-4474-7-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682489-4474-1-git-send-email-minyard@acm.org> References: <1512682489-4474-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 Subject: [Qemu-devel] [PATCH 6/7] smbios:ipmi: Ignore IPMI devices with no fwinfo function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard Not all devices have fwinfo (like the coming PCI one), so ignore them if the their fwinfo function is NULL. Signed-off-by: Corey Minyard --- hw/smbios/smbios_type_38.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.7.4 diff --git a/hw/smbios/smbios_type_38.c b/hw/smbios/smbios_type_38.c index 56e8609..5475323 100644 --- a/hw/smbios/smbios_type_38.c +++ b/hw/smbios/smbios_type_38.c @@ -95,6 +95,9 @@ static void smbios_add_ipmi_devices(BusState *bus) ii = IPMI_INTERFACE(obj); iic = IPMI_INTERFACE_GET_CLASS(obj); memset(&info, 0, sizeof(info)); + if (!iic->get_fwinfo) { + continue; + } iic->get_fwinfo(ii, &info); smbios_build_one_type_38(&info); continue;