From patchwork Wed Dec 13 18:12:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 121815 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp5818216qgn; Wed, 13 Dec 2017 10:27:13 -0800 (PST) X-Google-Smtp-Source: ACJfBouCjtFOK1hT3bLLSp3Kl3spIWg3EBV19I7M63Mt072iGRA9yyv+rmhhjdXX7CTHvTtYxyU6 X-Received: by 10.37.94.137 with SMTP id s131mr2419229ybb.346.1513189633622; Wed, 13 Dec 2017 10:27:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513189633; cv=none; d=google.com; s=arc-20160816; b=N+88HIZBh4sW4rV3r5vko82wxcpBZ/IebXx20vu/j0hsYb1adR0SWHcwTuzNpPUVff hJ1+EDb4CGJTvnyDNdNB6Baqu/BuNxZVvH736aN1QGekxSVq9td4v4WI3hvEOad/R2qs kpMsvz/s0ix9I2/EPyX1WNVOg1R4H1dGwi9z7D8MrMWSL1SRTDtEZpSEMjPFlW5e1Uw3 6NYGVw1x44XoIqQxpHSUGBCLqYSuBsgxmNSj7ug1ZS4Ia9tZ2o0M+RoVu37S9smV7DpU HN+dxkILaNU58oMetQJqysUVs+1h4rLzwoQPfuQOCaMejgyV+oKNHhVDJJuQEGEog4Xu 7m8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=QkWsmQFJdIbhLteUZZMcUK93wesasZJJG1Njv3W2+Uo=; b=qZc99/9i0NPl8zM029lJZV+6cbxL41QLsiYWh+NxnvdqV2F5Ds1QnR+JqpCTe9j7ym jIXbJIecYilSjPCruwqvREfm2IQJFkP5jGN3rn0cM/4VLpq2lVKnjQZLVQaMw8gcGR6z NIOUZhm1B1K8YynL/Y8xN4Gk+EKXCj9acu+ZkRZa3xxkS2Uvm7QBjwM7bG9VVmyMWGmn BeptXhMFfbqNuQLqW9ZOdH2IlJk0Qo7elJOGbnsk0u5FAOfGEY4ziWXxGSvxIMTArzEx 8TzuuGZwRdI51twr4gJ8CPreurtxlLdjiZn6zYz9MBEcD3q6m21iHnPcwGHqAnLT5XTS 2rWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id e123si460296ybh.466.2017.12.13.10.27.13 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 13 Dec 2017 10:27:13 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:36875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePBkO-0008H8-Bu for patch@linaro.org; Wed, 13 Dec 2017 13:27:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePBWW-0004dv-Jl for qemu-devel@nongnu.org; Wed, 13 Dec 2017 13:12:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePBWV-0007gx-HO for qemu-devel@nongnu.org; Wed, 13 Dec 2017 13:12:52 -0500 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:39118) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ePBWV-0007cv-9K for qemu-devel@nongnu.org; Wed, 13 Dec 2017 13:12:51 -0500 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1ePBWU-0007dB-1L for qemu-devel@nongnu.org; Wed, 13 Dec 2017 18:12:50 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Wed, 13 Dec 2017 18:12:09 +0000 Message-Id: <1513188761-20784-12-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1513188761-20784-1-git-send-email-peter.maydell@linaro.org> References: <1513188761-20784-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 11/43] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Francisco Iglesias Don't set TX FIFO UNDERFLOW interrupt after transmitting the commands. Also update interrupts after reading out the interrupt status. Signed-off-by: Francisco Iglesias Acked-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Message-id: 20171126231634.9531-12-frasse.iglesias@gmail.com Signed-off-by: Peter Maydell --- hw/ssi/xilinx_spips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.7.4 diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index ab54da8..3805d8b 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -329,9 +329,6 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s) uint8_t addr_length; if (fifo8_is_empty(&s->tx_fifo)) { - if (!(s->regs[R_LQSPI_CFG] & LQSPI_CFG_LQ_MODE)) { - s->regs[R_INTR_STATUS] |= IXR_TX_FIFO_UNDERFLOW; - } xilinx_spips_update_ixr(s); return; } else if (s->snoop_state == SNOOP_STRIPING) { @@ -530,6 +527,7 @@ static uint64_t xilinx_spips_read(void *opaque, hwaddr addr, ret = s->regs[addr] & IXR_ALL; s->regs[addr] = 0; DB_PRINT_L(0, "addr=" TARGET_FMT_plx " = %x\n", addr * 4, ret); + xilinx_spips_update_ixr(s); return ret; case R_INTR_MASK: mask = IXR_ALL;