From patchwork Tue Jan 16 00:57:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 124577 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp845494lje; Mon, 15 Jan 2018 17:06:02 -0800 (PST) X-Google-Smtp-Source: ACJfBovogEOSfieKl/OA1JDceQNFTeB6zHatjLDhI633bYj0letRbjnU9ftIPLCo9AFA9f8B5OrM X-Received: by 10.37.28.9 with SMTP id c9mr32688998ybc.65.1516064762596; Mon, 15 Jan 2018 17:06:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516064762; cv=none; d=google.com; s=arc-20160816; b=quQIPp3SEigzl4wj1R/hkIv7xngDq++9noroOetefKu5NR6XjpbM7a3sqhMMF+EneR bCih0jpUQxeX7RE2DSLzA3GapNnVpSg8cGTZoogpJDWtkPXKZ3uQX64if9q+VznTtCax 6lpUVuMyEMoMhgv2vKISTDLIBExh12DLSTnCqkHivh+yJAz/rcXcjIcJNbEzGwzewOZW WGayoRAVqeN7SlTJ2u4a2mfgL4MdhcKOXBZtzZJQwV7Cv01i6hbwnB/0q16YPhixiPiU qbexGljab4JV7QxCgdbMkPu5bEc8Qul98Eqyd44pNkgCUSQejSijYrRLrug5pO8J10Ud L5LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=0F2xaRV+PnCJvXVpI6Att709KDACjJNoF2TNpF2bBMQ=; b=JKGjFahE63i0CqDjQId6oqIjdMsHoVjf0b+bLb+wkdihaVX5tyXLIIk06U10370wA3 9FQDJosLLjO8wwR+pm+3qtcEvYrzIdo8hD+ncX4SqhUqm3A7505yllAzNo9dpmWA+mMr EJ4ZCnEZkHsmxI/cAev/vmSbWzwOTguZIZLle4YcPLoP6ikaPHSvoKewCzAoQA7FLkAe e7Kr4g01tWgHvk1HxkvT7ut91GvWVe3C6jE8F+Raku0MD5wWQAsrvcISxW3P9S3oOudp t0kbbxOT3uMWuOEIxfTKQ0RsPzEEMn8w07agsJXkt0CatHmpS0Nh4WyVjLA8vNmm34l9 nP6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ZAH4YVsk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id u185si196675ywc.486.2018.01.15.17.06.02 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 15 Jan 2018 17:06:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ZAH4YVsk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:49870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFhR-0004gN-V6 for patch@linaro.org; Mon, 15 Jan 2018 20:06:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFZv-0007sW-E2 for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFZu-0000mg-Hz for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:15 -0500 Received: from mail-ot0-x244.google.com ([2607:f8b0:4003:c0f::244]:36513) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFZu-0000mE-CP for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:14 -0500 Received: by mail-ot0-x244.google.com with SMTP id w4so12197186otg.3 for ; Mon, 15 Jan 2018 16:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=0F2xaRV+PnCJvXVpI6Att709KDACjJNoF2TNpF2bBMQ=; b=ZAH4YVsk/Nj//7iNwJ4wP5UGjVYx9S3M/UlQy+hdKKoinZ3tx2193K6DoQhv5d7Yuq U+ThGo/B1S1SN6SXR1vOP/CevyPub0opzFH3BSeFrWm3xgBOISHr7nJMGpw7V60MQG0P 9CFs+KLyD7icj3wAaOo64eZ+ulQihFvsbT0Fk4DWKwBF2lKrKEeUF66P0CPCiR2lw83e kFq4WmX5WcgMblLBqawJYS1I9/cg/1Ktepkdu6TRzww/zUwrxZJWu29qjEyvBnxqlbTy KAECBIQ9q+bakbN6evIeOQUV3waFxu25yPDod4P8Capic62MdZR94RPs9Q6MnS9odXfd KpFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=0F2xaRV+PnCJvXVpI6Att709KDACjJNoF2TNpF2bBMQ=; b=PCsMd56ft3c63SAREDtiOKrWS1leoj5qusHLW83cxyonm4cTGsFTvla90kqA998Dc8 pUNVQ9ELRwEVjI1lM5oSSn0PLh22Vc4JI5/0naf8r9HFecp4/ZYLrfKhjo8XGFEa4Qxz 7ivgYWqCWoag4yOk2rHmBHAoK4D62TdUY+GHXD35bJTQ9/jdraOf0SaQjkLbdcZt3wfp bXiGITC2Ig/Z8vJaHqwvipIvfiTGYUdXehtz1xArnFtBYADaptG8h+Ejethrw5HG3VYt ozfUfTduGo/JhQTvLuhpguRw9YnXOiSTIQm8eUXNck0j7EYoF/RNlRm2df0pg2YNUMBF 6Rhw== X-Gm-Message-State: AKwxytcEGbE1eaQ4pu4I9xKl3j68toQ83u18GExr8EAmiUJSabcJlynw ClvyXPBH5Mq9taVYmerOaw== X-Received: by 10.157.44.101 with SMTP id f92mr16006924otb.205.1516064293594; Mon, 15 Jan 2018 16:58:13 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id j16sm483742oth.42.2018.01.15.16.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 16:58:12 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 6D43AB9B; Mon, 15 Jan 2018 18:58:07 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 309AC300968; Mon, 15 Jan 2018 18:58:04 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Mon, 15 Jan 2018 18:57:58 -0600 Message-Id: <1516064279-14816-7-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516064279-14816-1-git-send-email-minyard@acm.org> References: <1516064279-14816-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::244 Subject: [Qemu-devel] [PATCH 6/7] ipmi: disable IRQ and ATN on an external disconnect X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Corey Minyard Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard Otherwise there's no way to clear them without an external command, and it could lock the OS in the VM if they were stuck. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.7.4 diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index abab3bb..58ade79 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -424,6 +424,11 @@ static void chr_event(void *opaque, int event) return; } ibe->connected = false; + /* + * Don't hang the OS trying to handle the ATN bit, other end will + * resend on a reconnect. + */ + k->set_atn(s, 0, 0); if (ibe->waiting_rsp) { ibe->waiting_rsp = false; ibe->inbuf[1] = ibe->outbuf[1] | 0x04;