From patchwork Fri Jan 27 10:39:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 92608 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp174964qgi; Fri, 27 Jan 2017 02:56:07 -0800 (PST) X-Received: by 10.55.118.67 with SMTP id r64mr7295178qkc.285.1485514567890; Fri, 27 Jan 2017 02:56:07 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id t8si3276751qta.36.2017.01.27.02.56.07 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 27 Jan 2017 02:56:07 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44319 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cX4CL-0001BC-Hw for patch@linaro.org; Fri, 27 Jan 2017 05:56:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cX3wJ-0003Ka-Um for qemu-devel@nongnu.org; Fri, 27 Jan 2017 05:39:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cX3wG-0003U6-5e for qemu-devel@nongnu.org; Fri, 27 Jan 2017 05:39:31 -0500 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:37572) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cX3wG-0003U1-04 for qemu-devel@nongnu.org; Fri, 27 Jan 2017 05:39:28 -0500 Received: by mail-wm0-x235.google.com with SMTP id c206so130176373wme.0 for ; Fri, 27 Jan 2017 02:39:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y2+v1flgVFTMeQ/XkdeqfH3M+QZGMjHF/xurefWed+s=; b=EOPYagz1Z30RhzsqSM98TjN8Vk9sTi3EmCGWne7+uXTXN/lvvTzZ+8rA+xPYWN4WE5 QpDV4/Pf+lAGPUauH90JZtx9WXf7pZuJ5BQ4flCbePwUhWYdLPUZL1AyUjHX27iSpr2s hIBdCldjbaJkXCK5HM7TuDM7PBydb4A0k+6+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y2+v1flgVFTMeQ/XkdeqfH3M+QZGMjHF/xurefWed+s=; b=Z2WIAQIbz08kVUA5iSOzYmWNRAxo9sN27HCejDdkmOSa3i279xtO+Q1dsizC6nGM2V FjIIHYSgckNxp10XRYMNKz35iWh+9mlvMmYaKXvpQ4fZqukgd8FrqyiQ81fI8mQgo6Oo vbUiAJPZtMfAqaokDlvG0PiERaQ5zp6gXeHKoat+8lbHJevbvOWy4CAKd3CQMWS2xmwC HeGTGWHLBnOiNSOcr8CMIIrXCs8h8WNMlWQxO+9JIAUBSEkszVqsN/OgvIqRlkxLOF/0 ZFfUlXxeJmQ8MsFeR46+5gQXmKRzdVds+WbshGw496EwL4bAvgGOmNqxuAWy57qX0E4j bFhA== X-Gm-Message-State: AIkVDXIHUjGYMdlsCjRGw28ysDq7RutnjQJqeyTwstqJ4mqiM9Q73P3rJNt95edaeC21w7WP X-Received: by 10.28.143.5 with SMTP id r5mr2510667wmd.141.1485513566953; Fri, 27 Jan 2017 02:39:26 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id r5sm3085412wme.23.2017.01.27.02.39.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jan 2017 02:39:24 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id A38943E3744; Fri, 27 Jan 2017 10:39:22 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: mttcg@listserver.greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com Date: Fri, 27 Jan 2017 10:39:00 +0000 Message-Id: <20170127103922.19658-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170127103922.19658-1-alex.bennee@linaro.org> References: <20170127103922.19658-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::235 Subject: [Qemu-devel] [PATCH v8 03/25] mttcg: Add missing tb_lock/unlock() in cpu_exec_step() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite , jan.kiszka@siemens.com, mark.burton@greensocs.com, serge.fdrv@gmail.com, pbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , bamvor.zhangjian@linaro.org, rth@twiddle.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Pranith Kumar The recent patch enabling lock assertions uncovered the missing lock acquisition in cpu_exec_step(). This patch adds them. CC: Richard Henderson CC: Alex Bennée Signed-off-by: Pranith Kumar --- cpu-exec.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.11.0 Reviewed-by: Richard Henderson diff --git a/cpu-exec.c b/cpu-exec.c index 4188fed3c6..1b8685dc21 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -233,14 +233,18 @@ static void cpu_exec_step(CPUState *cpu) uint32_t flags; cpu_get_tb_cpu_state(env, &pc, &cs_base, &flags); + tb_lock(); tb = tb_gen_code(cpu, pc, cs_base, flags, 1 | CF_NOCACHE | CF_IGNORE_ICOUNT); tb->orig_tb = NULL; + tb_unlock(); /* execute the generated code */ trace_exec_tb_nocache(tb, pc); cpu_tb_exec(cpu, tb); + tb_lock(); tb_phys_invalidate(tb, -1); tb_free(tb); + tb_unlock(); } void cpu_exec_step_atomic(CPUState *cpu)