From patchwork Thu Mar 9 11:17:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 95097 Delivered-To: patch@linaro.org Received: by 10.140.82.71 with SMTP id g65csp309384qgd; Thu, 9 Mar 2017 03:18:49 -0800 (PST) X-Received: by 10.200.45.194 with SMTP id q2mr14236797qta.130.1489058329431; Thu, 09 Mar 2017 03:18:49 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id b125si5409838qke.226.2017.03.09.03.18.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 09 Mar 2017 03:18:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clw5m-0005Dk-Ro for patch@linaro.org; Thu, 09 Mar 2017 06:18:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clw4G-0005AK-RV for qemu-devel@nongnu.org; Thu, 09 Mar 2017 06:17:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clw4C-0006SX-Nr for qemu-devel@nongnu.org; Thu, 09 Mar 2017 06:17:12 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:37812) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1clw4C-0006SC-IE for qemu-devel@nongnu.org; Thu, 09 Mar 2017 06:17:08 -0500 Received: by mail-wm0-x231.google.com with SMTP id n11so53342715wma.0 for ; Thu, 09 Mar 2017 03:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p5/6ndff1rdJZj2ErRc4keeAto2otbY0VYtakoX29oI=; b=be7XHVn6PoIs/JPLraNnxbT+qlFG2umAx42XRKEMfcQbR2zPF9Mma/rpbIun+bZKVk pJ28m48ZqCkfjHiPcVb57bBKGLsPUvOOzQeyBa6EuBJHIIKAPyx+Siz8vJVWC3xFJFiu Dbos1SfsJqP1POLDwOcDXkIM5Hi86Aak8I/eE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p5/6ndff1rdJZj2ErRc4keeAto2otbY0VYtakoX29oI=; b=c83wN+RpCvcOoaF4a3C2wiTByFiwMq0cjuZn1D9Ja+GlG+t//d07mqKo+oMs1u1xEn +O3xY5KkISTjg4ZiG6NbI4bktWNwKPwHK/r5fFHmDpl7mtQJaRvfq1sIclAucjtgXwia uX5B1xQQ+aZM+0V4YL4n0vgkNhTVrB9zRs5Z8uQT2c3G2iEDJkCoj0I8+027J+/ky88K BXkYdIFX46OpDQOPYMtY17JzCxOngiXBbmMr1oJTBPGwNv2qHRjAQutZHMEIgvyw7dun 1BUV/u0dJzd+mJw7+572FWCsDhiACNKwpyAvYymG//15mwg/kIt/EPdGyoMcGK2M/wb6 zrkQ== X-Gm-Message-State: AMke39lGUlw5hro12XHNRlEgi/SNpjHo00L5FAS63I5HwRVvSS20B/LcFKbaZz9hwhSKdRXB X-Received: by 10.28.100.193 with SMTP id y184mr9804161wmb.2.1489058227601; Thu, 09 Mar 2017 03:17:07 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id n187sm8417231wmd.4.2017.03.09.03.17.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Mar 2017 03:17:05 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 41D173E07A7; Thu, 9 Mar 2017 11:17:15 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Thu, 9 Mar 2017 11:17:06 +0000 Message-Id: <20170309111714.20394-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170309111714.20394-1-alex.bennee@linaro.org> References: <20170309111714.20394-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::231 Subject: [Qemu-devel] [PULL 03/11] cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Peter Crosthwaite Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" While we may fail the memory ordering check later that can be confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be defined we should say so specifically. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- cpus.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.11.0 diff --git a/cpus.c b/cpus.c index 6a817fec13..69e21858b8 100644 --- a/cpus.c +++ b/cpus.c @@ -202,6 +202,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) } else if (use_icount) { error_setg(errp, "No MTTCG when icount is enabled"); } else { +#ifndef TARGET_SUPPORT_MTTCG + error_report("Guest not yet converted to MTTCG - " + "you may get unexpected results"); +#endif if (!check_tcg_memory_orders_compatible()) { error_report("Guest expects a stronger memory ordering " "than the host provides");