From patchwork Fri Apr 7 15:42:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 97034 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp340826qgd; Fri, 7 Apr 2017 08:45:33 -0700 (PDT) X-Received: by 10.200.43.85 with SMTP id 21mr39590373qtv.81.1491579933605; Fri, 07 Apr 2017 08:45:33 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id b18si5119635qkj.183.2017.04.07.08.45.33 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 07 Apr 2017 08:45:33 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwW4r-0004Xx-5R for patch@linaro.org; Fri, 07 Apr 2017 11:45:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwW1p-0002OX-3R for qemu-devel@nongnu.org; Fri, 07 Apr 2017 11:42:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwW1n-0007Tr-MO for qemu-devel@nongnu.org; Fri, 07 Apr 2017 11:42:25 -0400 Received: from mail-wr0-x22e.google.com ([2a00:1450:400c:c0c::22e]:33674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwW1n-0007SV-GH for qemu-devel@nongnu.org; Fri, 07 Apr 2017 11:42:23 -0400 Received: by mail-wr0-x22e.google.com with SMTP id g19so68076883wrb.0 for ; Fri, 07 Apr 2017 08:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vma+WY0g4IYtFBe1+uJbndMPoNWlWhlcNAqnBcBpzD0=; b=hR9oCGuZAOF2VNXuwtm02iiCyfg2e0yvXdEc0H76QQYUsPfWI4nvbjdEEgcgI0ByiT 0HyfVuPmWGJIHttioElQFJ/pSLpLsMixNCJYhawmVRWqQPowKJwK4nfzUxADw9usFMGr P0rN9OJnZuRWgJZCBstKZ5QURyOEDf9De2aBc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Vma+WY0g4IYtFBe1+uJbndMPoNWlWhlcNAqnBcBpzD0=; b=B7g14rGevmrp5/CUTwxYP3xNVfDfSpNW4NZsRF+nftpGb9zMRpp50R+MtxtYAebp+O yUgbVkLGWpE/s4s1TJzRnjKkNYW5vjDlxoVVZALsGQxl4KWpjIfWB2HlRvms+eleS7uI QsjPYT3cvjJgidmspSTAB22wOMS7PNhjR7XbDrJWO/24TRSVUegTFUT0FNceTxk+VVEN fJ3SRV4G1QQsX78+w6+yOjQoIGQrwSaZ3BzIdwHRUGnCy0tHZ9pRJtl1//dB0MRKoIsj 1+egdNRY5nGc5EmYgoMZOyPrzjum2j63vcIUi70wKim33kwybd0Gog8F4j3EZqjXd9+r qhIw== X-Gm-Message-State: AFeK/H1zu2SFH6glADG7SEkIete8s1Mhi6t8o5WJb6lyBU4jJ9zle4t6YTuEiKwF4NtZCIjR X-Received: by 10.223.130.197 with SMTP id 63mr13434890wrc.177.1491579742350; Fri, 07 Apr 2017 08:42:22 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 60sm6425839wrg.60.2017.04.07.08.42.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 08:42:20 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 54F153E102C; Fri, 7 Apr 2017 16:42:22 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: dovgaluk@ispras.ru, rth@twiddle.net, pbonzini@redhat.com Date: Fri, 7 Apr 2017 16:42:13 +0100 Message-Id: <20170407154221.26918-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170407154221.26918-1-alex.bennee@linaro.org> References: <20170407154221.26918-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22e Subject: [Qemu-devel] [PATCH v3 04/12] target/i386/misc_helper: wrap BQL around another IRQ generator X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, Eduardo Habkost , nikunj@linux.vnet.ibm.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, cota@braap.org, bobby.prani@gmail.com, =?utf-8?q?Alex_Benn=C3=A9e?= , fred.konrad@greensocs.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Anything that calls into HW emulation must be protected by the BQL. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Acked-by: Eduardo Habkost --- target/i386/misc_helper.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.11.0 diff --git a/target/i386/misc_helper.c b/target/i386/misc_helper.c index ca2ea09f54..628f64aad5 100644 --- a/target/i386/misc_helper.c +++ b/target/i386/misc_helper.c @@ -18,6 +18,7 @@ */ #include "qemu/osdep.h" +#include "qemu/main-loop.h" #include "cpu.h" #include "exec/helper-proto.h" #include "exec/exec-all.h" @@ -156,7 +157,9 @@ void helper_write_crN(CPUX86State *env, int reg, target_ulong t0) break; case 8: if (!(env->hflags2 & HF2_VINTR_MASK)) { + qemu_mutex_lock_iothread(); cpu_set_apic_tpr(x86_env_get_cpu(env)->apic_state, t0); + qemu_mutex_unlock_iothread(); } env->v_tpr = t0 & 0x0f; break;