From patchwork Wed Dec 6 15:28:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 120874 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp7195362qgn; Wed, 6 Dec 2017 07:30:37 -0800 (PST) X-Google-Smtp-Source: AGs4zMa2htDKNLJXQwSzWpmS4DG9HrtxyqzIOeBIcjHqO5KycIiTtKjZKjtzkqUMo1onvROTocRq X-Received: by 10.37.223.81 with SMTP id w78mr2472753ybg.16.1512574237724; Wed, 06 Dec 2017 07:30:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512574237; cv=none; d=google.com; s=arc-20160816; b=rPyzKQuIPD7h7ZU+2XpAm/4UB1799/XdRnj7IXfmAmJ/9bHGuulVOhCy5QBpD2ARC9 R8Xu90eEJRnqGjjna9InLIVkmuFz76yliJuJeFVmh/TR3K4a14osiyJiar9TZqayUmYE cwZPUTjjBaDfRq+phCdG6mDMVcSZkoFUuJt7XY1twWGx5BE8XoEaDB09SZuE0qps+aXY /UjzPQeKH7OWjAb54ZlKUpJu7Vho2lHwfeKgJHpNn1YQznDLeIg7VLvfgvcprm8NpgIk 40a2dozdZNMTnah5L5SHLt2nM9QLv9BeyJoAPojWZoBRpBDzQnfLemkVV5ZF749bulKD MOng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=jf+g5y6WM/jRIbnyZASYnkQwfDmgjB886R6IeSQn3FQ=; b=FDjKVY+1KBGb9ZqNwbYtKXGncXZ7tT6T9fLT1ZgyU+T/gr0odecartLQZ8oJXlRJ0O /WsnE4g9ctnAF1zuk4+oIQ3cm3es9z2J6FnPTafSww3+tA/iOiWScMR6thlZhTaxyNLe 9e2UOitlEgHet9iReQhjioI3llYflSiRwvFhi/M5RSvEb+gKtsuv1CANlArbAZUq06QQ j7gXxu1WRkXKJ2QqEgZq7tVID3QihVKANIfuvRUbz6uan2iTWlI3u0XXnLR1DWqxttgm 7MN1V/6lMgEPN0/omtVctKW+PMjyOZ7jBOE6JCo3X0Nv92htlMMolY54jmjEHOgIKcKd 9eFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Lfh7z7l0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id q6si728045ywi.152.2017.12.06.07.30.37 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 06 Dec 2017 07:30:37 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Lfh7z7l0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMbef-0005Tw-BU for patch@linaro.org; Wed, 06 Dec 2017 10:30:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMbdE-0004oJ-AU for qemu-devel@nongnu.org; Wed, 06 Dec 2017 10:29:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMbdB-0004dT-4L for qemu-devel@nongnu.org; Wed, 06 Dec 2017 10:29:08 -0500 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:35178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eMbdA-0004d3-Sz for qemu-devel@nongnu.org; Wed, 06 Dec 2017 10:29:05 -0500 Received: by mail-wr0-x241.google.com with SMTP id g53so4335555wra.2 for ; Wed, 06 Dec 2017 07:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jf+g5y6WM/jRIbnyZASYnkQwfDmgjB886R6IeSQn3FQ=; b=Lfh7z7l0mDklq8ZvNuPXMer4pidef48CEODy18qNjeh/x5HKtwfwzUi2jhbju3nIPj uBeTo/ANGQSdHmmCOdN4EArDzUDnbrH57kG0fM3oYz+s7ezjekxBfBCUL8a1se3LEi5Y wnchVoAytLToDtu7hcRFfOx2hL+CCnGPILUnQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jf+g5y6WM/jRIbnyZASYnkQwfDmgjB886R6IeSQn3FQ=; b=BP2hJ0oWiQ3qtJJyRmYLLR9FundNCM1mDFK/nF0Fh/Dvcycm2K5pSECMe6tkRPAbr6 4+tqfhJGDhevnS1Vc7djbeLuUWqlg8eW34A+GlFvwxsvns3V+v2tk3d+oLaXXHOGRf8P cwDnWWvvTVAh9pPFgid3eTsOPI+OINqLXBLDmEcJG3objFculyCdBjWO1Ya9Vqfo5rIa DTUoZB79sU+JfzESgIWf7Z+/I0sCh0Goy6/YqgZ4QRVTncCRYl73ig+sFigbSqldtc6k hbmbHP1NW6Sq2I7o8vP/JaRTYK9YiPqP+Id/fpkkXXwUOf1gABAWypWKoyumKKdD3YRy igwg== X-Gm-Message-State: AKGB3mK6Q0rhXqjkebuNpBOHuZRkp/j+g0IrosREjhJGMCwjZM/6uHad YfY7FbChFnOoq/KlKCpKEvlVYg== X-Received: by 10.223.135.179 with SMTP id b48mr13630197wrb.24.1512574143540; Wed, 06 Dec 2017 07:29:03 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id l1sm2979094wmh.13.2017.12.06.07.29.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 07:29:02 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 333F63E039C; Wed, 6 Dec 2017 15:29:02 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Wed, 6 Dec 2017 15:28:45 +0000 Message-Id: <20171206152845.8215-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PATCH for 2.11] target/sh4/translate.c: fix TCG leak during gusa sequence X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Aurelien Jarno , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This fixes bug #1735384 while running java under qemu-sh4. When debug was enabled it showed a problem with TCG temps. Once fixed I was able to run java -version normally. Reported-by: John Paul Adrian Glaubitz Suggested-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Tested-by: John Paul Adrian Glaubitz Cc: qemu-stable@nongnu.org --- target/sh4/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.1 diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 703020fe87..b4b5c822d0 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -2189,7 +2189,7 @@ static int decode_gusa(DisasContext *ctx, CPUSH4State *env, int *pmax_insns) } /* If op_src is not a valid register, then op_arg was a constant. */ - if (op_src < 0) { + if (op_src < 0 && !TCGV_IS_UNUSED(op_arg)) { tcg_temp_free_i32(op_arg); }