From patchwork Wed Jan 24 23:25:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 125748 Delivered-To: patch@linaro.org Received: by 10.46.66.141 with SMTP id h13csp741292ljf; Wed, 24 Jan 2018 15:50:51 -0800 (PST) X-Google-Smtp-Source: AH8x226i9JdFQssUufykfBmm1Mj/7BBIQVE6c9wrWv8sCcROhVkTBBuskhWeZ02ZiVzW+fzdVrJg X-Received: by 10.37.160.98 with SMTP id x89mr7026402ybh.448.1516837850966; Wed, 24 Jan 2018 15:50:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516837850; cv=none; d=google.com; s=arc-20160816; b=nBy9c8c1sN5yk37FaK7hnh69uHD0ZqNy/Zv6Yqjq/bno4LvV3omVdo5rEaIVtI2SHj Glolfkmgm3oGBaz/Jvdit3SJkJEDlPxPibOghb7nO6fvO6mq5XI8x10ISey2FkwaxJry fNpLskaLLSG4lOTk49TYteLL4CO4DjfsgSiIy28k1b9mR5sqyuoWzhcUuONfztaCB0Nw 1orpZjpcsQWNCTHUbxHzJaUIjXoe0SPRyT1dDgdRSjTJerLG7WXD8DsWe8aBjYTIpHKk i/vMt1PA7oyii0BTd3gN4DTZFdEvPH4N0FPw2IJLmz+UbR1ywWxNW39HgynXwx0vnV9P QMkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=3QgQ3aTosAcrqniuf2FzQ9ncn1tfTZjIHIuTzT3AMPw=; b=sY6HjrWzRb+Q4BLHh65AQlwEKQ6s6+r6fL6zTRPlHCh6stxjWRM7YvHGMnTLre2e+x ZI6Ex0ExbbJM+ZgakYuJ4eyCV1w1gKsdOMWix+TY0OpxfJXKnRYRvNR2B5f6L/knQxs6 pd5n7/WZ78IDhlzqfsBwJTLTFAW4/0SaUbzMkjdoZiWT3UaLJwIK7IUS57G76WvK4Q/m JSrKkBMScFc6lTOKBbDUbZHwuTWPLGTAopqX6R8JzQDRmdErKSfO0kLAv6Sl5GgfURsd h+gTyoOanmnHOER6nzmyrBGEPljmDaKgPMStNcOSRl841uswx2fCYs+xavn383ud/Dpc 04dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=B3Ud02GC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id h11si233934ywm.613.2018.01.24.15.50.50 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 24 Jan 2018 15:50:50 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=B3Ud02GC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeUoc-0007Nb-Av for patch@linaro.org; Wed, 24 Jan 2018 18:50:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeURX-0004gf-3S for qemu-devel@nongnu.org; Wed, 24 Jan 2018 18:27:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeURV-0001tH-TD for qemu-devel@nongnu.org; Wed, 24 Jan 2018 18:26:59 -0500 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:41935) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeURV-0001s9-LW for qemu-devel@nongnu.org; Wed, 24 Jan 2018 18:26:57 -0500 Received: by mail-pf0-x241.google.com with SMTP id c6so4359732pfi.8 for ; Wed, 24 Jan 2018 15:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=3QgQ3aTosAcrqniuf2FzQ9ncn1tfTZjIHIuTzT3AMPw=; b=B3Ud02GCV3RJw4F8OdHaNjP5U6ibt3T1t2Yh7dlPcbRJkKo2d+PjlGEfTm3p0Uz4nC seUOa1Mt4uaEVqaY3aTa2Xobv5hHkROKyeOcf6zYfRfEikXT9gOK6i0OsgCrgPhdA5LI bdQQbOBuXf0p2UzAiNmO0ejsxa1dFCbW+j2uM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=3QgQ3aTosAcrqniuf2FzQ9ncn1tfTZjIHIuTzT3AMPw=; b=c/cAbhB3tBPRa5eeKiEnz6QUKNIg2BEZI3Z1yitM3bS+Z14DYjcp76IXbIX+5GjjP0 mKhrEvRfPtBRXU8Vl0JT3AShKPysQl/F15X/DkDaTlT4Cghqr1SsS4QvpCtf08UxiPgg auTvgQXiEx3xxU2f93teg/GIhqpWwYktGZ8n4z1cw0MVH2gocoaPqJEpKA5kOFto4PQe xxck8RRN6ADDqESZ6IzjjpzIQCaacciQCDpDOwkFVSn8mcmnbmPQVMe7yiEDNLrIUaHm wIog5XvR0u4mShVTfH7GFUD11tl3FngJiVR3bec3rEn+cMT18Jl6ZSrwbKrqrQH6Got9 5vhQ== X-Gm-Message-State: AKwxytfA6smPp6Zd6/VzwJk7nccJewek0i4Q6GrOHKhZK08pc1CpFVvF WaQ7b1sP0dtSw78Hj6S/MXQnzB+JZqY= X-Received: by 2002:a17:902:7244:: with SMTP id c4-v6mr9965185pll.414.1516836416308; Wed, 24 Jan 2018 15:26:56 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id z19sm9760028pfh.185.2018.01.24.15.26.55 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 15:26:55 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 24 Jan 2018 15:25:59 -0800 Message-Id: <20180124232625.30105-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180124232625.30105-1-richard.henderson@linaro.org> References: <20180124232625.30105-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PATCH v3 19/45] target/hppa: Implement the interval timer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/hppa/cpu.h | 2 ++ target/hppa/helper.h | 3 +++ target/hppa/cpu.c | 8 ++++++++ target/hppa/int_helper.c | 6 ++++++ target/hppa/op_helper.c | 36 ++++++++++++++++++++++++++++++++++++ target/hppa/translate.c | 16 ++++++++++++---- 6 files changed, 67 insertions(+), 4 deletions(-) -- 2.14.3 diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h index fc3e62c0af..31a3702684 100644 --- a/target/hppa/cpu.h +++ b/target/hppa/cpu.h @@ -234,6 +234,7 @@ struct HPPACPU { /*< public >*/ CPUHPPAState env; + QEMUTimer *alarm_timer; }; static inline HPPACPU *hppa_env_get_cpu(CPUHPPAState *env) @@ -341,6 +342,7 @@ int hppa_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int rw, int midx); int hppa_get_physical_address(CPUHPPAState *env, vaddr addr, int mmu_idx, MMUAccessType type, hwaddr *pphys, int *pprot); extern const MemoryRegionOps hppa_io_eir_ops; +void hppa_cpu_alarm_timer(void *); #endif #endif /* HPPA_CPU_H */ diff --git a/target/hppa/helper.h b/target/hppa/helper.h index 535f086ab4..744b11cb66 100644 --- a/target/hppa/helper.h +++ b/target/hppa/helper.h @@ -77,9 +77,12 @@ DEF_HELPER_FLAGS_4(fmpynfadd_s, TCG_CALL_NO_RWG, i32, env, i32, i32, i32) DEF_HELPER_FLAGS_4(fmpyfadd_d, TCG_CALL_NO_RWG, i64, env, i64, i64, i64) DEF_HELPER_FLAGS_4(fmpynfadd_d, TCG_CALL_NO_RWG, i64, env, i64, i64, i64) +DEF_HELPER_FLAGS_0(read_interval_timer, TCG_CALL_NO_RWG, tr) + #ifndef CONFIG_USER_ONLY DEF_HELPER_1(rfi, void, env) DEF_HELPER_1(rfi_r, void, env) +DEF_HELPER_FLAGS_2(write_interval_timer, TCG_CALL_NO_RWG, void, env, tr) DEF_HELPER_FLAGS_2(write_eirr, TCG_CALL_NO_RWG, void, env, tr) DEF_HELPER_FLAGS_2(write_eiem, TCG_CALL_NO_RWG, void, env, tr) DEF_HELPER_FLAGS_2(swap_system_mask, TCG_CALL_NO_RWG, tr, env, tr) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index 888a48f16d..6be6eb0a7b 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -99,6 +99,14 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error **errp) qemu_init_vcpu(cs); acc->parent_realize(dev, errp); + +#ifndef CONFIG_USER_ONLY + { + HPPACPU *cpu = HPPA_CPU(cs); + cpu->alarm_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, + hppa_cpu_alarm_timer, cpu); + } +#endif } /* Sort hppabetically by type name. */ diff --git a/target/hppa/int_helper.c b/target/hppa/int_helper.c index 249e14a2a1..d54d830196 100644 --- a/target/hppa/int_helper.c +++ b/target/hppa/int_helper.c @@ -67,6 +67,12 @@ const MemoryRegionOps hppa_io_eir_ops = { .impl.max_access_size = 4, }; +void hppa_cpu_alarm_timer(void *opaque) +{ + /* Raise interrupt 0. */ + io_eir_write(opaque, 0, 0, 4); +} + void HELPER(write_eirr)(CPUHPPAState *env, target_ureg val) { env->cr[CR_EIRR] &= ~val; diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index 1963b2439b..6d19cab6c9 100644 --- a/target/hppa/op_helper.c +++ b/target/hppa/op_helper.c @@ -22,6 +22,8 @@ #include "exec/exec-all.h" #include "exec/helper-proto.h" #include "exec/cpu_ldst.h" +#include "qemu/timer.h" + void QEMU_NORETURN HELPER(excp)(CPUHPPAState *env, int excp) { @@ -602,7 +604,41 @@ float64 HELPER(fmpynfadd_d)(CPUHPPAState *env, float64 a, float64 b, float64 c) return ret; } +target_ureg HELPER(read_interval_timer)(void) +{ +#ifdef CONFIG_USER_ONLY + /* In user-mode, QEMU_CLOCK_VIRTUAL doesn't exist. + Just pass through the host cpu clock ticks. */ + return cpu_get_host_ticks(); +#else + /* In system mode we have access to a decent high-resolution clock. + In order to make OS-level time accounting work with the cr16, + present it with a well-timed clock fixed at 250MHz. */ + return qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) >> 2; +#endif +} + #ifndef CONFIG_USER_ONLY +void HELPER(write_interval_timer)(CPUHPPAState *env, target_ureg val) +{ + HPPACPU *cpu = hppa_env_get_cpu(env); + uint64_t current = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + uint64_t timeout; + + /* Even in 64-bit mode, the comparator is always 32-bit. But the + value we expose to the guest is 1/4 of the speed of the clock, + so moosh in 34 bits. */ + timeout = deposit64(current, 0, 34, (uint64_t)val << 2); + + /* If the mooshing puts the clock in the past, advance to next round. */ + if (timeout < current + 1000) { + timeout += 1ULL << 34; + } + + cpu->env.cr[CR_IT] = timeout; + timer_mod(cpu->alarm_timer, timeout); +} + target_ureg HELPER(swap_system_mask)(CPUHPPAState *env, target_ureg nsm) { target_ulong psw = env->psw; diff --git a/target/hppa/translate.c b/target/hppa/translate.c index d6c65f314b..1cd57f5a90 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -2038,6 +2038,7 @@ static DisasJumpType trans_mfctl(DisasContext *ctx, uint32_t insn, unsigned rt = extract32(insn, 0, 5); unsigned ctl = extract32(insn, 21, 5); TCGv_reg tmp; + DisasJumpType ret; switch (ctl) { case CR_SAR: @@ -2056,9 +2057,17 @@ static DisasJumpType trans_mfctl(DisasContext *ctx, uint32_t insn, /* FIXME: Respect PSW_S bit. */ nullify_over(ctx); tmp = dest_gpr(ctx, rt); - tcg_gen_movi_reg(tmp, 0); /* FIXME */ + if (ctx->base.tb->cflags & CF_USE_ICOUNT) { + gen_io_start(); + gen_helper_read_interval_timer(tmp); + gen_io_end(); + ret = DISAS_IAQ_N_STALE; + } else { + gen_helper_read_interval_timer(tmp); + ret = DISAS_NEXT; + } save_gpr(ctx, rt, tmp); - break; + return nullify_end(ctx, ret); case 26: case 27: break; @@ -2132,9 +2141,8 @@ static DisasJumpType trans_mtctl(DisasContext *ctx, uint32_t insn, nullify_over(ctx); switch (ctl) { case CR_IT: - /* ??? modify interval timer offset */ + gen_helper_write_interval_timer(cpu_env, reg); break; - case CR_EIRR: gen_helper_write_eirr(cpu_env, reg); break;