From patchwork Wed Feb 7 22:55:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 127211 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp927823ljc; Wed, 7 Feb 2018 14:58:43 -0800 (PST) X-Google-Smtp-Source: AH8x224hZUVeRtPpwomH+EMTyUhrNyUEtOLZ2GkT8ocDbt4Wx5ODvBUy21DPHsYBfIK77bL5JZ8p X-Received: by 10.129.10.215 with SMTP id 206mr5031268ywk.117.1518044323552; Wed, 07 Feb 2018 14:58:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518044323; cv=none; d=google.com; s=arc-20160816; b=g+2DUQNLutkpjHgtQgSsbNhBU3uTiEhr36756SN+cdJxDWfirI8b90hOCqHYQLI7tm zrLwHdbnqBAfrtqY9LHnYUQbArOXDyfSvsFq1/5IeKnSl9KG37UdiRxWkRZf1TICx49L pm7hST7CPI4ziFA0qhN9HIJAfpcrovdbA8ioS9LSYNPy6h+IQefjwtEzRQWOyau9yCEf T2vxSo4YKWbr8XPfAel9qkV4mlPn260DyUndwKsemZPkVacA5q1hdZL4jLO04TZneXS6 gLsGwqEpslFfCiR2BQ4PjES6j/PBq4/Zh69UKopeVjqt/DhMER/D2Uw+9ycOWessinb9 fHBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=RnU0BD+G25LpnQbnsT0zlIIfb1HSGg6KqvOcvfJ6ScI=; b=O3ZojCE8fs0FpDKMmPG1sez+amhZ8tH6Ie34WD23uEFvOmQobYLEIsNi21LSmyjndy 5mSiuy0sYqosOS0VTjkBoMLldAmi4lJL1+4+NeXVFdCCcku2i1HoFeJTaPiT99rhxq7f dzT5Bw6fnulVBCPERBp2+23r45NdHZi8MnhM0ThN8CjQvvQyux7cK7H6ue/2zL3k/OgN WMkXzcT1xtG+UkAMWArYoj1ebvC+6DyGCpAP5Y9QcpYIeyQV33E8++7CQsQYqBxzurnt LNS1eilRfZKm92c/RAlbsRtiEYCh3BjO5QU1Z6WApIvLXeUIhqcaNIlKrLCuO47HifiK dt6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jnky9aF0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id b129si42597ywd.279.2018.02.07.14.58.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 07 Feb 2018 14:58:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jnky9aF0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejYfq-0008Vg-UF for patch@linaro.org; Wed, 07 Feb 2018 17:58:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejYd3-00078E-RM for qemu-devel@nongnu.org; Wed, 07 Feb 2018 17:55:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejYd0-0004gZ-7H for qemu-devel@nongnu.org; Wed, 07 Feb 2018 17:55:49 -0500 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]:39057) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejYcz-0004g1-VT for qemu-devel@nongnu.org; Wed, 07 Feb 2018 17:55:46 -0500 Received: by mail-pl0-x241.google.com with SMTP id o13-v6so983952pli.6 for ; Wed, 07 Feb 2018 14:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RnU0BD+G25LpnQbnsT0zlIIfb1HSGg6KqvOcvfJ6ScI=; b=jnky9aF0GM5fULvffyyJv6yt07FMniBy7eObwiGPN85Vi6T3Nqta5kB4HWlFGLG2U8 fmOTPVL9QkpP/648tKHqxxNUHIOwox1JN9Itv/mzGqhzlDRKs2NAVeVoDKdJR24Ou17S Qvs7JGMk6CGeNZsr12qwEpsWzmiz7SdjXDTdU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RnU0BD+G25LpnQbnsT0zlIIfb1HSGg6KqvOcvfJ6ScI=; b=IsVblzum/6Eb+THIYKroMhhIDqvTETTd360TY+ieneqf4R+lKnzEVhvsDwcVDuiu9R MZHSfb9/VfmPHn+6/ZPf6r9UACQPj6AdtQ09oDynp3W1ie+Q5ErDCavLGhCGgJKNN6xo cwDo8Sx7CgU92TKtLd6K9b6eGJfM6olxjQF8tpkaHj++bCyl7dTnmXvcL7ikevG7Cvbu Xfw0GxkBQ9xuwJbScvAL7+1ty5/fiSajnwKtRtaZ6FqVHQas2T8azbNZNA/6NiC2gedx 9aHKLigLJBQqelqcv1KVy/3A3lOeQnch2eeb59Te5RbL+tFoc95lWVsCXWgdjjOZiWfB v+3Q== X-Gm-Message-State: APf1xPAAsfb7H+P32eQ/B/HdJ7vh/QXkHOv49bwIL8icMTzty1TzRkyG 0HonV2px3p1myzRowe8lU9CtwuoAZys= X-Received: by 2002:a17:902:7042:: with SMTP id h2-v6mr7581213plt.217.1518044144578; Wed, 07 Feb 2018 14:55:44 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id v73sm5874836pfk.84.2018.02.07.14.55.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 14:55:43 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 7 Feb 2018 14:55:21 -0800 Message-Id: <20180207225540.31698-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180207225540.31698-1-richard.henderson@linaro.org> References: <20180207225540.31698-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::241 Subject: [Qemu-devel] [PULL 01/20] tcg: Allow multiple word entries into the constant pool X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This will be required for storing vector constants. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg-pool.inc.c | 115 +++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 93 insertions(+), 22 deletions(-) -- 2.14.3 diff --git a/tcg/tcg-pool.inc.c b/tcg/tcg-pool.inc.c index 8a85131405..ecf7c9282b 100644 --- a/tcg/tcg-pool.inc.c +++ b/tcg/tcg-pool.inc.c @@ -22,39 +22,110 @@ typedef struct TCGLabelPoolData { struct TCGLabelPoolData *next; - tcg_target_ulong data; tcg_insn_unit *label; - intptr_t addend; - int type; + int32_t addend; + uint16_t rtype; + uint16_t nlong; + tcg_target_ulong data[]; } TCGLabelPoolData; -static void new_pool_label(TCGContext *s, tcg_target_ulong data, int type, - tcg_insn_unit *label, intptr_t addend) +static TCGLabelPoolData *new_pool_alloc(TCGContext *s, int nlong, int rtype, + tcg_insn_unit *label, int addend) { - TCGLabelPoolData *n = tcg_malloc(sizeof(*n)); - TCGLabelPoolData *i, **pp; + TCGLabelPoolData *n = tcg_malloc(sizeof(TCGLabelPoolData) + + sizeof(tcg_target_ulong) * nlong); - n->data = data; n->label = label; - n->type = type; n->addend = addend; + n->rtype = rtype; + n->nlong = nlong; + return n; +} + +static void new_pool_insert(TCGContext *s, TCGLabelPoolData *n) +{ + TCGLabelPoolData *i, **pp; + int nlong = n->nlong; /* Insertion sort on the pool. */ - for (pp = &s->pool_labels; (i = *pp) && i->data < data; pp = &i->next) { - continue; + for (pp = &s->pool_labels; (i = *pp) != NULL; pp = &i->next) { + if (nlong > i->nlong) { + break; + } + if (nlong < i->nlong) { + continue; + } + if (memcmp(n->data, i->data, sizeof(tcg_target_ulong) * nlong) >= 0) { + break; + } } n->next = *pp; *pp = n; } +/* The "usual" for generic integer code. */ +static inline void new_pool_label(TCGContext *s, tcg_target_ulong d, int rtype, + tcg_insn_unit *label, int addend) +{ + TCGLabelPoolData *n = new_pool_alloc(s, 1, rtype, label, addend); + n->data[0] = d; + new_pool_insert(s, n); +} + +/* For v64 or v128, depending on the host. */ +static inline void new_pool_l2(TCGContext *s, int rtype, tcg_insn_unit *label, + int addend, tcg_target_ulong d0, + tcg_target_ulong d1) +{ + TCGLabelPoolData *n = new_pool_alloc(s, 2, rtype, label, addend); + n->data[0] = d0; + n->data[1] = d1; + new_pool_insert(s, n); +} + +/* For v128 or v256, depending on the host. */ +static inline void new_pool_l4(TCGContext *s, int rtype, tcg_insn_unit *label, + int addend, tcg_target_ulong d0, + tcg_target_ulong d1, tcg_target_ulong d2, + tcg_target_ulong d3) +{ + TCGLabelPoolData *n = new_pool_alloc(s, 4, rtype, label, addend); + n->data[0] = d0; + n->data[1] = d1; + n->data[2] = d2; + n->data[3] = d3; + new_pool_insert(s, n); +} + +/* For v256, for 32-bit host. */ +static inline void new_pool_l8(TCGContext *s, int rtype, tcg_insn_unit *label, + int addend, tcg_target_ulong d0, + tcg_target_ulong d1, tcg_target_ulong d2, + tcg_target_ulong d3, tcg_target_ulong d4, + tcg_target_ulong d5, tcg_target_ulong d6, + tcg_target_ulong d7) +{ + TCGLabelPoolData *n = new_pool_alloc(s, 8, rtype, label, addend); + n->data[0] = d0; + n->data[1] = d1; + n->data[2] = d2; + n->data[3] = d3; + n->data[4] = d4; + n->data[5] = d5; + n->data[6] = d6; + n->data[7] = d7; + new_pool_insert(s, n); +} + /* To be provided by cpu/tcg-target.inc.c. */ static void tcg_out_nop_fill(tcg_insn_unit *p, int count); static bool tcg_out_pool_finalize(TCGContext *s) { TCGLabelPoolData *p = s->pool_labels; - tcg_target_ulong d, *a; + TCGLabelPoolData *l = NULL; + void *a; if (p == NULL) { return true; @@ -62,24 +133,24 @@ static bool tcg_out_pool_finalize(TCGContext *s) /* ??? Round up to qemu_icache_linesize, but then do not round again when allocating the next TranslationBlock structure. */ - a = (void *)ROUND_UP((uintptr_t)s->code_ptr, sizeof(tcg_target_ulong)); + a = (void *)ROUND_UP((uintptr_t)s->code_ptr, + sizeof(tcg_target_ulong) * p->nlong); tcg_out_nop_fill(s->code_ptr, (tcg_insn_unit *)a - s->code_ptr); s->data_gen_ptr = a; - /* Ensure the first comparison fails. */ - d = p->data + 1; - for (; p != NULL; p = p->next) { - if (p->data != d) { - d = p->data; - if (unlikely((void *)a > s->code_gen_highwater)) { + size_t size = sizeof(tcg_target_ulong) * p->nlong; + if (!l || l->nlong != p->nlong || memcmp(l->data, p->data, size)) { + if (unlikely(a > s->code_gen_highwater)) { return false; } - *a++ = d; + memcpy(a, p->data, size); + a += size; + l = p; } - patch_reloc(p->label, p->type, (intptr_t)(a - 1), p->addend); + patch_reloc(p->label, p->rtype, (intptr_t)a - size, p->addend); } - s->code_ptr = (void *)a; + s->code_ptr = a; return true; }