From patchwork Fri Feb 23 15:36:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 129415 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp757860lja; Fri, 23 Feb 2018 07:55:13 -0800 (PST) X-Google-Smtp-Source: AG47ELs/ve6FocYXIs0Wq/ELfPqFM6gLeOSmDQSxI2AQjPsf9wIOkPWx7y0btrwZ67Yw0qYvlea2 X-Received: by 2002:a25:6112:: with SMTP id v18-v6mr1423021ybb.15.1519401313238; Fri, 23 Feb 2018 07:55:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519401313; cv=none; d=google.com; s=arc-20160816; b=W/t+fdAVcRMGiHhoBZMOBSeoS6ZzyN+D7z4v8tyeuGz/4Lm3R0ElRgFVQPeh2ZTYxR ARVXWr39+iGJ3jdjNg94bOuLXlJ1kAoZG/IW5h4vZ2S4X4Jr6jnB77MEDCnhOHbA8Hh3 K3pjZ06Vli7vjp1x5KKoYwjINefZWRlB+z3/pEM3yqFsRssS1RrgWAs5I1x7m3BqlYqE knlYa10C8zSswUqXtf9VjmmQKohxehMmkDHV00zJTYiL1DTn/E3PgCkt0KUTDgBZabFb X6VeN2f5a82vq5r1LC1mFpJLVdiB8oAj8t4GupPhAMoJGxOkV5S6IFfqIDqie3lhN3Bq QseA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=M/ELSfnaMTKpBPvluZXv1czChxKQ/soVFuTcNVNN2Fg=; b=qma5c2i+BTCs/guda06AEPESnY/HbeWPVpP9V8OuMB9zgoMgsnSPONJ1y74TbQ+6jM baT0m01BIT56630Dvkj5fTeIBxzqraVXz/QgB0wuBTz8SnSUnWS6XXOjNy7nd+HZ9IEz efuANAceKA+tpbJMWeS8v9xgHfF+6tgGXRuEPP/suXpmvtR4B/gyLHtU5oHiyr+OrxcQ EMDZZEvBpeo7PpkFZg1f/d84vGgvjws215ejlakSmbIjjTT0IRAWUtFg0aP6VZX887w8 5GNBDgdKPKZALKtJiRh0WS/PF6ugXR3FaI+5C4UbiTZrcyDWkdziVOCW0G3aE48ps0Pa wAEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cjlJ6gFc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id t67si446690ywt.137.2018.02.23.07.55.13 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 23 Feb 2018 07:55:13 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cjlJ6gFc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epFgm-00031B-Ga for patch@linaro.org; Fri, 23 Feb 2018 10:55:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epFUa-0008K0-VQ for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:42:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epFUa-0005V3-4E for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:42:37 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:50817) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1epFUZ-0005To-TH for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:42:36 -0500 Received: by mail-wm0-x242.google.com with SMTP id k87so5458346wmi.0 for ; Fri, 23 Feb 2018 07:42:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M/ELSfnaMTKpBPvluZXv1czChxKQ/soVFuTcNVNN2Fg=; b=cjlJ6gFcspZNq4kTIdD1SbqEEvOMLY8NB0jyQKdB7t2FNok0RtCLXt81l2+HYx+mJR lBSmTpXMn3L2N02TdtGrZ48R1n9iBASSeA6EXGiPOWt4u6U2TRTfsPvPYPY/1Ovb9H7n BE5vXxLrcfU6Z3mAcWMqNo0C8iX3QFceICdvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M/ELSfnaMTKpBPvluZXv1czChxKQ/soVFuTcNVNN2Fg=; b=ZGQNvSfTBQljXRN4/9yq0XGoiAF3+ipybWOmsMG/tBuuiHsTywzNxHHvLcVKH/nBeH SH7M69Jq1DxQQyD6BmrM1uIX08K/5cxYKsu97wbJTN/JQvnu/ETbvsjFS6DKUTdSevZS WKnIZWZTx8IfJNAkO+Nxm/bnkNdblzPq1iwwcwMgehlY/bTZUblXINNfd6Tt9B3lRfpw djmq0oVL4dyrFzmX93VZtdFndqEPLcViMz1E2vafTpxtdjn2UfNS0vrmo0B+0tkk/4ON jWXSdR9DYUtCHyBLW0n8kcfLRSydumEFhLwCPHpxhGKehHOtayBWNKbraEhrOOedVfIR yG4w== X-Gm-Message-State: APf1xPABwPojk7zCD5f3LdepVqERT/qfPVv5PVxdF9bIVInTIbA/ovS0 1UgVcRpJ2B0bVeBuDUL+CjY8Pw== X-Received: by 10.28.74.66 with SMTP id x63mr1914513wma.4.1519400554748; Fri, 23 Feb 2018 07:42:34 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id h188sm1806595wmf.23.2018.02.23.07.42.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2018 07:42:32 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 2160E3E1615; Fri, 23 Feb 2018 15:36:38 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-arm@nongnu.org Date: Fri, 23 Feb 2018 15:36:26 +0000 Message-Id: <20180223153636.29809-22-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180223153636.29809-1-alex.bennee@linaro.org> References: <20180223153636.29809-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PATCH v3 21/31] arm/translate-a64: add FP16 FNEG/FABS to simd_two_reg_misc_fp16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, qemu-devel@nongnu.org, Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Neither of these operations alter the floating point status registers so we can do a pure bitwise operation, either squashing any sign bit (ABS) or inverting it (NEG). Signed-off-by: Alex Bennée --- v3 - fixup re-base conflicts - make both operations pure bitwise TCG --- target/arm/translate-a64.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.15.1 Reviewed-by: Richard Henderson diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index abe23f7d3f..00b04d34f9 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11262,6 +11262,7 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) TCGv_i32 tcg_rmode = NULL; TCGv_ptr tcg_fpstatus = NULL; bool need_rmode = false; + bool need_fpst = true; int rmode; if (!arm_dc_feature(s, ARM_FEATURE_V8_FP16)) { @@ -11380,6 +11381,10 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) need_rmode = true; rmode = FPROUNDING_ZERO; break; + case 0x2f: /* FABS */ + case 0x6f: /* FNEG */ + need_fpst = false; + break; default: fprintf(stderr, "%s: insn %#04x fpop %#2x\n", __func__, insn, fpop); g_assert_not_reached(); @@ -11403,7 +11408,7 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) return; } - if (need_rmode) { + if (need_rmode || need_fpst) { tcg_fpstatus = get_fpstatus_ptr(true); } @@ -11433,6 +11438,9 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) case 0x7b: /* FCVTZU */ gen_helper_advsimd_f16touinth(tcg_res, tcg_op, tcg_fpstatus); break; + case 0x6f: /* FNEG */ + tcg_gen_xori_i32(tcg_res, tcg_op, 0x8000); + break; default: g_assert_not_reached(); } @@ -11476,6 +11484,12 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) case 0x59: /* FRINTX */ gen_helper_advsimd_rinth_exact(tcg_res, tcg_op, tcg_fpstatus); break; + case 0x2f: /* FABS */ + tcg_gen_andi_i32(tcg_res, tcg_op, 0x7fff); + break; + case 0x6f: /* FNEG */ + tcg_gen_xori_i32(tcg_res, tcg_op, 0x8000); + break; default: g_assert_not_reached(); }