From patchwork Fri Mar 2 11:06:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 130525 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp1161113lja; Fri, 2 Mar 2018 03:28:47 -0800 (PST) X-Google-Smtp-Source: AG47ELtFn1khQAba8FOAR36jmQWewq40cO/cSC80nlQJm79HzQvQO5wpI1YGLfnSyaFe5vgP3o8K X-Received: by 2002:a25:b9c3:: with SMTP id y3-v6mr3339601ybj.263.1519990127883; Fri, 02 Mar 2018 03:28:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519990127; cv=none; d=google.com; s=arc-20160816; b=TaY5km2nvkLT7t051YVyM75r4PlwAS/Hz1fXdLJ1YHLny75YpzNPeaF+xwGD7wmclH DizjDdaWhMX2LidCO2eSbkash5Dg5hIti6hHxh5uKhnBQVhv2e0W6id/Tl954kbiRjLk E/YFk56GlbicQKQl1kzmFGLBe7s6lB4TuqjYW9TaRxn3cXJ0JPg7DRvWimhq5k4LLAu6 aiiPCdrh+xPhf4B5SGhLj3Qoc6e/3EJ3UzrDI/0oUO//a3Wuydo6Qk8IBTup/opZ6kz/ iNc96NGHel0gyMAbeKFruap5ONOovW9Sz2BkII5xccZ3yev04cYgwgX0VmRFlG5xAfrf Cvog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=SK1ReWmppA1DSFwnRIavD495amUEJ85T3J73SK6T+M8=; b=OWRgcNyNVpxrUEZmo1dJSr+efg300r9zFaQ5UHds/pjpYdlVvs9QZFelR+ujOOTomA QlyPau3Q8rDsl0SqNew4PDQADHZWadZS6VhAKKmefTLfvx/CoVHdPszVCn7xbDVQ9KAG FtZneO//vm4TxMY6cuxa+kx738zEgpFMCU2DS5b+qwRJ2t62nW3D0IXQZpOJQ1wYXfIX YRcnFMgdQ81VaW4+RrwCiCnHVYKmRf/hyRrLurKwP3GMojzLBQ0fmioib/rrvSNgdfZN JJx5iIewWGYSPJNfIh5lf9rF8TF3sI0WVSxByTxUvB7jBvi6Pa3gRUqx+UBA7ijF7IzV vuKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id c1si945004ywb.772.2018.03.02.03.28.47 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 02 Mar 2018 03:28:47 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34177 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erirn-0005D6-6L for patch@linaro.org; Fri, 02 Mar 2018 06:28:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eriWq-0003Ag-Bb for qemu-devel@nongnu.org; Fri, 02 Mar 2018 06:07:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eriWm-000538-DS for qemu-devel@nongnu.org; Fri, 02 Mar 2018 06:07:08 -0500 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:46776) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eriWm-00051l-5Q for qemu-devel@nongnu.org; Fri, 02 Mar 2018 06:07:04 -0500 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1eriWl-0001Q5-8A for qemu-devel@nongnu.org; Fri, 02 Mar 2018 11:07:03 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 2 Mar 2018 11:06:32 +0000 Message-Id: <20180302110640.28004-32-peter.maydell@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180302110640.28004-1-peter.maydell@linaro.org> References: <20180302110640.28004-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 31/39] target/arm: Decode aa32 armv8.1 two reg and a scalar X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-id: 20180228193125.20577-9-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate.c | 46 ++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 42 insertions(+), 4 deletions(-) -- 2.16.2 diff --git a/target/arm/translate.c b/target/arm/translate.c index 05fa6a53f9..9169b6b367 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -76,6 +76,10 @@ static const char *regnames[] = { "r0", "r1", "r2", "r3", "r4", "r5", "r6", "r7", "r8", "r9", "r10", "r11", "r12", "r13", "r14", "pc" }; +/* Function prototypes for gen_ functions calling Neon helpers. */ +typedef void NeonGenThreeOpEnvFn(TCGv_i32, TCGv_env, TCGv_i32, + TCGv_i32, TCGv_i32); + /* initialize TCG globals. */ void arm_translate_init(void) { @@ -6985,11 +6989,45 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) } neon_store_reg64(cpu_V0, rd + pass); } - - break; - default: /* 14 and 15 are RESERVED */ - return 1; + case 14: /* VQRDMLAH scalar */ + case 15: /* VQRDMLSH scalar */ + { + NeonGenThreeOpEnvFn *fn; + + if (!arm_dc_feature(s, ARM_FEATURE_V8_RDM)) { + return 1; + } + if (u && ((rd | rn) & 1)) { + return 1; + } + if (op == 14) { + if (size == 1) { + fn = gen_helper_neon_qrdmlah_s16; + } else { + fn = gen_helper_neon_qrdmlah_s32; + } + } else { + if (size == 1) { + fn = gen_helper_neon_qrdmlsh_s16; + } else { + fn = gen_helper_neon_qrdmlsh_s32; + } + } + + tmp2 = neon_get_scalar(size, rm); + for (pass = 0; pass < (u ? 4 : 2); pass++) { + tmp = neon_load_reg(rn, pass); + tmp3 = neon_load_reg(rd, pass); + fn(tmp, cpu_env, tmp, tmp2, tmp3); + tcg_temp_free_i32(tmp3); + neon_store_reg(rd, pass, tmp); + } + tcg_temp_free_i32(tmp2); + } + break; + default: + g_assert_not_reached(); } } } else { /* size == 3 */