From patchwork Thu Mar 8 14:47:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 131025 Delivered-To: patches@linaro.org Received: by 10.46.66.2 with SMTP id p2csp6563996lja; Thu, 8 Mar 2018 06:47:40 -0800 (PST) X-Google-Smtp-Source: AG47ELvkrim6ojePtCFMiw/zHfe+3DL4Px/YEK5Q53AMt2e1ZT4bYx2sb7Sjc7aoqKU1Tzlf0kNO X-Received: by 2002:a17:902:5819:: with SMTP id m25-v6mr23924511pli.248.1520520460116; Thu, 08 Mar 2018 06:47:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520520460; cv=none; d=google.com; s=arc-20160816; b=NKPiEjXo0ZHiaiyWZGjI4iBHKkLR4EtQmIn4Qxn54NXWeSP1ccCdArHo4OyictY6sL H31Bzp3J0qrzYkxqqKlWJj7pdj0nmmH2pHtdZBZTQDe4EFhsSkmwvBmeUYPwvWjLWDeY zg7wezWul9E7Wos6tFpTtzmvTt8h7BHZIL5cvMI2GsbyRwe8YT7F538ZMNDshwvhZXao BfbikO2zm5fMft2ejq8AGk1n44immLeBzm/0AxVlZLfCj2UIMzJ0oCM3rZYT+kQ0tD7j h3L9FWgpbaXHEIIodcTrMhugkmTTJKYTzbJL7QR+YZwXoQg6vzQaipesZSCVzGeriy+Y c5BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=C2gtU+MypoNw+9Xb9z2DhaVp0zGXux6lpIsB6E3QFZ0=; b=KZ2eA3iN2fwGxRfFQ1ppv/B5hLyWbL4F86lmtKwWM3Do0a/+lPLwDXWwdV1MXqed4J T/O1v/SwvxiqLjYNym2//25K7mfAwPKOcwPj7/yFbt01UqgSB2I8N4PJJEJ2OUG4lnA3 OTlGONIIyjazMZNbY51dFxawfoCLjJpI0W5DfY4xdKg13xLllkQdGAN0KSjL+UKs0fHs vvE5IjZlJ53Zr66DteKxFS91qjQJ3R55t0FoEwmCa/iuarQYPN33/q6jD847umsAHwRH emEne2hkrfelE03/KeDdeWQzfom5P+KeswyiED8lOO7S39hyK6OYGQIj2XkdVHkaGWfj AJNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::2 as permitted sender) smtp.mailfrom=pm215@archaic.org.uk; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by mx.google.com with ESMTPS id o2si15968975pfg.286.2018.03.08.06.47.39 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Mar 2018 06:47:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::2 as permitted sender) client-ip=2001:8b0:1d0::2; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::2 as permitted sender) smtp.mailfrom=pm215@archaic.org.uk; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1etwpT-00065r-5e; Thu, 08 Mar 2018 14:47:35 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Riku Voipio , Laurent Vivier , Guan Xuetao Subject: [PATCH 2/2] linux-user: Remove the unused "not implemented" signal handling stubs Date: Thu, 8 Mar 2018 14:47:33 +0000 Message-Id: <20180308144733.25615-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180308144733.25615-1-peter.maydell@linaro.org> References: <20180308144733.25615-1-peter.maydell@linaro.org> Now we've dropped unicore32, all of the architectures we support for linux-user implement the signal handling routines. The dummy "just print a message" versions are unimplemented, so we can drop them entirely. Signed-off-by: Peter Maydell --- IMHO signal handling support is too important to allow a hypothetical new architecture target to silently get away without implementing it. For initial development it's easy enough to stub out the per-architecture functions, and then we will have a clear view of which targets (if any) don't have the signal handling implemented yet, and the missing feature will show up in code review. --- linux-user/signal.c | 27 +-------------------------- 1 file changed, 1 insertion(+), 26 deletions(-) -- 2.16.2 Reviewed-by: Laurent Vivier diff --git a/linux-user/signal.c b/linux-user/signal.c index bd85dcde17..1f7b5e398e 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -6572,32 +6572,7 @@ long do_rt_sigreturn(CPUArchState *env) } #else - -static void setup_frame(int sig, struct target_sigaction *ka, - target_sigset_t *set, CPUArchState *env) -{ - fprintf(stderr, "setup_frame: not implemented\n"); -} - -static void setup_rt_frame(int sig, struct target_sigaction *ka, - target_siginfo_t *info, - target_sigset_t *set, CPUArchState *env) -{ - fprintf(stderr, "setup_rt_frame: not implemented\n"); -} - -long do_sigreturn(CPUArchState *env) -{ - fprintf(stderr, "do_sigreturn: not implemented\n"); - return -TARGET_ENOSYS; -} - -long do_rt_sigreturn(CPUArchState *env) -{ - fprintf(stderr, "do_rt_sigreturn: not implemented\n"); - return -TARGET_ENOSYS; -} - +#error Target needs to add support for signal handling #endif static void handle_pending_signal(CPUArchState *cpu_env, int sig,