From patchwork Fri Mar 23 18:49:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 132361 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp951019ljb; Fri, 23 Mar 2018 11:53:41 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/Bni4JRXjJAWeM34ehhjceUJxtyeSeN2lsCi8RL8V60Yr+fXn/RN/b2PyNshA7/v8I26sk X-Received: by 10.237.45.132 with SMTP id i4mr14482854qtd.64.1521831221549; Fri, 23 Mar 2018 11:53:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521831221; cv=none; d=google.com; s=arc-20160816; b=qyq2PpqkeXN6ELxOZmB4la5hszx8jbYQ4p5mWBgLYCsSOgkAmXNlxnOGxm/gWL5QCH VcffxhayeDF1wP6fN//fvAovNGdqhllzPdiwXpkVwknukzPfef/M08AQ+VSaohrUJnDY SPUaIAMLvsWnnNcwiGuz1xNHKnJQRtOqI7GpDtSJILGN2HDs1ixv1lQ/dPG/7IeYwLNH zTYtT9chkIk7sQQE66AU6uuGDQJKIXfKfSOu8PfJyhjPet4eR+3Sx8pfAZ54uy/jME0M LVjdRqWa5CDr8uGRyMmiFFLbQoqGngO3AIoGjlJ6+uL4V7jcEhR1XXN7g6An5Lyh7lor imGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=e19ubnZjndigbnG5On5otvLrUyWg/I+3Ka1bVcP/Rto=; b=0nnZeDZgnh7VODJVS5E112bWl9M0KdAtekOTGHGICplHQV3Rz7LN67+JBD46FKlveV pzdSXh0cFincqZNp4NStep78fldrx53fqOOGBAxA6Lu/85DxBH/YR4wjfdafuaxhga2C IWK2zitqhUST+Oe0l3e0ETNsIpVwpySdbXjbIgFzKR5Jd6e7ZIeGaEkB8KMKaqQ3j28P IZnvoreCbUKWJ8ALS7QZ6VMLMsg35NEaTK1dbWCCn/Put82kjOkg3zuXcGgssSYSzEqs eAOfee3JzjHJ/Lz29mdY6gTxSPFCbednQjcV24zDGlbtBz2TvFa9EZffyT22weYjzbRl Bcxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id h136si221998qka.142.2018.03.23.11.53.41 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 23 Mar 2018 11:53:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39381 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezRor-0003iF-0h for patch@linaro.org; Fri, 23 Mar 2018 14:53:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezRlM-00017c-O4 for qemu-devel@nongnu.org; Fri, 23 Mar 2018 14:50:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezRlL-0004Ea-PF for qemu-devel@nongnu.org; Fri, 23 Mar 2018 14:50:04 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:40508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ezRlL-0004DB-HX for qemu-devel@nongnu.org; Fri, 23 Mar 2018 14:50:03 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1ezRlI-0007dd-42 for qemu-devel@nongnu.org; Fri, 23 Mar 2018 18:50:00 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 23 Mar 2018 18:49:49 +0000 Message-Id: <20180323184958.14252-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180323184958.14252-1-peter.maydell@linaro.org> References: <20180323184958.14252-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 01/10] arm/translate-a64: treat DISAS_UPDATE as variant of DISAS_EXIT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Victor Kamensky In OE project 4.15 linux kernel boot hang was observed under single cpu aarch64 qemu. Kernel code was in a loop waiting for vtimer arrival, spinning in TC generated blocks, while interrupt was pending unprocessed. This happened because when qemu tried to handle vtimer interrupt target had interrupts disabled, as result flag indicating TCG exit, cpu->icount_decr.u16.high, was cleared but arm_cpu_exec_interrupt function did not call arm_cpu_do_interrupt to process interrupt. Later when target reenabled interrupts, it happened without exit into main loop, so following code that waited for result of interrupt execution run in infinite loop. To solve the problem instructions that operate on CPU sys state (i.e enable/disable interrupt), and marked as DISAS_UPDATE, should be considered as DISAS_EXIT variant, and should be forced to exit back to main loop so qemu will have a chance processing pending CPU state updates, including pending interrupts. This change brings consistency with how DISAS_UPDATE is treated in aarch32 case. CC: Peter Maydell CC: Alex Bennée CC: qemu-stable@nongnu.org Suggested-by: Peter Maydell Signed-off-by: Victor Kamensky Reviewed-by: Richard Henderson Message-id: 1521526368-1996-1-git-send-email-kamensky@cisco.com Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.16.2 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 31ff0479e6..327513ef40 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -13378,12 +13378,12 @@ static void aarch64_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu) case DISAS_UPDATE: gen_a64_set_pc_im(dc->pc); /* fall through */ - case DISAS_JUMP: - tcg_gen_lookup_and_goto_ptr(); - break; case DISAS_EXIT: tcg_gen_exit_tb(0); break; + case DISAS_JUMP: + tcg_gen_lookup_and_goto_ptr(); + break; case DISAS_NORETURN: case DISAS_SWI: break;