From patchwork Wed Mar 28 04:51:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 132511 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp17338ljb; Tue, 27 Mar 2018 21:52:23 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+9TxIGSuAP+dSnGR09ewyEoKQ1WKamhT5QY51IIl6hlH9jrudx7FKmxHK5mPr9Vd9kt7eR X-Received: by 10.200.83.16 with SMTP id t16mr3239526qtn.48.1522212743201; Tue, 27 Mar 2018 21:52:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522212743; cv=none; d=google.com; s=arc-20160816; b=GhOJhwRBYGgQ8jVckaQMJZxQ4bTaUpImh4hmA9WWlrfz73zfLgLYQrC0Vj4gHwezD9 HIT5A3d1ObgG3P4qXejEfAD6EU5yhxg4rEM71N+WGSgpKM3uhRy/+9zP2IU+O/frL/sS DN6UmiOYRCmTg0NgQ7WaAcRpla8Wr4ASBoSrRYLzkNeII7Bra5oxGKzARDUUhb0GvvpJ uOF1SH7Wra/opkFE1rBo/HkvSm6W23gxiKyNwbKC1yj20grr1bBaCfTbaoLpCuLzNXa+ orQSkSDbxlo4eQU7VmD6kVdaXjhsgHAqnBozmGjrGWreh7Fk+jcyTR3VUJAFZ5uwF3oR Ek8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=wNFGM3bCLmKAehEAXo10W5A2S8LlkzGf2v9Pnc6kg2Q=; b=EAYdXNqQIffvEkBXbzQjTmLjZCsDHeaEhBPW96klU3INiHAjtWd0jtj7z2NOarN00D jrhvsh8JxpfdLh1YX/Jrjl6wjx+VYslgWJXp/YZf31Qg9q4TiUPJZ9wmFwxVYePc7Zmg HmxHK1+YxB2Ps/7iGReVpvZeF9YZ7nzi02to95MORf5FDvDTWmJM8QvOCC7kUSfY5pKK Xp0mZebl6+8DrjeHWMMu6Aq41SPxqhacwHuk1x2TGmDF/o621BuzjY1RNCsW64qZCL3B 8xwe80ws61qlH9HMliTzRHJCiMH5ChFKLdkFgtyMBFQDk98NRzbnjGKI3zeMQ1h9bZPQ fBoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Y9tIMiuA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 22si3274719qky.259.2018.03.27.21.52.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 27 Mar 2018 21:52:23 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Y9tIMiuA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37359 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f134O-0006oV-7a for patch@linaro.org; Wed, 28 Mar 2018 00:52:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1341-0006kb-Ul for qemu-devel@nongnu.org; Wed, 28 Mar 2018 00:51:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1340-0007bk-TA for qemu-devel@nongnu.org; Wed, 28 Mar 2018 00:51:58 -0400 Received: from mail-ot0-x241.google.com ([2607:f8b0:4003:c0f::241]:41775) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1340-0007bU-OC for qemu-devel@nongnu.org; Wed, 28 Mar 2018 00:51:56 -0400 Received: by mail-ot0-x241.google.com with SMTP id i28-v6so1282953otf.8 for ; Tue, 27 Mar 2018 21:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wNFGM3bCLmKAehEAXo10W5A2S8LlkzGf2v9Pnc6kg2Q=; b=Y9tIMiuATDVT4lq8xPlQV1Fv5N48NyZmhnuQQFYE8w6LNJOGiqfe4bScEWCcsOwq5N WeSwsSZCi5zKFHQ0xOUbNZ+jWhmWQ0Qz+p6QHLxkmsWsMFIhGgFBxRKqFv5yOy6fi2e+ b8jzGXhIpdyM9NW+fO1w1WfvXqNXDGFCZ65xQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wNFGM3bCLmKAehEAXo10W5A2S8LlkzGf2v9Pnc6kg2Q=; b=pEjtaOzqG8MVOr/ivoF9NW1RdRo3ohZxe2uZSLYaZiizIp1bBeZo8IPfbmW7wN4ycC VSVkqkiI89OVjO5b+6QiH/KF4wPYsIRvIxYabVQYnAo85Ft2+EUEJBRCOAOTsQDE5RK8 1bGTC/Ye7yV7kyryJsEropsPYRXE8qTmAoWei9t0RO29bnDlCICsepFEwEtOD/gc2b30 Y4YDZ3X18DcZBvgOEUpDVxUH1bVsVENFUr4UIygcEv39Y1uWhyQ9tH+Dj2jf+XIL0ANa xZLtAWExXbV8pT8bD0zeHWc2Z1RR792N3rU97j3dd3R7FbePp9WYDvlTdXEgE7N2VsT0 44vw== X-Gm-Message-State: ALQs6tAJ6gr516TPREDUo25rrNJz9e/KJHJlIJA7zQQqIZHL9vPIXVlp gDaZJUkKU8sFgRTytmAbazfJxlU/nmo= X-Received: by 2002:a9d:5697:: with SMTP id o23-v6mr1334465oth.345.1522212715680; Tue, 27 Mar 2018 21:51:55 -0700 (PDT) Received: from cloudburst.twiddle.net ([172.56.7.144]) by smtp.gmail.com with ESMTPSA id n3-v6sm1641209ota.50.2018.03.27.21.51.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Mar 2018 21:51:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 28 Mar 2018 12:51:40 +0800 Message-Id: <20180328045140.16462-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180328045140.16462-1-richard.henderson@linaro.org> References: <20180328045140.16462-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::241 Subject: [Qemu-devel] [PULL 1/1] tcg: Mark muluh_i64 and mulsh_i64 as 64-bit ops X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Failure to do so results in the tcg optimizer sign-extending any constant fold from 32-bits. This turns out to be visible in the RISC-V testsuite using a host that emits these opcodes (e.g. any non-x86_64). Reported-by: Michael Clark Reviewed-by: Emilio G. Cota Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-opc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.14.3 diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h index d81a6c4535..e3a43aabb6 100644 --- a/tcg/tcg-opc.h +++ b/tcg/tcg-opc.h @@ -182,8 +182,8 @@ DEF(add2_i64, 2, 4, 0, IMPL64 | IMPL(TCG_TARGET_HAS_add2_i64)) DEF(sub2_i64, 2, 4, 0, IMPL64 | IMPL(TCG_TARGET_HAS_sub2_i64)) DEF(mulu2_i64, 2, 2, 0, IMPL64 | IMPL(TCG_TARGET_HAS_mulu2_i64)) DEF(muls2_i64, 2, 2, 0, IMPL64 | IMPL(TCG_TARGET_HAS_muls2_i64)) -DEF(muluh_i64, 1, 2, 0, IMPL(TCG_TARGET_HAS_muluh_i64)) -DEF(mulsh_i64, 1, 2, 0, IMPL(TCG_TARGET_HAS_mulsh_i64)) +DEF(muluh_i64, 1, 2, 0, IMPL64 | IMPL(TCG_TARGET_HAS_muluh_i64)) +DEF(mulsh_i64, 1, 2, 0, IMPL64 | IMPL(TCG_TARGET_HAS_mulsh_i64)) #define TLADDR_ARGS (TARGET_LONG_BITS <= TCG_TARGET_REG_BITS ? 1 : 2) #define DATA64_ARGS (TCG_TARGET_REG_BITS == 64 ? 1 : 2)